fanquake 80d4231e16

Merge #19980: refactor: Some wallet cleanups ...

9b74461fa293453a9eb0b1717b30b3f7fa778d91 refactor: Assert before dereference in CWallet::GetDatabase (João Barbosa)
021feb3187b207d511561c1f0ffd7f9e5e0c9c1d refactor: Drop redudant CWallet::GetDBHandle (João Barbosa)

Pull request description:

ACKs for top commit:
  achow101:
    Code Review ACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91
  meshcollider:
    utACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91
  ryanofsky:
    Code review ACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91. Changes since last review: rebasing due to conflict, dropping wallet path commit c6a5cd7a64c78b162f545a3467d0fea7dcaadfcc as suggested in discussion, making GetDatabase() const in the earlier commit. Giving more descriptive title like

Tree-SHA512: 68cf3b5e9fe0acb3a5cd081086629989f213f1904cc344e5775767b56759a7d905b1e1c303afbe40f172ff81bf07f3719b59d8f6ec2de3fdd53cd0e2d220fb25

2020-12-02 08:23:00 +08:00

..

test

Merge #15710: wallet: Catch ios_base::failure specifically

2020-11-19 12:32:48 +01:00

bdb.cpp

…

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

interfaces.cpp

Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp

2020-11-24 10:20:16 -05:00

ismine.h

…

load.cpp

Ignoring (but warn) on duplicate -wallet parameters

2020-11-03 12:06:32 +01:00

load.h

…

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

Merge #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC endpoint wallet

2020-11-28 10:14:45 +01:00

rpcwallet.h

…

salvage.cpp

Enforce salvage is only for BDB wallets

2020-11-18 11:56:12 -05:00

salvage.h

…

scriptpubkeyman.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

scriptpubkeyman.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

sqlite.cpp

Fix mock SQLiteDatabases

2020-11-18 11:56:12 -05:00

sqlite.h

…

wallet.cpp

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

wallet.h

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.cpp

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

wallettool.h

…

walletutil.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

walletutil.h

…