MarcoFalke 38389dd3a0 Merge #19252: test: wait for disconnect in disconnect_p2ps + bloomfilter test followups ...

9a40cfc558 [refactor] use waiting inside disconnect_p2ps (gzhao408)
aeb9fb414e [test] wait for disconnect_p2ps to be reflected in getpeerinfo (gzhao408)
e81942d2e1 [test] logging and style followups for bloomfilter tests (gzhao408)

Pull request description:

  Followup to #19083 which adds bloomfilter-related tests.

  1. Make test_node `disconnect_p2ps` wait until disconnection is complete to avoid race conditions (and not place the burden on tests) from MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/19083#discussion_r437383989). And clean up any redundant `wait_until`s in the functional tests.
  2. Clean up style + logging in p2p_filter.py and p2p_nobloomfilter_messages.py and jonatack's other [comments](https://github.com/bitcoin/bitcoin/pull/19083#pullrequestreview-428955784)

ACKs for top commit:
  jonatack:
    Code review ACK 9a40cfc from re-reviewing the diff and `git range-diff 5cafb46 8386ad5 9a40cfc`
  MarcoFalke:
    ACK 9a40cfc558 🐂

Tree-SHA512: 2e14b1c12fc08a355bd5ccad7a2a734a4ccda4bc7dc7bac171cb57359819fc1599d764290729af74832fac3e2be258c5d406c701e78ab6d7262835859b9a7d87

2020-06-17 06:20:10 -04:00

..

__init__.py

…

address.py

Revert "[TESTS] Move base58 to own module to break circular dependency"

2020-06-10 11:54:25 -04:00

authproxy.py

test: Try once more when RPC connection fails on Windows

2020-04-12 09:04:15 -04:00

blocktools.py

[test] CScriptNum Decode Check as Unit Tests

2020-06-03 07:18:01 -07:00

coverage.py

…

descriptors.py

Output a descriptor in createmultisig and addmultisigaddress

2020-01-30 23:55:36 -05:00

key.py

[tests] move generate_wif_key to wallet_util.py

2020-06-10 12:10:02 -04:00

messages.py

[test] Add test for cfilters.

2020-05-26 17:38:26 -04:00

mininode.py

[tests] Make mininode_lock non-reentrant

2020-06-05 11:01:54 -04:00

netutil.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

script_util.py

test: Remove unused, undocumented and misleading CScript.__add__

2020-04-22 09:00:56 -04:00

script.py

Merge #19082: test: Moved the CScriptNum asserts into the unit test in script.py

2020-06-04 17:28:55 +02:00

segwit_addr.py

…

siphash.py

…

socks5.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

test_framework.py

test: refactor: Inline adjust_bitcoin_conf_for_pre_17

2020-06-16 08:27:57 -04:00

test_node.py

[test] wait for disconnect_p2ps to be reflected in getpeerinfo

2020-06-16 08:26:13 -07:00

test_shell.py

TestShell: Return self from setup()

2019-11-05 12:55:52 +01:00

util.py

pep-8 test/functional/test_framework/util.py

2020-06-16 08:28:06 -04:00

wallet_util.py

[tests] move generate_wif_key to wallet_util.py

2020-06-10 12:10:02 -04:00