Ava Chow 81174d8a9b Merge bitcoin/bitcoin#29961: refactor: remove remaining unused code from cpp-subprocess ...

8b52e7f628 update comments in cpp-subprocess (check_output references) (Sebastian Falbesoner)
97f159776e remove unused method `Popen::kill` from cpp-subprocess (Sebastian Falbesoner)
908c51fe4a remove commented out code in cpp-subprocess (Sebastian Falbesoner)
ff79adbe05 remove unused templates from cpp-subprocess (Sebastian Falbesoner)

Pull request description:

  This PR removes remaining code that is unused within the cpp-subprocess module (templates and commented out code). Happy to add more removals if anyone finds more unused parts. Note that there are some API functions of the `Popen` class that we don't use, e.g. `wait()`, `pid()`, `poll()`, `kill()`, but they sound IMHO common enough to be useful in the future, so not sure how deep we should go there.

ACKs for top commit:
  fjahr:
    Code review ACK 8b52e7f628
  achow101:
    ACK 8b52e7f628
  hebasto:
    ACK 8b52e7f628.

Tree-SHA512: 14c1cd2216185d941923f06fdc7acbeed66cd87e2691d9a352f7309b3e07fe4877b580f598a2e4106f9c48395ed6de00a0bfb5d3c3af9c4624d1956a0f543e99

2024-05-02 16:33:18 -04:00

..

any.h

…

asmap.cpp

crypto: replace CountBits with std::bit_width

2024-02-26 16:13:12 +00:00

asmap.h

…

batchpriority.cpp

…

batchpriority.h

…

bip32.cpp

…

bip32.h

…

bitdeque.h

refactor: Fix "error C2248: cannot access private member" on MSVC

2024-04-28 07:11:24 +01:00

bytevectorhash.cpp

…

bytevectorhash.h

…

chaintype.cpp

…

chaintype.h

…

check.cpp

removed StrFormatInternalBug quote delimitation

2023-08-18 04:04:06 +00:00

check.h

Export assert from util/check.h

2023-11-24 13:11:36 +01:00

epochguard.h

…

error.cpp

…

error.h

…

exception.cpp

…

exception.h

…

fastrange.h

…

feefrac.cpp

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

feefrac.h

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

fees.cpp

…

fees.h

…

fs_helpers.cpp

Remove unused g++-10 workaround

2024-03-14 15:53:43 +01:00

fs_helpers.h

Remove DirIsWritable, GetUniquePath

2023-10-26 10:32:56 +02:00

fs.cpp

Add tests for C++20 std::u8string

2023-12-11 17:42:05 +01:00

fs.h

refactor: Rename fs::path::u8string() to fs::path::utf8string()

2023-12-14 16:22:40 +01:00

golombrice.h

…

hash_type.h

…

hasher.cpp

…

hasher.h

Bump g++ minimum supported version to 10

2023-10-30 15:12:26 +01:00

insert.h

…

macros.h

…

message.cpp

Make WitnessUnknown members private

2023-09-12 12:14:31 -04:00

message.h

…

moneystr.cpp

…

moneystr.h

…

overflow.h

…

overloaded.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

rbf.cpp

…

rbf.h

…

readwritefile.cpp

…

readwritefile.h

…

result.h

refactor: Avoid copying util::Result values

2024-04-25 16:08:24 -04:00

serfloat.cpp

…

serfloat.h

…

signalinterrupt.cpp

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

signalinterrupt.h

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

sock.cpp

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

sock.h

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

spanparsing.cpp

…

spanparsing.h

…

strencodings.cpp

Merge bitcoin/bitcoin#29606: refactor: Reserve memory for ToLower/ToUpper conversions

2024-03-13 08:18:06 -04:00

strencodings.h

doc: remove out-of-date external link in src/util/strencodings.h

2023-08-24 15:51:25 -06:00

string.cpp

…

string.h

[clang-tidy] Enable the misc-no-recursion check

2024-04-07 14:04:45 +01:00

subprocess.h

update comments in cpp-subprocess (check_output references)

2024-04-28 14:18:06 +02:00

syserror.cpp

…

syserror.h

…

task_runner.h

kernel: Remove dependency on CScheduler

2024-02-16 17:12:52 +01:00

thread.cpp

…

thread.h

…

threadinterrupt.cpp

…

threadinterrupt.h

…

threadnames.cpp

…

threadnames.h

…

time.cpp

refactor: Use chrono type for g_mock_time

2024-04-15 13:34:31 +02:00

time.h

Revert "time: add runtime sanity check"

2024-03-18 16:01:08 +01:00

tokenpipe.cpp

…

tokenpipe.h

…

trace.h

Revert "tracepoints: Disables -Wgnu-zero-variadic-macro-arguments to compile without warnings"

2023-12-07 11:06:13 +01:00

transaction_identifier.h

Add transaction_identifier::size to allow Span conversion

2024-02-27 14:19:15 +00:00

translation.h

…

types.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

ui_change_type.h

…

vector.h

chainparams: add blockhash to AssumeutxoData

2023-09-30 06:38:47 -04:00