Sjors Provoost 807de2cebd wallet: skip R-value grinding for external signers ...

When producing a dummy signature for the purpose of estimating the transaction fee, do not assume an external signer performs R-value grinding on the signature.

In particular, this avoids a scenario where the fee rate is 1 sat / vbyte and a transaction with a 72 byte signature is not accepted into our mempool.

This commit also  drops the nullptr default for CCoinControl arguments for functions that it touches. This is because having a boolean argument right next to an optional pointer is error prone.

Co-Authored-By: S3RK <1466284+S3RK@users.noreply.github.com>

2023-02-23 18:30:12 +01:00

..

rpc

Merge bitcoin/bitcoin#27068: wallet: SecureString to allow null characters

2023-02-22 13:02:16 -05:00

test

Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin

2023-02-17 17:28:14 -05:00

bdb.cpp

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

bdb.h

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

dump.cpp

refactor: remove <util/system.h> include from wallet.h

2023-02-15 15:49:45 -03:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

wallet: set keypool_size instead of access global args manager

2023-02-15 15:49:44 -03:00

feebumper.cpp

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

feebumper.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

fees.cpp

…

fees.h

…

init.cpp

Remove -sysperms option

2023-02-05 08:09:16 +00:00

interfaces.cpp

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

ismine.h

…

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

salvage.cpp

refactor: wallet, remove global 'ArgsManager' access

2023-02-15 15:49:45 -03:00

salvage.h

…

scriptpubkeyman.cpp

wallet: annotate bools in descriptor SPKM FillPSBT()

2023-02-23 11:46:29 +01:00

scriptpubkeyman.h

wallet: set keypool_size instead of access global args manager

2023-02-15 15:49:44 -03:00

spend.cpp

wallet: skip R-value grinding for external signers

2023-02-23 18:30:12 +01:00

spend.h

wallet: skip R-value grinding for external signers

2023-02-23 18:30:12 +01:00

sqlite.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

sqlite.h

Use DataStream where possible

2023-01-26 10:44:05 +01:00

transaction.cpp

…

transaction.h

Merge bitcoin/bitcoin#26499: wallet: Abandon descendants of orphaned coinbases

2023-01-30 10:09:41 +00:00

wallet.cpp

wallet: skip R-value grinding for external signers

2023-02-23 18:30:12 +01:00

wallet.h

wallet: skip R-value grinding for external signers

2023-02-23 18:30:12 +01:00

walletdb.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

walletdb.h

Use DataStream where possible

2023-01-26 10:44:05 +01:00

wallettool.cpp

refactor: wallet, remove global 'ArgsManager' access

2023-02-15 15:49:45 -03:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…