Andrew Chow 9b68c9b85e Merge bitcoin/bitcoin#28172: refactor: use string_view for passing string literals to Parse{Hash,Hex} ...

bb91131d54 doc: remove out-of-date external link in src/util/strencodings.h (Jon Atack)
7d494a48dd refactor: use string_view to pass string literals to Parse{Hash,Hex} (Jon Atack)

Pull request description:

  as `string_view` is optimized to be trivially copiable, whereas the current code creates a `std::string` copy at each call.

  These utility methods are called by quite a few RPCs and tests, as well as by each other.

  ```
  $ git grep "ParseHashV\|ParseHashO\|ParseHexV\|ParseHexO" | wc -l
  61
  ```

  Also remove an out-of-date external link.

ACKs for top commit:
  jonatack:
    Rebased per `git range-diff c9273f6 b94581a bb91131` for an include header from the merge of https://github.com/bitcoin/bitcoin/pull/28230. Should be trivial to re-ACK.
  maflcko:
    lgtm ACK bb91131d54
  ns-xvrn:
    ACK bb91131d54
  achow101:
    ACK bb91131d54
  brunoerg:
    crACK bb91131d54

Tree-SHA512: 9734fe022c9e43fd93c23a917770d332dbbd3132c80a234059714c32faa6469391e59349954749fc86c4ef0b18d5fd99bf8f4b7b82d9f799943799c1253272ae

2023-11-02 15:45:13 -04:00

..

blockchain.cpp

scripted-diff: Rename hash_serialized_2 to hash_serialized_3

2023-10-20 22:53:06 +02:00

blockchain.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

client.cpp

rpc: addnode arg to use BIP324 v2 p2p

2023-10-02 18:10:30 -04:00

client.h

refactor: rpc: hide and rename ParseNonRFCJSONValue()

2023-03-23 18:18:46 +00:00

external_signer.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

fees.cpp

rpc: Run type check against RPCArgs

2023-01-11 17:42:09 +01:00

mempool.cpp

Fix bugprone-lambda-function-name errors

2023-10-26 16:58:36 +02:00

mempool.h

rpc: Move mempool RPCs to new file

2022-03-11 17:46:58 +01:00

mining.cpp

rpc: Add MaybeArg() and Arg() default helper

2023-08-24 10:44:45 +02:00

mining.h

rpc: create rpc/mining.h, hoist default max tries values to constant

2020-06-01 15:08:36 +02:00

net.cpp

Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet

2023-10-26 14:29:47 -04:00

node.cpp

Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers

2023-08-07 22:31:46 +02:00

output_script.cpp

Add PubKeyDestination for P2PK scripts

2023-09-12 12:14:31 -04:00

protocol.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rawtransaction_util.cpp

Fix clang-tidy performance-unnecessary-copy-initialization warnings

2023-05-09 18:48:52 +02:00

rawtransaction_util.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

rawtransaction.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

register.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

request.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

request.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

server_util.cpp

refactor: add and use EnsureAnyAddrman in rpc

2023-10-04 08:53:51 +05:30

server_util.h

refactor: add and use EnsureAnyAddrman in rpc

2023-10-04 08:53:51 +05:30

server.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

server.h

RPC: Add add OBJ_NAMED_PARAMS type

2023-05-03 11:27:51 -05:00

signmessage.cpp

rpc: Move signmessage RPC util to new file

2022-04-28 11:19:29 +02:00

txoutproof.cpp

refactor: Move functions to BlockManager methods

2023-05-10 19:06:53 +02:00

util.cpp

Merge bitcoin/bitcoin#28172: refactor: use string_view for passing string literals to Parse{Hash,Hex}

2023-11-02 15:45:13 -04:00

util.h

refactor: use string_view to pass string literals to Parse{Hash,Hex}

2023-08-24 15:51:22 -06:00