Samuel Dobson 200d97faf2 Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked ...

f13a22a631 wallet: Call load handlers without cs_wallet locked (João Barbosa)

Pull request description:

  Don't have `cs_wallet` locked while calling each `context.wallet_load_fns`. A load handler can always lock `cs_wallet` if needed.

  The lock was added in 1c7e25db0c to satisfy TSAN. With 44c430ffac most of the code requiring the lock is in `CWallet::AttachChain`. A comment is added to warn about wallets_mutex and cs_wallet lock ordering.

ACKs for top commit:
  meshcollider:
    re-utACK f13a22a631
  ryanofsky:
    Code review ACK f13a22a631. Only change since last review is adding a lock order comment
  jonatack:
    ACK f13a22a631

Tree-SHA512: d51976c3aae4bebc2d1997c88edff712d21fc5523801f5614062a10f826e164579973aeb1981bb1cbc243ecff6af3250362f544c02a79e5d135cbbca1704be62

2021-11-27 22:30:46 +13:00

..

test

Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked

2021-11-27 22:30:46 +13:00

bdb.cpp

…

bdb.h

wallet: Fixed Grammatical error in bdb.h

2021-11-09 12:41:37 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

wallet: Call load handlers without cs_wallet locked

2021-11-22 09:42:36 +00:00

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Mention bech32m in -addresstype and -changetype help

2021-11-16 12:20:13 -05:00

interfaces.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

ismine.h

…

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

rpcdump.cpp

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

rpcwallet.cpp

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

rpcwallet.h

doc: Fix typos in endif header comments

2021-11-16 09:56:45 +01:00

salvage.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22364: wallet: Make a tr() descriptor by default

2021-11-22 10:01:17 +01:00

scriptpubkeyman.h

…

spend.cpp

…

spend.h

…

sqlite.cpp

…

sqlite.h

…

transaction.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

transaction.h

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

wallet.cpp

Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked

2021-11-27 22:30:46 +13:00

wallet.h

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

walletdb.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

walletdb.h

…

wallettool.cpp

Merge bitcoin/bitcoin#23349: util: Use FEATURE_LATEST for wallets created with bitcoin-wallet

2021-11-16 15:32:18 +13:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…