highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-19 12:10:19 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
83e1d92413e262e6a876336ec433a6fbc335223a
bitcoin/src
History
MarcoFalke ac579ada7e Merge #18278: interfaces: Describe and follow some code conventions 
3dc27a1524 doc: Add internal interface conventions to developer notes (Russell Yanofsky)
1dca9dc4c7 refactor: Change createWallet, fillPSBT argument order (Russell Yanofsky)
96dfe5ced6 refactor: Change Chain::broadcastTransaction param order (Russell Yanofsky)
6ceb21909c refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods (Russell Yanofsky)
1c2ab1a6d2 refactor: Rename Node::disconnect methods (Russell Yanofsky)
77e4b06572 refactor: Get rid of Wallet::IsWalletFlagSet method (Russell Yanofsky)

Pull request description:

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

  This PR doesn't change behavior at all, it just cleans up code in [`src/interfaces`](https://github.com/bitcoin/bitcoin/tree/master/src/interfaces) to simplify #10102, and [documents](https://github.com/ryanofsky/bitcoin/blob/pr/ipc-conv/doc/developer-notes.md#internal-interface-guidelines) coding conventions there better

ACKs for top commit:
  hebasto:
    re-ACK 3dc27a1524, the only change since the [previous](https://github.com/bitcoin/bitcoin/pull/18278#pullrequestreview-372582146) review is rebasing.
  MarcoFalke:
    ACK 3dc27a1524 🕍

Tree-SHA512: 62e6a0f2488e3924e559d2074ed460b92e7a0a5d98eab492221cb20d59d04bbe32aef2a8aeba5e4ea9168cfa91acd5bc973dce6677be0180bd7a919354df53ed
2020-03-23 16:37:50 -04:00
..
bench
Merge #16902: O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation
2020-03-14 21:03:45 +01:00
compat
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
config
…
consensus
Update merkle.cpp
2020-03-18 10:34:53 -07:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
Merge #17691: doc: Add missed copyright headers
2020-01-16 15:58:35 -05:00
index
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
interfaces
refactor: Change createWallet, fillPSBT argument order
2020-03-19 15:26:04 -05:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
doc: Correct spelling errors in comments
2020-03-02 23:07:21 -08:00
node
doc: Correct spelling errors in comments
2020-03-02 23:07:21 -08:00
policy
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
primitives
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
qt
refactor: Change createWallet, fillPSBT argument order
2020-03-19 15:26:04 -05:00
rpc
rpc: add missing HelpExampleRpc for getblockfilter
2020-03-21 10:03:40 +01:00
script
Merge #16902: O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation
2020-03-14 21:03:45 +01:00
secp256k1
…
support
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
test
tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harness
2020-03-22 13:29:00 +00:00
univalue
Update univalue subtree
2020-02-09 07:44:29 -08:00
util
Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan
2020-03-09 11:16:20 -04:00
wallet
refactor: Change Chain::broadcastTransaction param order
2020-03-19 15:26:04 -05:00
zmq
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
.clang-format
…
addrdb.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrdb.h
Convert addrdb/addrman to new serialization
2020-01-02 11:05:36 -08:00
addrman.cpp
logging: asmap logging and #include fixups
2020-03-04 14:24:19 +01:00
addrman.h
logging: asmap logging and #include fixups
2020-03-04 14:24:19 +01:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
banman.h
refactor: move DUMP_BANS_INTERVAL to banman.h
2020-03-10 09:52:53 -04:00
base58.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
base58.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
bitcoin-wallet: Use PACKAGE_NAME in usage help
2020-01-14 18:19:00 +00:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
blockencodings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockencodings.h
Convert blockencodings.h to new serialization framework
2020-02-25 14:10:44 -08:00
blockfilter.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockfilter.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
chainparams.cpp
[test] add chainparams property to indicate chain allows time mocking
2020-02-13 08:59:51 -08:00
chainparams.h
[test] add chainparams property to indicate chain allows time mocking
2020-02-13 08:59:51 -08:00
chainparamsbase.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsbase.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsseeds.h
…
checkqueue.h
refactor: Remove redundant conditional
2020-01-21 14:07:42 +00:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
coins.h
Convert compression.h to new serialization framework
2020-01-21 20:29:11 -08:00
compat.h
…
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
Merge #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness
2020-03-05 15:25:36 -05:00
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_write.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
cuckoocache.h
Use correct C++11 header for std::swap()
2019-11-29 21:23:25 +02:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dummywallet.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
flatfile.cpp
…
flatfile.h
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
fs.cpp
scripted-diff: Add missed copyright headers
2020-01-04 20:18:28 +02:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
…
hash.h
…
httprpc.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
httprpc.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httpserver.cpp
httpserver: use own HTTP status codes
2020-02-18 08:29:35 +01:00
httpserver.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
indirectmap.h
Add missing includes
2020-01-31 12:36:13 +00:00
init.cpp
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
init.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
logging.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
Makefile.am
Move FillPSBT to be a member of CWallet
2020-03-09 11:16:17 -04:00
Makefile.bench.include
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00
Makefile.crc32c.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.leveldb.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.qt_locale.include
Restore English translation option
2020-01-06 22:58:47 -05:00
Makefile.qt.include
Merge #17513: refactor, qt: Nuke some circular dependencies
2019-11-21 19:38:39 +01:00
Makefile.qttest.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
Makefile.test_util.include
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00
Makefile.test.include
tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker
2020-03-17 19:10:59 +00:00
memusage.h
Add missing includes
2020-01-31 12:36:13 +00:00
merkleblock.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
merkleblock.h
…
miner.cpp
Refactor FormatStateMessage into ValidationState
2020-02-27 17:59:07 -08:00
miner.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net_permissions.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
net_permissions.h
net: Remove forcerelay of rejected txs
2020-02-11 07:44:12 -08:00
net_processing.cpp
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
net_processing.h
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
net.h
refactor: Convert ping wait time from double to int64_t
2020-03-04 13:45:29 -05:00
netaddress.cpp
net: extract conditional to bool CNetAddr::IsHeNet
2020-03-04 14:31:31 +01:00
netaddress.h
net: extract conditional to bool CNetAddr::IsHeNet
2020-03-04 14:31:31 +01:00
netbase.cpp
Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.
2020-01-22 20:20:45 +01:00
netbase.h
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
noui.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
Revert "Store p2sh scripts in AddAndGetDestinationForScript"
2020-02-12 11:48:30 -05:00
outputtype.h
List output types in an array in order to be iterated over
2020-01-23 16:35:06 -05:00
pow.cpp
…
pow.h
…
prevector.h
Make VectorFormatter support stateful formatters
2020-02-15 19:49:24 -08:00
protocol.cpp
…
protocol.h
Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr
2019-12-11 17:00:27 -05:00
psbt.cpp
Merge #17156: psbt: check that various indexes and amounts are within bounds
2020-01-29 19:39:50 +08:00
psbt.h
Fix doxygen errors
2020-01-16 18:25:11 -08:00
pubkey.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pubkey.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
random.cpp
build: fix sysctl() detection on macOS
2020-03-19 11:36:38 +08:00
random.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
randomenv.cpp
Drop unused mach time headers
2020-02-28 14:56:49 -08:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
reverse_iterator.h
…
scheduler.cpp
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
scheduler.h
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
serialize.h
Merge #18112: Serialization improvements step 5 (blockencodings)
2020-03-05 19:56:26 +01:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
sync.cpp
sync.h: add REVERSE_LOCK
2020-03-06 23:13:31 +10:00
sync.h
Fix missing header in sync.h
2020-03-15 22:43:39 +00:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
timedata.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
torcontrol.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.cpp
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
txdb.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
txmempool.cpp
[mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks
2020-03-11 18:38:33 -04:00
txmempool.h
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
ui_interface.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
ui_interface.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
uint256.cpp
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
uint256.h
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
undo.h
Convert undo.h to new serialization framework
2020-02-06 19:08:11 -08:00
validation.cpp
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
validation.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
validationinterface.cpp
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
validationinterface.h
[validation interface] Remove vtxConflicted from BlockConnected
2020-03-11 18:38:33 -04:00
version.h
…
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00