fanquake d052f5e6b7 Merge #16841: Replace GetScriptForWitness with GetScriptForDestination ...

7966aa424a Add variables for repeated scripts (MeshCollider)
fec8336ad9 Remove GetScriptForWitness function (MeshCollider)
b887060d06 Replace usage of GetScriptForWitness with GetScriptForDestination (MeshCollider)

Pull request description:

  As per this TODO in the code:

  > TODO: replace calls to GetScriptForWitness with GetScriptForDestination using the various witness-specific CTxDestination subtypes.

  The commit "Add additional check for P2SH before adding extra wrapper" also adds an additional check that the scriptPubKey is a P2SH before auto-wrapping the witness script. We shouldn't wrap the witness script if not. Note: #16251 is even better than this check, please review that.

ACKs for top commit:
  instagibbs:
    ACK 7966aa424a
  jonatack:
    Code review re-ACK 7966aa4 per `git range-diff b4d0366 ed266f7 7966aa4`
  achow101:
    re-ACK 7966aa424a only changes since last is rebase.

Tree-SHA512: 3449e0e83bd842acc7c94544a85367da97ac20d859eefc1a618caef0c98204398c266fe8fb9600b78326df5175402e1ae4a132eb766e2c4485e7cda6a2a95c43

2020-08-15 08:54:45 +08:00

..

bitcoinconsensus.cpp

Drop unused GetType() from CSizeComputer

2018-09-11 00:58:05 -04:00

bitcoinconsensus.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

descriptor.cpp

refactor: Make HexStr take a span

2020-08-06 19:41:43 +02:00

descriptor.h

Add IsSingleType to Descriptors

2020-04-23 13:59:48 -04:00

interpreter.cpp

Make CHash256/CHash160 output to Span

2020-07-30 13:57:54 -07:00

interpreter.h

[REFACTOR] Initialize PrecomputedTransactionData in CheckInputScripts

2020-04-11 21:32:45 -04:00

keyorigin.h

Convert everything except wallet/qt to new serialization

2020-03-30 16:10:30 -07:00

script_error.cpp

refactor: Replace const char* to std::string

2020-05-22 01:40:31 +09:00

script_error.h

refactor: Replace const char* to std::string

2020-05-22 01:40:31 +09:00

script.cpp

refactor: Replace const char* to std::string

2020-05-22 01:40:31 +09:00

script.h

Merge #19004: refactor: Replace const char* to std::string

2020-05-27 07:16:10 -04:00

sigcache.cpp

refactor: Specify boost/thread/thread.hpp explicitly

2020-06-04 10:05:54 -04:00

sigcache.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

sign.cpp

Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code

2020-07-15 15:29:22 +12:00

sign.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

signingprovider.cpp

Use explicit conversion from WitnessV0KeyHash -> CKeyID

2020-06-19 12:14:08 -07:00

signingprovider.h

wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition

2020-02-12 11:48:30 -05:00

standard.cpp

Remove GetScriptForWitness function

2020-08-14 08:47:19 +12:00

standard.h

Remove GetScriptForWitness function

2020-08-14 08:47:19 +12:00