Wladimir J. van der Laan 8480d41e0f Merge #12803: Make BaseSignatureCreator a pure interface ...

be67831 Make DummySignatureCreator a singleton (Pieter Wuille)
190b8d2 Make BaseSignatureCreator a pure interface (Pieter Wuille)

Pull request description:

  * Removes the `m_provider` field from `BaseSignatureCreator`. Instead both a `SigningProvider` (which provides keys and scripts) and a `BaseSignatureCreator` (which implements the transaction-specific (or other) signing logic) are passed into and down in `ProduceSignature`, making the two concepts orthogonal.
  * Makes `BaseSignatureCreator` a pure interface without constructor, making it easier to implement new derivations of it (for example for message signing).
  * As `DummySignatureCreator` now becomes a stateless object, turn it into a singleton `DUMMY_SIGNATURE_CREATOR`.

Tree-SHA512: 5f1f4512e4ea7d02a31df7b9ede55008efa716c5b74a2630ca1c2fc6599584d8bf5f5641487266127f4b3788033803539fbd22b03ef1219c83c10da2d3da3dcd

2018-04-12 22:55:56 +02:00

..

blockchain.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

blockchain.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

client.cpp

[wallet] [rpc] introduce 'label' API for wallet

2018-04-10 19:27:22 -04:00

client.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

mining.cpp

Merge #12007: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC

2018-04-09 08:04:10 -04:00

mining.h

scripted-diff: Replace #include "" with #include <> (ryanofsky)

2017-11-16 08:23:01 +13:00

misc.cpp

Merge #11372: Address encoding cleanup

2018-03-07 00:09:48 +01:00

net.cpp

fix version typo

2018-02-27 11:43:46 +01:00

protocol.cpp

scripted-diff: Use UniValue.pushKV instead of push_back(Pair())

2018-02-10 10:05:07 -05:00

protocol.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

rawtransaction.cpp

Merge #12803: Make BaseSignatureCreator a pure interface

2018-04-12 22:55:56 +02:00

rawtransaction.h

Declare CMutableTransaction a struct in rawtransaction.h

2018-02-20 14:16:37 -08:00

register.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

safemode.cpp

scripted-diff: Replace #include "" with #include <> (ryanofsky)

2017-11-16 08:23:01 +13:00

safemode.h

rpc: Push down safe mode checks

2017-08-29 10:09:41 +02:00

server.cpp

Add username and ip logging for RPC method requests

2018-03-25 18:25:09 +00:00

server.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

util.cpp

Merge #12542: Remove redundant includes. Conform to header include guidelines.

2018-03-16 16:59:27 -07:00

util.h

Remove redundant includes. Conform to header include guidelines.

2018-02-27 22:30:40 +01:00