Andrew Chow b0c8306349 Merge bitcoin/bitcoin#24649: wallet: do not count wallet utxos as external ...

7832e9438f test: fundrawtransaction preset input weight calculation (S3RK)
c3981e379f wallet: do not count wallet utxos as external (S3RK)

Pull request description:

  Correctly differentiating between external vs non-external utxos in coin control produces more accurate weight and fee estimations.

  Weight for external utxos is estimated based on the maximum signature size, while for the wallet utxos we expect minimal signature due to signature grinding.

ACKs for top commit:
  achow101:
    re-ACK 7832e9438f
  Xekyo:
    re-ACK 7832e9438f
  furszy:
    ACK 7832e943

Tree-SHA512: bb5635b0bd85fa9a76922a53ad3fa062286424c06a695a0e87407c665713e80a33555b644fbb13bcc1ab503dcd7f53aacbdc368d69ac0ecff8005603623ac94f

2022-06-16 14:11:19 -04:00

..

rpc

Merge bitcoin/bitcoin#24649: wallet: do not count wallet utxos as external

2022-06-16 14:11:19 -04:00

test

fuzz: coinselection, add missing fee rate.

2022-05-25 14:07:33 -03:00

bdb.cpp

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

logging: Unconditionally log levels >= WARN

2022-05-25 11:26:15 +02:00

coinselection.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

wallet: CreateTransaction(): return out-params as (optional) struct

2022-05-16 17:46:34 +02:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

2022-05-18 16:23:43 +02:00

ismine.h

…

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

…

receive.cpp

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

receive.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

…

scriptpubkeyman.h

…

spend.cpp

Merge bitcoin/bitcoin#24649: wallet: do not count wallet utxos as external

2022-06-16 14:11:19 -04:00

spend.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

…

transaction.cpp

…

transaction.h

…

wallet.cpp

Merge bitcoin/bitcoin#24931: Strengthen thread safety assertions

2022-06-10 16:42:53 +02:00

wallet.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

walletdb.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…