mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-20 15:19:07 +01:00
25c45bb0d0
07a926474bnode: change a tx-relay on/off flag to enum (Vasil Dimov) Pull request description: Previously the `bool relay` argument to `BroadcastTransaction()` designated: ``` relay=true: add to the mempool and broadcast to all peers relay=false: add to the mempool ``` Change this to an `enum`, so it is more readable and easier to extend with a 3rd option. Consider these example call sites: ```cpp Paint(true); // Or Paint(/*is_red=*/true); ``` vs ```cpp Paint(RED); ``` The idea for putting `TxBroadcastMethod` into `node/types.h` by Ryan. --- This is part of [#29415 Broadcast own transactions only via short-lived Tor or I2P connections](https://github.com/bitcoin/bitcoin/pull/29415). Putting it in its own PR to reduce the size of #29415 and because it does not logically depend on the other commits from there. ACKs for top commit: optout21: ACK07a926474bkevkevinpal: ACK [07a9264](07a926474b) laanwj: Concept and code review ACK07a926474b. Agree with the general reasoning and the change in #29415 is a valid motivation to change this interface. glozow: utACK07a926474bTree-SHA512: ec8f6fa56a6d2422a0fbd5941ff2792685e8d8e7b9dd50bba9f3e21ed9b4a4a26c89b0d7e4895d48f30b7a635f2eddd894af26b5266410952cbdaf5c40b42966
77 lines
3.4 KiB
C++
77 lines
3.4 KiB
C++
// Copyright (c) 2017-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_NODE_TRANSACTION_H
|
|
#define BITCOIN_NODE_TRANSACTION_H
|
|
|
|
#include <common/messages.h>
|
|
#include <node/types.h>
|
|
#include <policy/feerate.h>
|
|
#include <primitives/transaction.h>
|
|
|
|
class CBlockIndex;
|
|
class CTxMemPool;
|
|
namespace Consensus {
|
|
struct Params;
|
|
}
|
|
|
|
namespace node {
|
|
class BlockManager;
|
|
struct NodeContext;
|
|
|
|
/** Maximum fee rate for sendrawtransaction and testmempoolaccept RPC calls.
|
|
* Also used by the GUI when broadcasting a completed PSBT.
|
|
* By default, a transaction with a fee rate higher than this will be rejected
|
|
* by these RPCs and the GUI. This can be overridden with the maxfeerate argument.
|
|
*/
|
|
static const CFeeRate DEFAULT_MAX_RAW_TX_FEE_RATE{COIN / 10};
|
|
|
|
/** Maximum burn value for sendrawtransaction, submitpackage, and testmempoolaccept RPC calls.
|
|
* By default, a transaction with a burn value higher than this will be rejected
|
|
* by these RPCs and the GUI. This can be overridden with the maxburnamount argument.
|
|
*/
|
|
static const CAmount DEFAULT_MAX_BURN_AMOUNT{0};
|
|
|
|
/**
|
|
* Submit a transaction to the mempool and (optionally) relay it to all P2P peers.
|
|
*
|
|
* Mempool submission can be synchronous (will await mempool entry notification
|
|
* over the CValidationInterface) or asynchronous (will submit and not wait for
|
|
* notification), depending on the value of wait_callback. wait_callback MUST
|
|
* NOT be set while cs_main, cs_mempool or cs_wallet are held to avoid
|
|
* deadlock.
|
|
*
|
|
* @param[in] node reference to node context
|
|
* @param[in] tx the transaction to broadcast
|
|
* @param[out] err_string reference to std::string to fill with error string if available
|
|
* @param[in] max_tx_fee reject txs with fees higher than this (if 0, accept any fee)
|
|
* @param[in] broadcast_method whether to add the transaction to the mempool and how to broadcast it
|
|
* @param[in] wait_callback wait until callbacks have been processed to avoid stale result due to a sequentially RPC.
|
|
* return error
|
|
*/
|
|
[[nodiscard]] TransactionError BroadcastTransaction(NodeContext& node,
|
|
CTransactionRef tx,
|
|
std::string& err_string,
|
|
const CAmount& max_tx_fee,
|
|
TxBroadcast broadcast_method,
|
|
bool wait_callback);
|
|
|
|
/**
|
|
* Return transaction with a given hash.
|
|
* If mempool is provided and block_index is not provided, check it first for the tx.
|
|
* If -txindex is available, check it next for the tx.
|
|
* Finally, if block_index is provided, check for tx by reading entire block from disk.
|
|
*
|
|
* @param[in] block_index The block to read from disk, or nullptr
|
|
* @param[in] mempool If provided, check mempool for tx
|
|
* @param[in] hash The txid
|
|
* @param[in] blockman Used to access and read blocks from disk
|
|
* @param[out] hashBlock The block hash, if the tx was found via -txindex or block_index
|
|
* @returns The tx if found, otherwise nullptr
|
|
*/
|
|
CTransactionRef GetTransaction(const CBlockIndex* const block_index, const CTxMemPool* const mempool, const Txid& hash, const BlockManager& blockman, uint256& hashBlock);
|
|
} // namespace node
|
|
|
|
#endif // BITCOIN_NODE_TRANSACTION_H
|