furszy 87d1691f3e wallet: feebumper, fix crash when combined bump fee is unavailable ...

When a large cluster of unconfirmed transactions exceeds the limit,
calculateCombinedBumpFee() returns std::nullopt.

Previously, we continued executing and the optional value was
accessed unconditionally, leading to a std::bad_optional_access
exception.

Fix this by returning early when the returned bumped fee is null.

Note:
This is a crash for the GUI, and an uncaught exception for the RPC
bumpfee and psbtbumpfee.

Github-Pull: #34870
Rebased-From: 6072a2a6a1

2026-03-24 10:26:04 +08:00

..

bench

Merge bitcoin/bitcoin#34037: wallet, doc: clarify the coin selection filters that enforce cluster count

2026-03-09 10:11:08 +00:00

common

Merge bitcoin/bitcoin#34093: netif: fix compilation warning in QueryDefaultGatewayImpl()

2026-02-27 11:59:03 +00:00

compat

refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning

2026-02-18 21:29:07 +01:00

consensus

consensus/doc: explain GetValueOut() precondition

2026-02-02 19:32:14 +01:00

crc32c

…

crypto

iwyu: Add temporary mapping to work around upstream bug

2026-01-30 11:50:17 +00:00

index

index: document TxoSpenderIndex::FindSpender

2026-03-06 01:05:52 +01:00

init

log: Print warning about privacy-sensitive log info unconditionally

2026-01-27 13:08:50 +01:00

interfaces

Merge bitcoin/bitcoin#34642: wallet: call SyncWithValidationInterfaceQueue after disconnecting chain notifications

2026-03-02 22:00:53 +01:00

ipc

Merge bitcoin/bitcoin#34422: Update libmultiprocess subtree to be more stable with rust IPC client

2026-03-03 17:03:56 +00:00

kernel

kernel: acquire coinstats cursor and block info atomically

2026-03-19 16:49:49 +08:00

leveldb

Bump leveldb subtree

2026-02-03 11:19:01 +01:00

logging

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

minisketch

…

node

Merge bitcoin/bitcoin#34696: Update embedded asmap to 1772726400 for v31

2026-03-10 15:55:36 -07:00

policy

Merge bitcoin/bitcoin#33616: policy: don't CheckEphemeralSpends on reorg

2026-02-25 17:38:13 +01:00

primitives

txgraph: pass fallback_order to TxGraph (preparation)

2026-02-09 15:55:58 -05:00

qt

gui: Fix TransactionsView on setCurrentWallet

2026-03-23 07:32:14 +08:00

rpc

rpc: fix race condition in gettxoutsetinfo

2026-03-19 16:49:29 +08:00

script

Merge bitcoin/bitcoin#34700: script: Fix undefined behavior in Clone() -- std::transform writes past end of empty vector

2026-03-08 14:23:49 +00:00

secp256k1

Update secp256k1 subtree to latest master

2026-02-02 15:21:14 +00:00

support

kernel: avoid potential duplicate object in shared library/binary

2026-02-13 08:50:50 +01:00

test

Merge bitcoin/bitcoin#34705: kernel: Use fs:: namespace and unicode path in kernel tests

2026-03-09 12:24:54 +00:00

univalue

ci, iwyu: Fix warnings in src/univalue and treat them as errors

2026-01-31 10:41:50 +00:00

util

Merge bitcoin/bitcoin#34471: refactor: Use aliasing shared_ptr in Sock::Wait

2026-03-09 10:54:47 +00:00

wallet

wallet: feebumper, fix crash when combined bump fee is unavailable

2026-03-24 10:26:04 +08:00

zmq

ci, iwyu: Fix warnings in src/zmq and treat them as errors

2026-01-29 14:38:35 +00:00

.clang-format

ci, iwyu: Fix warnings in src/zmq and treat them as errors

2026-01-29 14:38:35 +00:00

.clang-tidy

doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false

2026-02-06 08:37:19 +01:00

addrdb.cpp

…

addrdb.h

…

addresstype.cpp

…

addresstype.h

…

addrman_impl.h

…

addrman.cpp

…

addrman.h

…

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

wallet, rpc:remove settxfee and paytxfee

2026-02-13 10:52:25 +01:00

bitcoin-res.rc

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

…

bitcoin-util-res.rc

…

bitcoin-util.cpp

…

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoin.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

…

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

validation: remove BLOCK_FAILED_MASK

2026-02-17 21:40:46 +05:30

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

contrib: Update fixed feeds

2026-02-25 14:36:19 -08:00

checkqueue.h

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

clientversion.cpp

…

clientversion.h

…

cluster_linearize.h

clusterlin: update SFL comments for deterministic order

2026-03-10 14:09:27 -04:00

CMakeLists.txt

Merge bitcoin/bitcoin#24539: Add a "tx output spender" index

2026-02-20 09:27:17 +01:00

coins.cpp

util: introduce TrySub to prevent unsigned underflow

2026-02-23 15:56:25 +01:00

coins.h

util: introduce TrySub to prevent unsigned underflow

2026-02-23 15:56:25 +01:00

compressor.cpp

…

compressor.h

…

core_io.cpp

Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)

2026-02-09 13:32:28 +00:00

core_io.h

…

core_memusage.h

…

cuckoocache.h

…

dbwrapper.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

dbwrapper.h

refactor: Use SpanReader over DataStream

2026-02-02 18:42:44 +01:00

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

wallet, rpc:remove settxfee and paytxfee

2026-02-13 10:52:25 +01:00

external_signer.cpp

util: Remove brittle and confusing sp::Popen(std::string)

2026-02-17 12:55:26 +01:00

external_signer.h

util: Remove brittle and confusing sp::Popen(std::string)

2026-02-17 12:55:26 +01:00

flatfile.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

flatfile.h

…

hash.cpp

…

hash.h

…

headerssync.cpp

…

headerssync.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race

2026-02-19 12:41:12 -08:00

httpserver.h

http: replace WorkQueue and threads handling for ThreadPool

2026-01-30 16:17:12 -05:00

i2p.cpp

…

i2p.h

…

indirectmap.h

…

init.cpp

Merge bitcoin/bitcoin#34692: Bump dbcache to 1 GiB

2026-03-06 12:07:41 -08:00

init.h

…

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

logging.cpp

logging: Move message formatting to util/log.h

2026-02-02 17:22:31 +00:00

logging.h

logging: Move message formatting to util/log.h

2026-02-02 17:22:31 +00:00

mapport.cpp

…

mapport.h

…

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

musig.cpp

…

musig.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

Merge bitcoin/bitcoin#34054: net processing: Add ibd check before processing block for txdownloadman

2026-02-26 10:33:29 +00:00

net_processing.h

rpc: Add abortprivatebroadcast

2026-02-11 19:46:19 -05:00

net_types.cpp

…

net_types.h

…

net.cpp

Merge bitcoin/bitcoin#34410: test: let connections happen in any order in p2p_private_broadcast.py

2026-03-02 07:47:53 -08:00

net.h

Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in tests

2026-02-13 11:17:26 +00:00

netaddress.cpp

…

netaddress.h

…

netbase.cpp

…

netbase.h

…

netgroup.cpp

…

netgroup.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

…

private_broadcast.cpp

net: Add PrivateBroadcast::GetBroadcastInfo

2026-02-11 19:46:12 -05:00

private_broadcast.h

net: Add PrivateBroadcast::GetBroadcastInfo

2026-02-11 19:46:12 -05:00

protocol.cpp

…

protocol.h

…

psbt.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

psbt.h

Merge bitcoin/bitcoin#34219: psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization

2026-03-04 15:17:02 +00:00

pubkey.cpp

…

pubkey.h

…

random.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

random.h

…

randomenv.cpp

…

randomenv.h

…

rest.cpp

Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)

2026-02-09 13:32:28 +00:00

rest.h

…

scheduler.cpp

…

scheduler.h

…

semaphore_grant.h

…

serialize.h

refactor: Use empty() over eof() in the streams interface

2026-02-02 17:55:10 +01:00

signet.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

signet.h

…

span.h

…

streams.cpp

…

streams.h

Merge bitcoin/bitcoin#34465: refactor: separate log generation from log handling

2026-02-07 23:01:17 +01:00

sync.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

sync.h

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

threadsafety.h

…

tinyformat.h

…

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

validation: Use dirty entry count in flush warnings and disk space checks

2026-02-08 08:23:37 +01:00

txdb.h

…

txgraph.cpp

clusterlin: use 'cost' terminology instead of 'iters' (refactor)

2026-02-24 10:08:47 -05:00

txgraph.h

clusterlin: use 'cost' terminology instead of 'iters' (refactor)

2026-02-24 10:08:47 -05:00

txmempool.cpp

clusterlin: use 'cost' terminology instead of 'iters' (refactor)

2026-02-24 10:08:47 -05:00

txmempool.h

clusterlin: rescale costs (preparation)

2026-02-24 10:45:49 -05:00

txrequest.cpp

…

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Merge bitcoin/bitcoin#34521: validation: fix UB in LoadChainTip

2026-03-06 08:22:42 -08:00

validation.h

Merge bitcoin/bitcoin#34521: validation: fix UB in LoadChainTip

2026-03-06 08:22:42 -08:00

validationinterface.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

validationinterface.h

…

versionbits_impl.h

…

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

…