bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 23:03:45 +01:00

Files

Wladimir J. van der Laan de5af41e35 Merge #15452 : Replace CScriptID and CKeyID in CTxDestination with dedicated types

78e407ad0c GetKeyBirthTimes should return key ids, not destinations (Gregory Sanders)
70946e7fee Replace CScriptID and CKeyID in CTxDestination with dedicated types (Gregory Sanders)

Pull request description:

  The current usage seems to be an overloading of meanings. `CScriptID` is used in the wallet as a lookup key, as well as a destination, and `CKeyID` likewise. Instead, have all destinations be dedicated types.

  New types:
  `CScriptID`->`ScriptHash`
  `CKeyID`->`PKHash`

ACKs for commit 78e407:
  ryanofsky:
    utACK 78e407ad0c. Only changes are removing extra CScriptID()s and fixing the test case.
  Sjors:
    utACK 78e407a
  meshcollider:
    utACK 78e407ad0c

Tree-SHA512: 437f59fc3afb83a40540da3351507aef5aed44e3a7f15b01ddad6226854edeee762ff0b0ef336fe3654c4cd99a205cef175211de8b639abe1130c8a6313337b9

2019-05-09 18:54:43 +02:00

coinselector_tests.cpp

wallet: add cachable amounts for caching credit/debit values

2019-04-23 08:18:58 +09:00

db_tests.cpp

scripted-diff: Rename test_bitcoin to test/setup_common

2019-04-11 10:12:36 -04:00

init_test_fixture.cpp

Remove direct node->wallet calls in init.cpp

2018-11-06 11:44:40 -04:00

init_test_fixture.h

scripted-diff: Rename test_bitcoin to test/setup_common