highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-21 14:22:38 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Jonas Schnelli 8ad5f1c376
Merge #19106: util: simplify the interface of serviceFlagToStr() 
189ae0c38b7d4927c5c73b94664e9542b2b06ed9 util: dedup code in callers of serviceFlagToStr() (Vasil Dimov)
fbacad1880341ace31f669530c66d4e322d19235 util: simplify the interface of serviceFlagToStr() (Vasil Dimov)

Pull request description:

  Don't take two redundant arguments in `serviceFlagToStr()`.

  Introduce `serviceFlagsToStr()` which takes a mask (with more than one
  bit set) and returns a vector of strings.

  As a side effect this fixes an issue introduced in
  https://github.com/bitcoin/bitcoin/pull/18165 due to which the GUI could
  print something like `UNKNOWN[1033] & UNKNOWN[1033] & UNKNOWN[2^10]`
  instead of `NETWORK & WITNESS`.

ACKs for top commit:
  MarcoFalke:
    ACK 189ae0c38b7d4927c5c73b94664e9542b2b06ed9
  jonasschnelli:
    Tested ACK 189ae0c38b7d4927c5c73b94664e9542b2b06ed9

Tree-SHA512: 000c490f16ebbba04458c62ca4ce743abffd344d375d95f5bbd5008742012032787655db2874b168df0270743266261dccf1693761906567502dcbac902bda50
2020-05-29 19:43:08 +02:00
..
bench
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
compat
net: Use C++11 member initialization in protocol
2020-05-20 08:27:07 -04:00
config
…
consensus
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
crc32c
…
crypto
Avoid non-trivial global constants in SHA-NI code
2020-04-07 13:57:34 -07:00
index
[doc] Add comment for m_headers_cache
2020-05-22 11:59:58 -04:00
interfaces
Merge #18452: qt: Fix shutdown when waitfor* cmds are called from RPC console
2020-05-29 15:49:46 +02:00
leveldb
…
logging
Remove use of non-standard zero variadic macros
2020-04-30 18:02:04 +08:00
node
Merge #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible
2020-05-26 07:33:43 -04:00
policy
Convert everything except wallet/qt to new serialization
2020-03-30 16:10:30 -07:00
primitives
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
qt
util: dedup code in callers of serviceFlagToStr()
2020-05-29 18:59:37 +02:00
rpc
Merge #19106: util: simplify the interface of serviceFlagToStr()
2020-05-29 19:43:08 +02:00
script
Merge #19004: refactor: Replace const char* to std::string
2020-05-27 07:16:10 -04:00
secp256k1
…
support
Merge #18443: lockedpool: avoid sensitive data in core files (FreeBSD)
2020-05-04 16:31:07 +02:00
test
Merge #16127: More thread safety annotation coverage
2020-05-27 19:31:33 -04:00
univalue
…
util
Merge #16127: More thread safety annotation coverage
2020-05-27 19:31:33 -04:00
wallet
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
zmq
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
Merge #18512: Improve asmap checks and add sanity check
2020-05-06 14:59:28 +02:00
addrman.h
…
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #19004: refactor: Replace const char* to std::string
2020-05-27 07:16:10 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
wallettool: Add a salvage command
2020-05-25 12:36:48 -04:00
bitcoind-res.rc
…
bitcoind.cpp
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
blockencodings.cpp
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-04-20 14:57:48 +00:00
blockfilter.h
…
bloom.cpp
net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix
2020-04-28 19:27:22 +02:00
bloom.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
chain.cpp
…
chain.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparams.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparams.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
net: Hardcoded seeds update for 0.20
2020-04-03 16:29:26 +02:00
checkqueue.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
clientversion.cpp
Drop unused GIT_COMMIT_DATE macro
2020-05-04 19:53:58 +03:00
clientversion.h
…
coins.cpp
Remove CCoinsViewCache::GetValueIn(...)
2020-05-03 18:42:14 +00:00
coins.h
Merge #18854: doc: Fix typo in Coin doxygen comment
2020-05-06 13:15:28 +02:00
compat.h
…
compressor.cpp
…
compressor.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
core_io.h
…
core_memusage.h
…
core_read.cpp
refactor: Replace const char* to std::string
2020-05-22 01:40:31 +09:00
core_write.cpp
…
cuckoocache.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
2020-04-08 14:45:27 +00:00
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
wallet: Avoid translating RPC errors when loading wallets
2020-05-01 07:39:00 -04:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Fix WSL file locking by using flock instead of fcntl
2020-04-26 12:16:22 +12:00
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
Merge #18740: Remove g_rpc_node global
2020-05-21 06:53:39 -04:00
httprpc.h
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
httpserver.cpp
http: Avoid crash when g_thread_http was never started
2020-05-19 10:41:44 -04:00
httpserver.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
indirectmap.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
validation: Make LoadBlockIndex() a member of ChainstateManager
2020-05-21 09:55:59 -04:00
init.h
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
limitedmap.h
…
logging.cpp
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
logging.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
Makefile.am
Merge #18918: wallet: Move salvagewallet into wallettool
2020-05-27 14:51:49 +12:00
Makefile.bench.include
bench: add CAddrMan benchmarks
2020-04-21 15:06:59 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
qt: Translations update pre-branch
2020-04-01 12:49:15 +02:00
Makefile.qt.include
build: multiprocess autotools changes
2020-05-12 09:47:06 -04:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.test_util.include
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
Makefile.test.include
tests: Add fuzzing harness for CCoinsViewCache
2020-05-25 10:05:06 +00:00
memusage.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
merkleblock.cpp
Convert merkleblock to new serialization
2020-03-30 16:09:51 -07:00
merkleblock.h
Convert merkleblock to new serialization
2020-03-30 16:09:51 -07:00
miner.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
miner.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
net_permissions.cpp
…
net_permissions.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
net_processing.cpp
Merge #19010: net processing: Add support for getcfheaders
2020-05-26 07:27:00 -04:00
net_processing.h
net: Pass chainman into PeerLogicValidation
2020-05-21 09:55:58 -04:00
net_types.h
…
net.cpp
Merge #16939: p2p: Delay querying DNS seeds
2020-05-29 18:24:09 +08:00
net.h
Merge #16127: More thread safety annotation coverage
2020-05-27 19:31:33 -04:00
netaddress.cpp
Merge #18512: Improve asmap checks and add sanity check
2020-05-06 14:59:28 +02:00
netaddress.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
noui.h
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
optional.h
…
outputtype.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
prevector: Avoid unnamed struct, which is a GNU extension
2020-04-30 18:02:03 +08:00
protocol.cpp
util: dedup code in callers of serviceFlagToStr()
2020-05-29 18:59:37 +02:00
protocol.h
util: dedup code in callers of serviceFlagToStr()
2020-05-29 18:59:37 +02:00
psbt.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
psbt.h
Merge #17509: gui: save and load PSBT
2020-04-23 13:16:23 +12:00
pubkey.cpp
…
pubkey.h
Implement TopUp in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
random.cpp
Merge #18781: Add templated GetRandDuration<>
2020-05-15 08:58:49 -04:00
random.h
Add templated GetRandomDuration<>
2020-04-30 09:19:14 -04:00
randomenv.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
randomenv.h
…
rest.cpp
Merge #18740: Remove g_rpc_node global
2020-05-21 06:53:39 -04:00
reverse_iterator.h
…
scheduler.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
scheduler.h
…
serialize.h
Remove old serialization primitives
2020-05-24 10:35:00 -07:00
shutdown.cpp
…
shutdown.h
…
span.h
Merge #18591: Add C++17 build to Travis
2020-04-30 11:16:56 +02:00
streams.h
…
sync.cpp
Use template function instead of void* parameter
2020-05-28 09:55:04 +03:00
sync.h
Use template function instead of void* parameter
2020-05-28 09:55:04 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
timedata.cpp
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
txdb.h
…
txmempool.cpp
Merge #18038: P2P: Mempool tracks locally submitted transactions to improve wallet privacy
2020-04-29 16:32:37 +08:00
txmempool.h
[mempool] sanity check that all unbroadcast txns are in mempool
2020-05-19 14:23:19 -07:00
ui_interface.cpp
refactor: Pass SynchronizationState enum to GUI
2020-05-19 02:49:32 +03:00
ui_interface.h
refactor: Pass SynchronizationState enum to GUI
2020-05-19 02:49:32 +03:00
uint256.cpp
…
uint256.h
…
undo.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
validation.cpp
validation: Make ProcessNewBlock*() members of ChainstateManager
2020-05-21 09:56:16 -04:00
validation.h
validation: Mark g_chainman DEPRECATED
2020-05-21 09:56:25 -04:00
validationinterface.cpp
validationinterface: Rework documentation, Rename pwalletIn to callbacks
2020-05-13 19:57:55 -04:00
validationinterface.h
validationinterface: Rework documentation, Rename pwalletIn to callbacks
2020-05-13 19:57:55 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…