Andrew Chow 19a7e608f9 Merge bitcoin/bitcoin#28505: rpc: bumpfee, improve doc for 'reduce_output' arg ...

b3db8c9d5c rpc: bumpfee, improve doc for 'reduce_output' arg (furszy)

Pull request description:

  Fixes #28180. Resulted from discussions with S3RK, achow101, and Murch.

  The current argument name and description are dangerous as it don't
  describe the case where the user selects the recipient output as the
  change address. This one could end up been increased by the inputs
  minus outputs remainder. Which, when `bumpfee` adds new inputs
  to the transaction, leads the process to send more coins to the
  recipient. Which is not what the user would expect from a
  'reduce_output' param naming.

ACKs for top commit:
  S3RK:
    ACK b3db8c9d5c
  achow101:
    ACK b3db8c9d5c
  murchandamus:
    ACK b3db8c9d5c

Tree-SHA512: 91f607e2f5849041d7c099afdddae11af8bed5b1ac90c9d22921267f272e21b44e107d6968e037f05f958a61fe29e94e5fb44b224fb3606f197f83ec4ba3b1e7

2023-09-27 16:46:27 -04:00

..

rpc

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

test

Merge bitcoin/bitcoin#28246: wallet: Use CTxDestination in CRecipient instead of just scriptPubKey

2023-09-19 16:48:43 +00:00

bdb.cpp

…

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

Merge bitcoin-core/gui#119: Replace send-to-self with dual send+receive entries

2023-09-22 18:29:51 +01:00

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#28125: wallet: bugfix, disallow migration of invalid scripts

2023-09-19 13:10:57 -04:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#28125: wallet: bugfix, disallow migration of invalid scripts

2023-09-19 13:10:57 -04:00

spend.cpp

Merge bitcoin/bitcoin#28246: wallet: Use CTxDestination in CRecipient instead of just scriptPubKey

2023-09-19 16:48:43 +00:00

spend.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

sqlite.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

sqlite.h

…

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

Merge bitcoin-core/gui#738: Add menu option to migrate a wallet

2023-09-20 22:32:31 +01:00

wallet.h

Merge bitcoin-core/gui#738: Add menu option to migrate a wallet

2023-09-20 22:32:31 +01:00

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…