merge-script 2a1234001c Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet ...

75b704df9d wallettool: Disallow creating new unnamed wallets (Ava Chow)
5875a9c502 wallet: disallow unnamed wallets in createwallet and restorewallet (Ava Chow)
d30ad4a912 wallet, rpc: Use HandleWalletError in createwallet (Ava Chow)

Pull request description:

  We've been moving in the direction that all wallets must have a name. Therefore, we shouldn't allow creating new unnamed wallets. `createwallet`, `restorewallet`, and the wallet tool's `create` and `createfromdump` all now require the user to provide a non-empty wallet name when creating/restoring a wallet.

  The GUI is already enforcing this, but we were not enforcing it for RPCs or in the underlying `CreateWallet` and `RestoreWallet` functions.

  Wallet migration does still need to be able to restore unnamed wallets, so there is a new argument to `RestoreWallet` to explicitly allow that behavior for migration only.

ACKs for top commit:
  rkrux:
    lgtm ACK 75b704df9d
  polespinasa:
    re ACK 75b704df9d

Tree-SHA512: 8bde76d0b091e9276788c69412934af3426da2a7a69a00f94072d36c1a075cd41744ecdd5fef2b72870c1351b76aae061f124f716bb23f4839be20c464fc5ebd

2026-01-21 22:56:59 +01:00

..

rpc

Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet

2026-01-21 22:56:59 +01:00

test

Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods

2026-01-21 13:23:43 +01:00

CMakeLists.txt

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

db.cpp

…

db.h

wallet: disallow unnamed wallets in createwallet and restorewallet

2026-01-19 10:55:55 -08:00

dump.cpp

wallettool: Disallow creating new unnamed wallets

2026-01-19 10:57:13 -08:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

load.cpp

…

load.h

…

migrate.cpp

…

migrate.h

…

receive.cpp

…

receive.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#32471: wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key

2026-01-20 12:17:19 -08:00

scriptpubkeyman.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

spend.cpp

wallet: remove erroneous-on-reorg Assume()

2026-01-09 08:41:37 -05:00

spend.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet

2026-01-21 22:56:59 +01:00

wallet.h

Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet

2026-01-21 22:56:59 +01:00

walletdb.cpp

…

walletdb.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

wallettool.cpp

wallettool: Disallow creating new unnamed wallets

2026-01-19 10:57:13 -08:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…