mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-06 21:57:54 +02:00

Files

Ava Chow c97ac44c34 Merge bitcoin/bitcoin#32297 : bitcoin-cli: Add -ipcconnect option

4565cff72c bitcoin-gui: Implement missing Init::makeMining method (Ryan Ofsky)
fbea576c26 test: add interface_ipc_cli.py testing bitcoin-cli -ipcconnect (Ryan Ofsky)
0448a19b1b ipc: Improve -ipcconnect error checking (Ryan Ofsky)
8d614bfa47 bitcoin-cli: Add -ipcconnect option (Ryan Ofsky)
6a54834895 ipc: Expose an RPC interface over the -ipcbind socket (Ryan Ofsky)
df76891a3b refactor: Add ExecuteHTTPRPC function (Ryan Ofsky)
3cd1cd3ad3 ipc: Add MakeBasicInit function (Ryan Ofsky)

Pull request description:

  This implements an idea from sipa in https://github.com/bitcoin/bitcoin/issues/28722#issuecomment-2807026958 to allow `bitcoin-cli` to connect to the node via IPC instead of TCP, if the ENABLE_IPC cmake option is enabled and the node has been started with `-ipcbind`.

  This feature can be tested with:

  ```
  build/bin/bitcoin-node -regtest -ipcbind=unix -debug=ipc
  build/bin/bitcoin-cli -regtest -ipcconnect=unix -getinfo
  ```

  The -ipconnect parameter can also be omitted, since this change also makes `bitcoin-cli` prefer IPC over HTTP by default, and falling back to HTTP if an IPC connection can't be established.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/issues/28722).

ACKs for top commit:
  achow101:
    ACK 4565cff72c
  pinheadmz:
    ACK 4565cff72c
  enirox001:
    Tested ACK 4565cff72c

Tree-SHA512: cb0dc521d82591e4eb2723a37ae60949309a206265e0ccfbee1f4d59b426b770426fafa1e842819a2fa27322ecdfcd226f31da70f91c2c31b8095e1380666f1f

2026-03-30 15:12:04 -07:00

chain.h

interfaces: Add waitForNotifications() to call SyncWithValidationInterfaceQueue()

2026-02-27 12:16:35 -08:00

echo.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

handler.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

init.h

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

ipc.h

bitcoin-cli: Add -ipcconnect option

2026-02-27 19:26:08 -04:00

mining.h

ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup

2026-02-24 10:15:14 -05:00

node.h

refactor: Return std::optional from GetProxy

2026-03-10 21:15:19 +01:00

README.md

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

rpc.h

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

types.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

wallet.h

refactor: interfaces, make 'createTransaction' less error-prone

2026-02-06 18:15:59 -05:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.
Rpc — used by bitcoin-cli to be able to call RPC methods over a unix socket instead of TCP.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.