Wladimir J. van der Laan 8d1286014c Merge #16237: Have the wallet give out destinations instead of keys ...

8e7f930828 Add GetNewChangeDestination for getting new change Destinations (Andrew Chow)
33d13edd2b Replace CReserveKey with ReserveDestinatoin (Andrew Chow)
172213be5b Add GetNewDestination to CWallet to fetch new destinations (Andrew Chow)

Pull request description:

  The wallet should give out destinations instead of keys. It should be the one that handles the conversion from key to destination and the setting of the label, not the caller. In order to do this, two new member functions are introduced `GetNewDestination()` and `GetNewChangeDestination()`. Additionally, `CReserveKey` is changed to be `ReserveDestination` and represents destinations whose keys can be returned to the keypool.

ACKs for top commit:
  instagibbs:
    re-utACK 8e7f930828
  sipa:
    ACK 8e7f930828. Concept ACK as this gives a much cleaner abstraction to work with, and light code review ACK.
  laanwj:
    ACK 8e7f930828

Tree-SHA512: 5be7051409232b71e0ef2c1fd1a3e76964ed2f5b14d47d06edc2ad3b3687abd0be2803a1adc45c0433aa2c3bed172e14f8a7e9f4a23bff70f86260b5a0497500

2019-07-10 11:45:55 +02:00

..

coinselector_tests.cpp

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

db_tests.cpp

test: Create data dir in BasicTestingSetup

2019-06-20 09:31:02 -04:00

init_test_fixture.cpp

tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests

2019-06-26 20:37:48 +02:00

init_test_fixture.h

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

init_tests.cpp

tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests

2019-06-26 20:37:48 +02:00

ismine_tests.cpp

tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests

2019-06-26 20:37:48 +02:00

psbt_wallet_tests.cpp

tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests

2019-06-26 20:37:48 +02:00

wallet_crypto_tests.cpp

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

wallet_test_fixture.cpp

tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests

2019-06-26 20:37:48 +02:00

wallet_test_fixture.h

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

wallet_tests.cpp

Merge #16237: Have the wallet give out destinations instead of keys

2019-07-10 11:45:55 +02:00