highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-24 23:52:00 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Andrew Chow 8d6f9210d9
Merge bitcoin/bitcoin#24401: wallet: Add external-signer-support specific error message 
7f3a6a9495fafbf77f221297615fa56dc3ecc64a wallet: Add external-signer-support specific error message (Hennadii Stepanov)

Pull request description:

  On master (5f44c5c428b696af4214b2519cb2bbeb0e4a1027) an attempt to load an external signer wallet using Bitcoin Core compiled without external signer support fails with the following log messages:
  ```
  2022-02-20T19:01:11Z [qt-walletctrl] Using SQLite Version 3.31.1
  2022-02-20T19:01:11Z [qt-walletctrl] Using wallet /home/hebasto/.bitcoin/testnet3/wallets/coldcard-0220
  2022-02-20T19:01:11Z [qt-walletctrl] init message: Loading wallet…
  2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Error: External signer wallet being loaded without external signer support compiled
  2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Releasing wallet
  ```

  While log messages are good, a message in the GUI window is completely misleading:

  ![Screenshot from 2022-02-20 20-43-46](https://user-images.githubusercontent.com/32963518/154859854-b87032e0-c428-4e11-8009-39e38200482c.png)

  This PR fixes this issue:

  ![Screenshot from 2022-02-20 21-01-18](https://user-images.githubusercontent.com/32963518/154859868-e3a2c89d-4f0f-424e-96cb-7accaa48acc0.png)

ACKs for top commit:
  achow101:
    ACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a
  kristapsk:
    ACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a
  brunoerg:
    crACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a

Tree-SHA512: a4842751c0ca8a37ccc3ea00503678f6b712a7f53d6cbdc07ce02dcb85ca8a94890d1c2da20307be043faa347747abeba29185c88ba12edd5253bfca56531585
2022-02-23 17:19:49 -05:00
..
bench
bench: Avoid deprecated use of volatile +=
2022-02-17 17:25:57 +01:00
common
refactor: Fixup uint64_t-cast style in touched line
2022-02-01 11:19:18 +01:00
compat
…
config
…
consensus
…
crc32c
…
crypto
doc: Fix typos
2022-02-17 03:42:08 +09:00
index
index: check muhash is in sync on coinstatsindex launch
2022-02-17 00:36:47 +01:00
init
…
interfaces
…
ipc
…
leveldb
…
logging
…
minisketch
Update minisketch subtree to latest upstream
2022-02-04 22:47:49 +08:00
node
doc: Fix typos
2022-02-17 03:42:08 +09:00
policy
Remove outdated comment on CFeeRate
2022-02-14 16:01:26 -05:00
primitives
Merge bitcoin/bitcoin#24350: Primitives: Correct CTransaction deserialization docstring
2022-02-19 09:35:10 +01:00
qt
qt: Update translation source file
2022-02-22 14:12:20 +02:00
rpc
Merge bitcoin/bitcoin#24367: User-facing content and codebase doc fixups from transifex translator feedback
2022-02-22 13:08:08 +01:00
script
Bugfix: make ToPrivateString work with x-only keys
2022-02-15 11:57:25 -05:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#24381: test: Run symlink regression tests on Windows
2022-02-23 15:48:55 +01:00
univalue
…
util
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
wallet
Merge bitcoin/bitcoin#24401: wallet: Add external-signer-support specific error message
2022-02-23 17:19:49 -05:00
zmq
zmq: Fix implicit-integer-sign-change
2022-01-31 16:53:12 +01:00
.clang-format
…
.clang-tidy
…
addrdb.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
addrdb.h
…
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Fix race condition for SetBannedSetDirty() calls
2022-01-28 19:27:25 +00:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Output license info when binaries are passed -version
2022-02-22 15:36:19 +00:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Output license info when binaries are passed -version
2022-02-22 15:36:19 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Output license info when binaries are passed -version
2022-02-22 15:36:19 +00:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Output license info when binaries are passed -version
2022-02-22 15:36:19 +00:00
bitcoind-res.rc
…
bitcoind.cpp
Output license info when binaries are passed -version
2022-02-22 15:36:19 +00:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
Merge bitcoin/bitcoin#24146: Avoid integer sanitizer warnings in chain.o
2022-01-31 09:23:54 +01:00
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
clientversion.h
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
coins.cpp
…
coins.h
…
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
refactor: Avoid unsigned integer overflow in core_write
2022-02-11 17:21:44 +01:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
fs.h
util: Work around libstdc++ create_directories issue
2022-02-17 12:30:11 +01:00
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
init.h
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
logging.h
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
Makefile.am
Merge bitcoin/bitcoin#24115: ARMv8 SHA2 Intrinsics
2022-02-14 21:12:39 +01:00
Makefile.bench.include
build: header-only Boost
2022-02-13 20:59:07 +00:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
build: header-only Boost
2022-02-13 20:59:07 +00:00
Makefile.qttest.include
build: header-only Boost
2022-02-13 20:59:07 +00:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
fuzz: Split script formatting from script fuzz target
2022-02-15 12:19:34 +01:00
Makefile.univalue.include
…
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
…
net_processing.h
…
net_types.cpp
…
net_types.h
…
net.cpp
Replace "can not" with "cannot" in docs, user messages, and tests
2022-02-21 19:07:29 +01:00
net.h
Merge bitcoin/bitcoin#23604: Use Sock in CNode
2022-02-04 09:24:17 +01:00
netaddress.cpp
…
netaddress.h
…
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
build: remove unneeded getentropy detection (HAVE_GETENTROPY)
2022-02-02 17:22:42 +01:00
random.h
doc: Fix typos pointed out by lint-spelling
2022-01-30 08:59:10 -03:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.h
scripted-diff: Rename nReadPos to m_read_pos in streams.h
2022-02-09 17:21:04 +01:00
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
Replace "can not" with "cannot" in docs, user messages, and tests
2022-02-21 19:07:29 +01:00
txdb.h
Replace lock with thread safety annotation in CBlockTreeDB::LoadBlockIndexGuts()
2022-01-28 20:52:53 +01:00
txmempool.cpp
…
txmempool.h
…
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#24367: User-facing content and codebase doc fixups from transifex translator feedback
2022-02-22 13:08:08 +01:00
validation.h
Merge bitcoin/bitcoin#24347: rpc: Fix implicit-integer-sign-change in verifychain
2022-02-21 07:52:57 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
trivial: comment tweaks
2022-01-28 18:07:08 +10:00
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…