bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-26 15:36:19 +01:00

Files

MarcoFalke 8ee5c7b747 Merge #12727 : [RPC] Remove unreachable help conditions in rpcwallet.cpp

e5468a19d1 Remove unreachable help conditions (lutangar)

Pull request description:

  These conditions on `request.fHelp`, which appears in the body of the following functions are never reached:
  * `walletpassphrase`
  * `walletpassphrasechange`
  * `encryptwallet`
  ```
  ...
      if (request.fHelp || request.params.size() != 0) {
          throw std::runtime_error("");
      }
  ...
      if (request.fHelp)
          return true;
  ...
  ```
  The first condition would throw if `request.fHelp` evaluates to `true`.

Tree-SHA512: 1aa41ed233c6bebae27151ab5cc67144d2a408335a3acef3c103e144d6343685f360b1146e14bc8dc1d53d00fcfc6ff1ab6a0eeb0805191172a23b306ab50b79

2018-03-19 16:49:55 -04:00

test

wallet: Change output type globals to members

2018-03-17 16:10:01 -04:00

coincontrol.h

wallet: Change output type globals to members

2018-03-17 16:10:01 -04:00

coinselection.cpp

Move current coin selection algorithm to coinselection.{cpp,h}

2018-03-13 12:39:26 -04:00

coinselection.h

Move current coin selection algorithm to coinselection.{cpp,h}