Ava Chow 9039d8f1a1 Merge bitcoin/bitcoin#31374: wallet: fix crash during watch-only wallet migration ...

cdd207c0e4 test: add coverage for migrating standalone imported keys (furszy)
297a876c98 test: add coverage for migrating watch-only script (furszy)
932cd1e92b wallet: fix crash during watch-only wallet migration (furszy)

Pull request description:

  The crash occurs because we assume the cached scripts structure will not be empty,
  but it can be empty for watch-only wallets that start blank.

  This also adds test coverage for standalone imported keys, which were also crashing
  because pubkey imports are treated the same way as hex script imports through
  `importaddress()`.

  Testing Notes:
  This can be verified by cherry-picking and running any of the test commits on master.
  It will crash there but pass on this branch.

ACKs for top commit:
  theStack:
    re-ACK cdd207c0e4
  brunoerg:
    reACK cdd207c0e4
  achow101:
    ACK cdd207c0e4

Tree-SHA512: e05c77cf3e9f35f10f122a73680b3f131f683c56685c1e26b5ffc857f95195b64c8c9d4535960ed3d6f931935aa79b0b1242537462006126bdb68251f0452954

2024-12-09 15:12:34 -05:00

..

rpc

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

test

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

bdb.cpp

scripted-diff: LogPrint -> LogDebug

2024-08-29 13:49:57 +02:00

bdb.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

CMakeLists.txt

cmake: Add systemtap-sdt optional package support

2024-08-16 19:27:41 +01:00

coincontrol.cpp

…

coincontrol.h

[wallet, rpc]: add max_tx_weight to tx funding options

2024-06-27 15:31:21 +01:00

coinselection.cpp

scripted-diff: LogPrint -> LogDebug

2024-08-29 13:49:57 +02:00

coinselection.h

Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2)

2024-07-17 18:27:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

crypter.h

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

db.cpp

Merge bitcoin/bitcoin#29071: refactor: Remove Span operator==, Use std::ranges::equal

2024-08-28 10:34:47 +01:00

db.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)

2024-12-04 15:09:05 -04:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

interfaces.cpp

gui: Use wallet name for wallet migration rather than WalletModel

2024-08-13 11:25:38 -04:00

load.cpp

Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups

2024-09-20 13:26:38 -04:00

load.h

…

migrate.cpp

refactor: Add explicit cast to expected_last_page to silence fuzz ISan

2024-06-07 17:30:38 +02:00

migrate.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

receive.cpp

…

receive.h

…

salvage.cpp

scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)

2024-12-04 15:09:05 -04:00

salvage.h

…

scriptpubkeyman.cpp

wallet: provide WalletBatch to 'DeleteRecords'

2024-10-21 08:29:22 -03:00

scriptpubkeyman.h

wallet: provide WalletBatch to 'DeleteRecords'

2024-10-21 08:29:22 -03:00

spend.cpp

tracing: only prepare tracepoint args if attached

2024-10-28 14:27:47 +01:00

spend.h

…

sqlite.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

sqlite.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

wallet: fix crash during watch-only wallet migration

2024-12-06 11:26:28 -05:00

wallet.h

wallet: migration, consolidate main wallet db writes

2024-10-21 08:29:23 -03:00

walletdb.cpp

ci: Update Clang in "tidy" job

2024-12-05 14:37:47 +00:00

walletdb.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

wallettool.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

wallettool.h

…

walletutil.cpp

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

walletutil.h

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00