W. J. van der Laan 907d636e5e Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui ...

f5ba424cd4 wallet: Add IsAddressUsed / SetAddressUsed methods (Russell Yanofsky)
62252c95e5 interfaces: Stop exposing wallet destdata to gui (Russell Yanofsky)
985430d9b2 test: Add gui test for wallet receive requests (Russell Yanofsky)

Pull request description:

  Stop giving GUI access to destdata rows in database. Replace with narrow API just for saving and reading receive request information.

  This simplifies code and should prevent the GUI from interfering with other destdata like address-used status. It also adds some more GUI test coverage.

  There are no changes in behavior.

ACKs for top commit:
  jarolrod:
    tACK f5ba424cd4
  laanwj:
    Code review ACK f5ba424cd4

Tree-SHA512: 5423df4786e537a59013cb5bfb9e1bc29a7ca4b8835360c00cc2165a59f925fdc355907a4ceb8bca0285bb4946ba235bffa7645537a951ad03fd3b4cee17b6b0

2021-06-03 15:57:30 +02:00

..

test

Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui

2021-06-03 15:57:30 +02:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

Have OutputGroup determine the value to use

2021-05-19 15:35:11 -04:00

coinselection.h

Have OutputGroup determine the value to use

2021-05-19 15:35:11 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

wallet: Do not iterate a directory if having an error while accessing it

2021-05-12 12:11:47 +03:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

external_signer_scriptpubkeyman.h

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

feebumper.cpp

Replace size/weight estimate tuple with struct for named fields

2021-05-26 07:33:09 +08:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

…

init.cpp

Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100

2021-05-26 19:32:51 +08:00

interfaces.cpp

Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui

2021-06-03 15:57:30 +02:00

ismine.h

doc: Add developer documentation to isminetype

2021-01-19 19:04:45 +08:00

load.cpp

scripted-diff: Fix ellipsis after pr20773

2021-05-27 13:46:36 +03:00

load.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

receive.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

receive.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

rpcdump.cpp

Merge bitcoin/bitcoin#21836: scripted-diff: Replace three dots with ellipsis in the UI strings

2021-05-10 14:02:46 +02:00

rpcwallet.cpp

Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100

2021-05-26 19:32:51 +08:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

scriptpubkeyman.h

wallet: ExternalSigner: add GetDescriptors method

2021-02-23 14:34:31 +01:00

spend.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

spend.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite PRAGMA assignments

2021-05-17 17:22:36 +02:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

refactor: Switch serialize to uint8_t (1/n)

2021-05-31 14:56:17 +02:00

wallet.cpp

Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui

2021-06-03 15:57:30 +02:00

wallet.h

Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui

2021-06-03 15:57:30 +02:00

walletdb.cpp

refactor: Switch serialize to uint8_t (1/n)

2021-05-31 14:56:17 +02:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls

2021-05-24 10:29:58 +02:00

walletutil.h

wallet: add external_signer flag

2021-02-23 14:34:30 +01:00