MarcoFalke 915ac8a861 Merge #19413: refactor: Remove confusing BlockIndex global ...

fa0dfdf447 refactor: Remove confusing BlockIndex global (MarcoFalke)

Pull request description:

  The global `::BlockIndex()` is problematic for several reasons:

  * It returns a mutable reference to the block tree, without the appropriate lock annotation (`m_block_index` is guarded by `cs_main`). The current code is fine, but in the future this might lead to accidental races and data corruption.
  * The rpc server shouldn't rely on node globals, but rather a context that is passed in to the RPC method.
  * Tests might want to spin up their own block tree, and thus should also not rely on a single global.

  Fix all issues by removing the global

ACKs for top commit:
  promag:
    Code review ACK fa0dfdf447.
  jonatack:
    re-ACK fa0dfdf

Tree-SHA512: 8f158fc5e1c67e73588a21c25677b3fa0fe442313b13ec24b87054806c59607d6ba0c062a865ce3e0ee568706bd0d1faa84febda21aff5bcd65dab172f74c52f

2020-07-03 07:38:16 -04:00

..

coinselector_tests.cpp

scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase

2020-06-17 14:12:41 -04:00

db_tests.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

init_test_fixture.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

init_test_fixture.h

test: Avoid overwriting the NodeContext member of the testing setup

2020-06-06 09:50:32 -04:00

init_tests.cpp

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

ismine_tests.cpp

Convert CPubKey to WitnessV0KeyHash directly

2020-06-19 12:14:07 -07:00

psbt_wallet_tests.cpp

psbt: always put a non_witness_utxo and don't remove it

2020-06-24 16:32:19 -04:00

scriptpubkeyman_tests.cpp

scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase

2020-06-17 14:12:41 -04:00

wallet_crypto_tests.cpp

refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)

2020-06-24 18:41:45 +02:00

wallet_test_fixture.cpp

scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase

2020-06-17 14:12:41 -04:00

wallet_test_fixture.h

test: Avoid overwriting the NodeContext member of the testing setup

2020-06-06 09:50:32 -04:00

wallet_tests.cpp

refactor: Remove confusing BlockIndex global

2020-06-29 20:28:47 -04:00