Ryan Ofsky ffb021612b Merge bitcoin/bitcoin#28451: refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream ...

fa98a097a3 Rename version.h to node/protocol_version.h (MarcoFalke)
fa4fbd5816 Remove unused version.h include (MarcoFalke)
fa0ae22ff2 Remove unused SER_NETWORK, SER_DISK (MarcoFalke)
fae00fe9c2 Remove unused CDataStream (MarcoFalke)
fa7eb4f5c3 fuzz: Drop unused version from fuzz input format (MarcoFalke)

Pull request description:

  Seems odd to have code that is completely dead.

  Fix this by removing all of it.

ACKs for top commit:
  sipa:
    utACK fa98a097a3
  ajtowns:
    ACK fa98a097a3
  ryanofsky:
    Seems odd to not code review ACK fa98a097a3 (looks good)

Tree-SHA512: 9f1b9d9f92bda0512610bda6653e892756f637860362a9abfa439faab62de233cbad94b7df78ebacc160d9667aadfed4d9df08c0edefa618c040a049050fb913

2023-11-30 11:11:51 -05:00

..

bench

Remove unused CDataStream

2023-11-30 11:27:54 +01:00

common

Merge bitcoin/bitcoin#28486: test, bench: Initialize and terminate use of Winsock properly

2023-11-29 17:14:34 +00:00

compat

…

config

…

consensus

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

crc32c

…

crypto

…

index

blockstorage: switch from CAutoFile to AutoFile

2023-11-18 03:01:03 +10:00

init

…

interfaces

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

ipc

…

kernel

Merge bitcoin/bitcoin#28903: refactor: Make CTxMemPoolEntry only explicitly copyable

2023-11-28 14:45:23 -05:00

leveldb

…

logging

…

minisketch

…

node

Rename version.h to node/protocol_version.h

2023-11-30 11:28:31 +01:00

policy

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

primitives

Merge bitcoin/bitcoin#28766: Improve peformance of CTransaction::HasWitness (28107 follow-up)

2023-11-28 08:44:41 -05:00

qt

scripted-diff: Use DataStream in most places

2023-11-28 12:42:37 +01:00

rpc

Rename version.h to node/protocol_version.h

2023-11-30 11:28:31 +01:00

script

Fix IWYU for the script_flags fuzz target

2023-11-23 17:57:53 +01:00

secp256k1

…

support

pool: make sure PoolAllocator uses the correct alignment

2023-11-19 18:43:29 +01:00

test

Merge bitcoin/bitcoin#28451: refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream

2023-11-30 11:11:51 -05:00

univalue

…

util

Merge bitcoin/bitcoin#28933: fuzz: Faster wallet_notifications target

2023-11-27 17:35:45 +00:00

wallet

Remove unused version.h include

2023-11-30 11:28:19 +01:00

zmq

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

.bear-tidy-config

…

.clang-format

…

.clang-tidy

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

addrdb.cpp

…

addrdb.h

…

addresstype.cpp

…

addresstype.h

…

addrman_impl.h

…

addrman.cpp

addrman: log AS only when using asmap

2023-10-30 18:46:06 -03:00

addrman.h

doc: fix typos

2023-11-07 10:21:51 +09:00

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it

2023-11-02 14:09:27 -04:00

banman.h

Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it

2023-11-02 14:09:27 -04:00

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

…

blockencodings.cpp

serialize: Drop useless version param from GetSerializeSize()

2023-11-16 11:14:13 +10:00

blockencodings.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

blockfilter.cpp

refactor: SpanReader without nVersion

2023-11-28 12:42:07 +01:00

blockfilter.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

coins.h

Merge bitcoin/bitcoin#28922: Use Txid in COutpoint

2023-11-24 14:41:58 +00:00

compressor.cpp

…

compressor.h

…

core_io.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

core_memusage.h

…

core_read.cpp

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

core_write.cpp

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

…

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

…

external_signer.cpp

Remove unused version.h include

2023-11-30 11:28:19 +01:00

external_signer.h

…

flatfile.cpp

…

flatfile.h

…

hash.cpp

…

hash.h

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

headerssync.cpp

…

headerssync.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet

2023-10-26 14:29:47 -04:00

httpserver.h

…

i2p.cpp

Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from SAM proxy

2023-10-30 14:44:40 +01:00

i2p.h

…

indirectmap.h

…

init.cpp

Merge bitcoin/bitcoin#28858: doc: rewrite explanation for -par=

2023-11-14 15:45:04 +00:00

init.h

…

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

logging.cpp

…

logging.h

…

Makefile.am

Rename version.h to node/protocol_version.h

2023-11-30 11:28:31 +01:00

Makefile.bench.include

…

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.minisketch.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

fuzz: move MockedDescriptorConverter to fuzz/util

2023-11-20 15:57:50 -03:00

Makefile.test_util.include

…

Makefile.test.include

fuzz: add target for DescriptorScriptPubKeyMan

2023-11-20 15:57:56 -03:00

Makefile.univalue.include

…

mapport.cpp

…

mapport.h

…

memusage.h

…

merkleblock.cpp

refactor: Use Txid in CMerkleBlock

2023-11-28 17:49:41 +01:00

merkleblock.h

refactor: Use Txid in CMerkleBlock

2023-11-28 17:49:41 +01:00

net_permissions.cpp

Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet

2023-10-26 14:29:47 -04:00

net_permissions.h

…

net_processing.cpp

Merge bitcoin/bitcoin#28579: refactor: Remove redundant checks in compat/assumptions.h

2023-11-28 16:51:28 -05:00

net_processing.h

refactor: P2P transport without serialize version and type

2023-11-23 13:43:39 +01:00

net_types.cpp

…

net_types.h

…

net.cpp

Merge bitcoin/bitcoin#28892: refactor: P2P transport without serialize version and type

2023-11-28 11:24:09 +00:00

net.h

Rename version.h to node/protocol_version.h

2023-11-30 11:28:31 +01:00

netaddress.cpp

…

netaddress.h

…

netbase.cpp

Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably

2023-11-07 14:11:58 -05:00

netbase.h

Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably

2023-11-07 14:11:58 -05:00

netgroup.cpp

…

netgroup.h

…

netmessagemaker.h

refactor: NetMsg::Make() without nVersion

2023-11-20 14:02:27 +01:00

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

…

protocol.cpp

refactor: Initialize magic bytes in constructor initializer

2023-11-13 14:17:59 +01:00

protocol.h

…

psbt.cpp

Remove unused version.h include

2023-11-30 11:28:19 +01:00

psbt.h

refactor: SpanReader without nVersion

2023-11-28 12:42:07 +01:00

pubkey.cpp

…

pubkey.h

…

random.cpp

Merge bitcoin/bitcoin#26839: Add support for RNDR/RNDRRS for AArch64 on Linux

2023-11-07 15:00:38 -05:00

random.h

…

randomenv.cpp

…

randomenv.h

…

rest.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

rest.h

…

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

Remove unused SER_NETWORK, SER_DISK

2023-11-30 11:28:17 +01:00

shutdown.cpp

…

shutdown.h

…

signet.cpp

refactor: SpanReader without nVersion

2023-11-28 12:42:07 +01:00

signet.h

…

span.h

…

streams.cpp

…

streams.h

Remove unused CDataStream

2023-11-30 11:27:54 +01:00

sync.cpp

…

sync.h

Merge bitcoin/bitcoin#27116: doc: clarify that LOCK() internally checks whether the mutex is held

2023-10-26 15:02:13 -04:00

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

…

torcontrol.cpp

doc: fix typos

2023-11-07 10:21:51 +09:00

torcontrol.h

…

txdb.cpp

…

txdb.h

…

txmempool.cpp

Merge bitcoin/bitcoin#28903: refactor: Make CTxMemPoolEntry only explicitly copyable

2023-11-28 14:45:23 -05:00

txmempool.h

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

txorphanage.cpp

…

txorphanage.h

…

txrequest.cpp

refactor: Remove unused gcc-9 workaround in txrequest

2023-10-30 15:18:40 +01:00

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

validation.cpp

Merge bitcoin/bitcoin#28579: refactor: Remove redundant checks in compat/assumptions.h

2023-11-28 16:51:28 -05:00

validation.h

blockstorage: switch from CAutoFile to AutoFile

2023-11-18 03:01:03 +10:00

validationinterface.cpp

…

validationinterface.h

…

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

…

warnings.cpp

…

warnings.h

…