merge-script 0fbb8043ce Merge bitcoin/bitcoin#30252: test: Remove redundant verack check ...

0000276b31 test: Remove redundant verack check (MarcoFalke)

Pull request description:

  Currently the sync in `connect_nodes` mentions the `version` and `verack` message types, but only checks the `verack`. Neither check is required, as the `pong` check implies both. In case of failure, the debug log will have to be consulted anyway, so the redundant check doesn't add value.

  Also clarify in the comments that the goal is to check the flag `fSuccessfullyConnected` indirectly.

ACKs for top commit:
  furszy:
    utACK 0000276b31
  brunoerg:
    ACK 0000276b31
  tdb3:
    ACK 0000276b31

Tree-SHA512: f9ddcb1436d2f70da462a8dd470ecfc90a534dd6507c23877ef7626e7c02326c077001a42ad0171a87fba5c5275d1970d8c5e5d82c56c8412de944856fdfd6db

2024-06-11 14:11:34 +01:00

..

crypto

crypto: add NUMS_H const

2024-05-14 10:24:31 +02:00

__init__.py

…

address.py

test: add MiniWallet tagging support to avoid UTXO mixing

2024-05-05 12:33:34 +02:00

authproxy.py

test: use json-rpc 2.0 in all functional tests by default

2024-06-07 09:26:55 -04:00

bdb.py

…

bip340_test_vectors.csv

…

blockfilter.py

…

blocktools.py

[test]: remove duplicate WITNESS_SCALE_FACTOR

2024-05-03 10:30:50 +01:00

coverage.py

…

descriptors.py

…

key.py

…

mempool_util.py

test: use tagged ephemeral MiniWallet instance in fill_mempool

2024-05-05 12:36:51 +02:00

messages.py

test: p2p: check disconnect due to lack of desirable service flags

2024-03-11 15:23:09 +01:00

netutil.py

test: cover UNIX sockets in feature_proxy.py

2024-03-01 14:47:29 -05:00

p2p.py

scripted-diff: test: Use int.to_bytes over struct packing

2024-05-07 15:40:47 +02:00

psbt.py

…

script_util.py

…

script.py

test: Remove struct.pack from almost all places

2024-05-07 15:41:17 +02:00

segwit_addr.py

…

socks5.py

…

test_framework.py

test: Remove redundant verack check

2024-06-10 07:58:10 +02:00

test_node.py

Merge bitcoin/bitcoin#30132: indexes: Don't wipe indexes again when continuing a prior reindex

2024-06-10 10:12:30 -04:00

test_shell.py

…

util.py

test: refactor: move fill_mempool to new module mempool_util

2024-05-05 12:33:30 +02:00

v2_p2p.py

…

wallet_util.py

Fix typos in description.md and wallet_util.py

2024-04-25 16:14:10 +08:00

wallet.py

test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py

2024-05-31 00:12:00 +02:00