Wladimir J. van der Laan 470664f2b7 Merge #17746: refactor: rpc: Remove vector copy from listtransactions ...

25bc17fceb refactor: rpc: Remove vector copy from listtransactions (João Barbosa)

Pull request description:

  Current approach
   - copy accumulated `ret` vector to `arrTmp`
   - drop unnecessary elements from `arrTmp`
   - reverse `arrTmp`
   - clear `ret`
   - copy `arrTmp` to the `ret`

  New approach
   - create a vector from the accumulated `ret` with just the necessary elements already reversed
   - copy it to the result

  This PR doesn't change behavior.

ACKs for top commit:
  ryanofsky:
    Code review ACK 25bc17fceb. Just comment and commit message tweaks since last review

Tree-SHA512: 87906561e3accdbdb0f4a8194cbcd76ea53ae53d0ce135b90bc54a5f77e300b14ef08505e7daf1fe52426f135442a743da5a027416a769bd454922357cebe7c0

2020-02-13 18:50:02 +01:00

..

test

psbt_wallet_tests: use unique_ptr for GetSigningProvider

2020-01-30 16:09:13 +10:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

crypter.cpp

…

crypter.h

…

db.cpp

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00

db.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

ismine.h

…

load.cpp

…

load.h

…

psbtwallet.cpp

Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple

2020-01-30 17:21:21 +13:00

psbtwallet.h

Fix doxygen errors

2020-01-16 18:25:11 -08:00

rpcdump.cpp

Merge #17804: doc: Misc RPC help fixes

2020-02-05 14:54:42 +01:00

rpcwallet.cpp

Merge #17746: refactor: rpc: Remove vector copy from listtransactions

2020-02-13 18:50:02 +01:00

rpcwallet.h

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

scriptpubkeyman.cpp

Refactor: Replace SigningProvider pointers with unique_ptrs

2020-01-23 16:35:08 -05:00

scriptpubkeyman.h

Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple

2020-01-30 17:21:21 +13:00

wallet.cpp

Remove false positive GCC warning

2020-02-01 23:07:19 +02:00

wallet.h

Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple

2020-01-30 17:21:21 +13:00

walletdb.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

walletdb.h

Fix doxygen errors

2020-01-16 18:25:11 -08:00

wallettool.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…