MarcoFalke bab4cce1b0 Merge #19668: Do not hide compile-time thread safety warnings ...

ea74e10acf doc: Add best practice for annotating/asserting locks (Hennadii Stepanov)
2ee7743fe7 sync.h: Make runtime lock checks require compile-time lock checks (Anthony Towns)
23d71d171e Do not hide compile-time thread safety warnings (Hennadii Stepanov)
3ddc150857 Add missed thread safety annotations (Hennadii Stepanov)
af9ea55a72 Use LockAssertion utility class instead of AssertLockHeld() (Hennadii Stepanov)

Pull request description:

  On the way of transit from `RecursiveMutex` to `Mutex` (see #19303) it is crucial to have run-time `AssertLockHeld()` assertion that does _not_ hide compile-time Clang Thread Safety Analysis warnings.

  On master (65e4ecabd5) using `AssertLockHeld()` could hide Clang Thread Safety Analysis warnings, e.g., with the following patch applied:
  ```diff
  --- a/src/txmempool.h
  +++ b/src/txmempool.h
  @@ -607,7 +607,7 @@ public:
       void addUnchecked(const CTxMemPoolEntry& entry, setEntries& setAncestors, bool validFeeEstimate = true) EXCLUSIVE_LOCKS_REQUIRED(cs, cs_main);

       void removeRecursive(const CTransaction& tx, MemPoolRemovalReason reason) EXCLUSIVE_LOCKS_REQUIRED(cs);
  -    void removeForReorg(const CCoinsViewCache* pcoins, unsigned int nMemPoolHeight, int flags) EXCLUSIVE_LOCKS_REQUIRED(cs, cs_main);
  +    void removeForReorg(const CCoinsViewCache* pcoins, unsigned int nMemPoolHeight, int flags) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
       void removeConflicts(const CTransaction& tx) EXCLUSIVE_LOCKS_REQUIRED(cs);
       void removeForBlock(const std::vector<CTransactionRef>& vtx, unsigned int nBlockHeight) EXCLUSIVE_LOCKS_REQUIRED(cs);

  ```
  Clang compiles the code without any thread safety warnings.

  See "Add missed thread safety annotations" commit for the actual thread safety warnings that are fixed in this PR.

ACKs for top commit:
  MarcoFalke:
    ACK ea74e10acf 🎙
  jnewbery:
    ACK ea74e10acf
  ajtowns:
    ACK ea74e10acf

Tree-SHA512: 8cba996e526751a1cb0e613c0cc1b10f027a3e9945fbfb4bd30f6355fd36b9f9c2e1e95ed3183fc254b42df7c30223278e18e5bdb5e1ef85db7fef067595d447

2020-09-01 08:18:26 +02:00

..

test

Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump)

2020-08-31 17:43:35 +02:00

bdb.cpp

refactor: Make HexStr take a span

2020-08-06 19:41:43 +02:00

bdb.h

Remove BDB dummy databases

2020-07-29 12:30:23 -04:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

coinselection.h

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

Introduce DummyDatabase and use it in the tests

2020-07-29 12:28:30 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Merge #19671: wallet: Remove -zapwallettxes

2020-09-01 09:26:28 +08:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

Add loadwallet and createwallet RPC load_on_startup options

2020-08-13 09:44:48 -04:00

load.h

Add loadwallet and createwallet RPC load_on_startup options

2020-08-13 09:44:48 -04:00

rpcdump.cpp

rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)

2020-08-14 12:38:03 +02:00

rpcwallet.cpp

Merge #19671: wallet: Remove -zapwallettxes

2020-09-01 09:26:28 +08:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

scriptpubkeyman.h

Add missed thread safety annotations

2020-08-29 20:46:23 +03:00

wallet.cpp

Merge #19671: wallet: Remove -zapwallettxes

2020-09-01 09:26:28 +08:00

wallet.h

Merge #19668: Do not hide compile-time thread safety warnings

2020-09-01 08:18:26 +02:00

walletdb.cpp

Remove -zapwallettxes

2020-08-31 12:39:19 -04:00

walletdb.h

Remove -zapwallettxes

2020-08-31 12:39:19 -04:00

wallettool.cpp

build: Add Werror=range-loop-analysis

2020-08-14 15:27:38 +02:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00