Andrew Chow b4fb0a3255 Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries for watchonly/solvable wallets ...

730e14a317 test: wallet: check that labels are migrated to watchonly wallet (Sebastian Falbesoner)
d5f4ae7fac wallet: fully migrate address book entries for watchonly/solvable wallets (Sebastian Falbesoner)

Pull request description:

  Currently `migratewallet` migrates the address book (i.e. labels and purposes) for watchonly and solvable wallets only in RAM, but doesn't persist them on disk. Fix this by adding another loop for both of the special wallet types after which writes the corresponding NAME and PURPOSE entries to the database in a single batch. Also adds a corresponding test that checks if labels were migrated correctly for a watchonly wallet.

ACKs for top commit:
  achow101:
    ACK 730e14a317
  furszy:
    code ACK 730e14a3, left a non-blocking nit.
  aureleoules:
    ACK 730e14a317

Tree-SHA512: 159487e11e858924ef762e0190ccaea185bdff239e3d2280c8d63c4ac2649ec71714dc4d53dec644f03488f91c3b4bbbbf3434dad23bc0fcecb6657f353ea766

2023-01-05 12:22:51 -05:00

..

rpc

Merge bitcoin/bitcoin#26795: rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field

2023-01-04 11:09:57 +01:00

test

Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literals instead of c style casts

2023-01-05 17:30:52 +01:00

bdb.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

bdb.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coinselection.cpp

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

coinselection.h

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

…

crypter.cpp

…

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

…

db.h

…

dump.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

dump.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

feebumper.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

…

init.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

interfaces.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

ismine.h

…

load.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

salvage.cpp

…

salvage.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

scriptpubkeyman.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

scriptpubkeyman.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

spend.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

spend.h

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

sqlite.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

sqlite.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

transaction.cpp

…

transaction.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

wallet.cpp

Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries for watchonly/solvable wallets

2023-01-05 12:22:51 -05:00

wallet.h

Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods

2023-01-04 17:53:58 +00:00

walletdb.cpp

Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename

2023-01-03 11:54:51 -05:00

walletdb.h

Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename

2023-01-03 11:54:51 -05:00

wallettool.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

wallettool.h

…

walletutil.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

walletutil.h

…