MarcoFalke df127ecede Merge #19829: net processing: Move block inventory state to net_processing ...

3002b4af2b [net processing] Guard m_continuation_block with m_block_inv_mutex (John Newbery)
184557e8e0 [net processing] Move hashContinue to net processing (John Newbery)
c853ef002e scripted-diff: rename vBlockHashesToAnnounce and vInventoryBlockToSend (John Newbery)
53b7ac1b7d [net processing] Move block inventory data to Peer (John Newbery)
78040f9168 [net processing] Rename nStartingHeight to m_starting_height (John Newbery)
77a2c2f8f9 [net processing] Move nStartingHeight to Peer (John Newbery)
717a374e74 [net processing] Improve documentation for Peer destruction/locking (John Newbery)

Pull request description:

  This continues the work of moving application layer data into net_processing, by moving all block inventory state into the new Peer object added in #19607.

  For motivation, see #19398.

ACKs for top commit:
  jonatack:
    re-ACK 3002b4af2b per `git diff 9aad3e4 3002b4a`
  Sjors:
    Code review re-ACK 3002b4af2b
  MarcoFalke:
    re-ACK 3002b4af2b 🌓

Tree-SHA512: eb2b474b73b025791ee3e6e41809926b332b48468763219f31638ca390f427632f05902dfc6a2c6bdc1ce47b215782f67874ddbf05b97d77d5897b7e2abfe4d9

2020-12-22 12:44:19 +01:00

..

bench

Replace boost::optional with std::optional

2020-12-19 09:46:55 +01:00

compat

…

config

…

consensus

…

crc32c

build: Update crc32c subtree

2020-12-08 19:26:30 +01:00

crypto

…

index

…

interfaces

refactor: Get rid of more redundant chain methods

2020-12-07 09:09:53 -04:00

leveldb

…

logging

…

node

Merge #19910: net processing: Move peer_map to PeerManager

2020-12-09 21:56:17 +08:00

policy

Merge #20611: Move TX_MAX_STANDARD_VERSION to policy

2020-12-15 22:46:49 +01:00

primitives

Merge #20611: Move TX_MAX_STANDARD_VERSION to policy

2020-12-15 22:46:49 +01:00

qt

[net processing] Rename nStartingHeight to m_starting_height

2020-12-20 10:01:46 +00:00

rpc

Merge #19829: net processing: Move block inventory state to net_processing

2020-12-22 12:44:19 +01:00

script

Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const

2020-12-06 00:22:40 +00:00

secp256k1

…

support

…

test

fuzz: Update FuzzedDataProvider.h from upstream (LLVM)

2020-12-21 23:19:33 +00:00

univalue

…

util

util: Allow use of C++14 chrono literals

2020-12-08 16:47:36 +01:00

wallet

Replace boost::optional with std::optional

2020-12-19 09:46:55 +01:00

zmq

…

.clang-format

…

addrdb.cpp

…

addrdb.h

…

addrman.cpp

…

addrman.h

…

amount.h

…

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Move TX_MAX_STANDARD_VERSION to policy

2020-12-10 11:12:08 +01:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

wallet: Add missing check for -descriptors wallet tool option

2020-12-17 20:36:41 +01:00

bitcoind-res.rc

…

bitcoind.cpp

init: Signal-safe instant shutdown

2020-12-15 17:21:06 +01:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

bloom.cpp

…

bloom.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

Move signet onion seed from v2 to v3

2020-12-15 14:12:01 +01:00

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

…

compat.h

…

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

…

core_read.cpp

Improve heuristic hex transaction decoding

2020-12-08 10:11:02 -08:00

core_write.cpp

…

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

…

dummywallet.cpp

…

flatfile.cpp

…

flatfile.h

…

fs.cpp

…

fs.h

…

hash.cpp

…

hash.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

…

httpserver.h

…

indirectmap.h

…

init.cpp

Merge #20668: doc: warn that incoming conns are unlikely when not using default ports

2020-12-17 12:10:00 +01:00

init.h

Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const

2020-12-06 00:22:40 +00:00

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

logging.cpp

…

logging.h

…

Makefile.am

Merge #20434: contrib: Parse ELF directly for symbol and security checks

2020-12-18 12:16:40 +01:00

Makefile.bench.include

…

Makefile.crc32c.include

build: Update crc32c subtree

2020-12-08 19:26:30 +01:00

Makefile.leveldb.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

…

Makefile.test_util.include

…

Makefile.test.include

build: Add option --enable-danger-fuzz-link-all

2020-12-14 16:55:56 +01:00

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

miner.cpp

…

miner.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

[net processing] Guard m_continuation_block with m_block_inv_mutex

2020-12-20 10:06:14 +00:00

net_processing.h

[net processing] Guard m_continuation_block with m_block_inv_mutex

2020-12-20 10:06:14 +00:00

net_types.h

…

net.cpp

[net processing] Move hashContinue to net processing

2020-12-20 10:03:38 +00:00

net.h

[net processing] Move hashContinue to net processing

2020-12-20 10:03:38 +00:00

netaddress.cpp

Check if Cjdns address is valid

2020-12-14 14:48:52 -03:00

netaddress.h

…

netbase.cpp

…

netbase.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

optional.h

Replace boost::optional with std::optional

2020-12-19 09:46:55 +01:00

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

…

protocol.cpp

Remove unused bits from service flags enum

2020-12-08 18:36:51 +01:00

protocol.h

Remove unused bits from service flags enum

2020-12-08 18:36:51 +01:00

psbt.cpp

psbt: Assert that tx has a value in UpdatePSBTOutput

2020-12-19 09:45:39 +01:00

psbt.h

…

pubkey.cpp

…

pubkey.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

random.cpp

…

random.h

…

randomenv.cpp

util: Allow use of C++14 chrono literals

2020-12-08 16:47:36 +01:00

randomenv.h

…

rest.cpp

…

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

…

shutdown.cpp

init: Signal-safe instant shutdown

2020-12-15 17:21:06 +01:00

shutdown.h

init: Signal-safe instant shutdown

2020-12-15 17:21:06 +01:00

signet.cpp

…

signet.h

…

span.h

…

streams.h

…

sync.cpp

sync: Improve CheckLastCritical()

2020-12-10 20:46:29 +02:00

sync.h

[skip ci] sync: Check precondition in LEAVE_CRITICAL_SECTION() macro

2020-12-10 20:46:39 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

…

txdb.h

…

txmempool.cpp

…

txmempool.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

txrequest.cpp

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Merge #18766: Disable fee estimation in blocksonly mode (by removing the fee estimates global)

2020-12-07 12:59:48 +01:00

validation.h

Merge #20575: Do not run functions with necessary side-effects in assert()

2020-12-16 23:14:53 +01:00

validationinterface.cpp

…

validationinterface.h

…

version.h

…

versionbits.cpp

…

versionbits.h

…

versionbitsinfo.cpp

…

versionbitsinfo.h

…

walletinitinterface.h

…

warnings.cpp

…

warnings.h

…