highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-12 13:42:10 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
9961229360cbf34ab114b831341e7760a58a4edd
bitcoin/src
History
Ava Chow 9961229360 Merge bitcoin/bitcoin#31298: rpc: combinerawtransaction now rejects unmergeable transactions 
6d86184a8b rpc: combinerawtransaction now rejects unmergeable transactions (Adam Andrews)

Pull request description:

  Previously, combinerawtransaction would silently return the first tx when asked to combine unrelated txs. Now, it will check tx mergeability and throws a descriptive error if tx cannot be merged.

  fixes  #25980

ACKs for top commit:
  nervana21:
    tACK 6d86184a8b
  achow101:
    ACK 6d86184a8b
  rkrux:
    ACK [6d86184](6d86184a8b)

Tree-SHA512: 5caf983c5ab618a000f40b9ad698439d3e6217ec2dc593740443f47d90f8804a895f3054dd29bbcecdb48a61992b0d0afda7ec89591d768a44918648bbb6e20d
2026-05-13 16:07:35 -07:00
..
bench
bench: Utilize setup() for WalletLoading and use a real database
2026-04-29 14:49:39 -07:00
common
psbt: Return std::optional from PrecomputePSBTData
2026-04-29 15:04:22 -07:00
compat
refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning
2026-02-18 21:29:07 +01:00
consensus
Remove Taproot activation height
2026-03-10 16:17:40 +01:00
crc32c
…
crypto
crypto: Use secure_allocator for AES256CBC*::iv
2026-03-10 19:09:21 -07:00
index
Merge bitcoin/bitcoin#34440: refactor: Change CChain methods to use references, add tests
2026-04-22 15:49:51 -07:00
init
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
interfaces
psbt: make PSBT structs into classes
2026-04-29 14:51:47 -07:00
ipc
Merge bitcoin/bitcoin#34977: Update libmultiprocess subtree to fix test timeout
2026-04-07 13:33:11 -07:00
kernel
kernel: Expose btck_transaction_check consensus function
2026-04-30 17:39:25 -07:00
leveldb
Bump leveldb subtree
2026-02-03 11:19:01 +01:00
logging
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
minisketch
…
node
Merge bitcoin/bitcoin#35152: doc: clarify local IWYU workflow and pragmas
2026-05-10 19:24:58 +02:00
policy
Merge bitcoin/bitcoin#34669: feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-04-30 11:35:53 -07:00
primitives
serialize: Add missing <span> header
2026-03-19 19:13:40 +00:00
qt
Merge bitcoin/bitcoin#35123: wallet: remove outdated arguments from chain scanning methods
2026-05-13 14:34:15 -07:00
rpc
Merge bitcoin/bitcoin#31298: rpc: combinerawtransaction now rejects unmergeable transactions
2026-05-13 16:07:35 -07:00
script
fuzz: Enforce additional version invariants in PSBT fuzzer
2026-04-29 15:04:22 -07:00
secp256k1
Update secp256k1 subtree to latest master
2026-04-09 10:25:28 +08:00
support
Merge bitcoin/bitcoin#34436: refactor: add overflow-safe CeilDiv helper and use it in unsigned callsites
2026-03-11 11:30:42 +01:00
test
Merge bitcoin/bitcoin#35156: dbwrapper: reuse scratch DataStream buffers
2026-05-13 14:27:11 -07:00
univalue
refactor: Return std::optional from ParseDouble
2026-03-30 09:03:06 +02:00
util
util, iwyu: Add missed header
2026-04-30 20:42:12 +01:00
wallet
Merge bitcoin/bitcoin#35123: wallet: remove outdated arguments from chain scanning methods
2026-05-13 14:34:15 -07:00
zmq
scripted-diff: rpc: Don't pointlessly capture in RPCMethod lambdas
2026-03-25 19:18:11 +10:00
.clang-format
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-tidy
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
2026-02-06 08:37:19 +01:00
addrdb.cpp
log: fix minor formatting in debug logs
2026-02-15 22:54:45 +01:00
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
addrman.cpp
Merge bitcoin/bitcoin#34602: test: addrman: successive failures in the last week for IsTerrible
2026-03-16 22:29:38 +01:00
addrman.h
refactor: addrman: move consts to .h
2026-02-16 16:09:30 -03:00
arith_uint256.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
arith_uint256.h
…
attributes.h
…
banman.cpp
log: fix minor formatting in debug logs
2026-02-15 22:54:45 +01:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli, rpc: add -rpcid option for custom request IDs
2026-04-16 12:58:49 +02:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
refactor: use SignOptions for MutableTransactionSignatureCreator
2026-04-28 17:43:03 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
bitcoin.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
bitcoind-res.rc
…
bitcoind.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
blockencodings.cpp
doc: remove stale shortid collision TODO
2026-04-01 11:53:14 -07:00
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
btcsignals.h
btcsignals: use a single shared_ptr for liveness and callback
2026-04-03 18:25:30 +00:00
chain.cpp
Change CChain::FindFork() to take ref
2026-04-20 08:55:51 +02:00
chain.h
Change CChain::FindFork() to take ref
2026-04-20 08:55:51 +02:00
chainparams.cpp
…
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
…
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
contrib: Update fixed feeds
2026-02-25 14:36:19 -08:00
checkqueue.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
clientversion.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
clientversion.h
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
cluster_linearize.h
Merge bitcoin/bitcoin#34669: feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-04-30 11:35:53 -07:00
CMakeLists.txt
Merge bitcoin/bitcoin#34495: Replace boost signals with minimal compatible implementation
2026-04-09 16:25:47 +08:00
coins.cpp
refactor: inline CCoinsViewBacked implementation
2026-04-08 22:36:13 +02:00
coins.h
Merge bitcoin/bitcoin#31449: coins,refactor: Reduce getblockstats RPC UTXO overhead estimation
2026-04-20 15:52:45 -07:00
compressor.cpp
…
compressor.h
…
core_io.cpp
Merge bitcoin/bitcoin#31449: coins,refactor: Reduce getblockstats RPC UTXO overhead estimation
2026-04-20 15:52:45 -07:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
…
cuckoocache.h
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
dbwrapper.cpp
dbwrapper: reuse iterator scratch stream
2026-04-28 10:41:59 +02:00
dbwrapper.h
dbwrapper: reuse iterator scratch stream
2026-04-28 10:41:59 +02:00
deploymentinfo.cpp
Remove Taproot activation height
2026-03-10 16:17:40 +01:00
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
external_signer.cpp
psbt: Remove default constructor
2026-04-29 14:51:47 -07:00
external_signer.h
psbt: make PSBT structs into classes
2026-04-29 14:51:47 -07:00
flatfile.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
flatfile.h
…
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 57315a6985..7262adb4b4
2026-04-09 10:25:28 +08:00
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
refactor(rpc): GenerateAuthCookieResult -> AuthCookieResult
2026-03-31 12:15:17 +02:00
httprpc.h
refactor: Add ExecuteHTTPRPC function
2026-02-27 19:26:08 -04:00
httpserver.cpp
Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race
2026-02-19 12:41:12 -08:00
httpserver.h
refactor: Add ExecuteHTTPRPC function
2026-02-27 19:26:08 -04:00
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#34440: refactor: Change CChain methods to use references, add tests
2026-04-22 15:49:51 -07:00
init.h
…
key_io.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
Merge bitcoin/bitcoin#34865: logging: better use of log::Entry internally
2026-04-23 12:33:49 +02:00
logging.h
Merge bitcoin/bitcoin#34865: logging: better use of log::Entry internally
2026-04-23 12:33:49 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
merkleblock.h
…
musig.cpp
…
musig.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#33300: fuzz: compact block harness
2026-05-04 22:28:54 +01:00
net_processing.h
Merge bitcoin/bitcoin#33300: fuzz: compact block harness
2026-05-04 22:28:54 +01:00
net_types.cpp
…
net_types.h
…
net.cpp
net: make CConnman::m_nodes_mutex non-recursive
2026-04-30 13:41:44 +02:00
net.h
net: make CConnman::m_nodes_mutex non-recursive
2026-04-30 13:41:44 +02:00
netaddress.cpp
…
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
net: log SOCKS5 auth before sending
2026-04-20 01:40:41 +03:00
netbase.h
refactor: Return std::optional from GetProxy
2026-03-10 21:15:19 +01:00
netgroup.cpp
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netgroup.h
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netmessagemaker.h
…
noui.cpp
signals: use an alias for the boost::signals2 namespace
2026-02-05 16:20:42 +00:00
noui.h
refactor: Remove empty caption from ThreadSafeMessageBox
2026-01-14 19:36:14 +01:00
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
prevector: simplify operator==
2026-03-04 15:06:34 +01:00
private_broadcast.cpp
net: delay stale evaluation and expose time_added in private broadcast
2026-03-25 11:49:05 -04:00
private_broadcast.h
Merge bitcoin/bitcoin#34967: doc: Discourage trailing doxygen comments, and fix the broken ones
2026-04-06 18:42:26 +08:00
protocol.cpp
…
protocol.h
…
psbt.cpp
Implement PSBTv2 field merging
2026-04-29 15:04:22 -07:00
psbt.h
fuzz: Enforce additional version invariants in PSBT fuzzer
2026-04-29 15:04:22 -07:00
pubkey.cpp
…
pubkey.h
…
random.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
randomenv.h
…
rest.cpp
Change CChain::Next() to take reference
2026-04-20 08:55:44 +02:00
rest.h
…
scheduler.cpp
…
scheduler.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
semaphore_grant.h
…
serialize.h
Implement PSBTv2 fields de/ser
2026-04-29 15:04:22 -07:00
signet.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
signet.h
…
span.h
…
streams.cpp
…
streams.h
streams: add ScopedDataStreamUsage
2026-04-28 10:37:15 +02:00
sync.cpp
sync: Use StdMutex for thread safety annotations
2026-03-23 15:13:45 +10:00
sync.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
threadsafety.h
refactor: Move StdMutex to its own header
2026-03-20 15:37:44 +00:00
tinyformat.h
…
torcontrol.cpp
tor: torcontrol disconnect on too many lines to avoid OOM
2026-04-17 11:53:17 -07:00
torcontrol.h
torcontrol: Move tor controller into node context
2026-04-03 22:00:29 +02:00
txdb.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
txdb.h
coins: make CCoinsView methods pure virtual
2026-04-08 22:36:13 +02:00
txgraph.cpp
clusterlin: adopt STL ranges algorithms (refactor)
2026-02-27 08:38:01 -05:00
txgraph.h
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.cpp
Change CChain::Contains() to take reference
2026-04-20 08:55:26 +02:00
txmempool.h
multi_index: fix compilation failure with boost >= 1.91
2026-04-28 18:22:47 +00:00
txrequest.cpp
multi_index: fix compilation failure with boost >= 1.91
2026-04-28 18:22:47 +00:00
txrequest.h
…
uint256.cpp
…
uint256.h
ci, iwyu: Fix warnings in src/util and treat them as errors
2026-03-30 16:39:42 +01:00
undo.h
coins: pack Coin height/coinbase consistently
2026-02-09 17:27:39 +01:00
validation.cpp
validation: correct lifetime of precomputed tx data
2026-05-05 07:52:08 -04:00
validation.h
Merge bitcoin/bitcoin#34440: refactor: Change CChain methods to use references, add tests
2026-04-22 15:49:51 -07:00
validationinterface.cpp
validation: Move block into BlockDisconnected signal
2026-03-18 13:34:26 +01:00
validationinterface.h
validation: Move block into BlockDisconnected signal
2026-03-18 13:34:26 +01:00
versionbits_impl.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…