MarcoFalke 793e0ff22c Merge #18698: Make g_chainman internal to validation ...

fab6b9d18f validation: Mark g_chainman DEPRECATED (MarcoFalke)
fa1d97b256 validation: Make ProcessNewBlock*() members of ChainstateManager (MarcoFalke)
fa24d49098 validation: Make PruneOneBlockFile() a member of ChainstateManager (MarcoFalke)
fa84b1cd84 validation: Make LoadBlockIndex() a member of ChainstateManager (MarcoFalke)
fa05fdf0f1 net: Pass chainman into PeerLogicValidation (MarcoFalke)
fa7b626d7a node: Add chainman alias for g_chainman (MarcoFalke)

Pull request description:

  The global `g_chainman` has recently been introduced in #17737. The chainstate manager is primarily needed for the assumeutxo feature, but it can also simplify testing in the future.

  The goal of this pull is to make the global chainstate manager internal to validation, so that all external code does not depend on globals and that unit or fuzz tests can pass in their (potentially mocked) chainstate manager.

  I suggest reviewing the pull request commit-by-commit. It should be relatively straightforward refactoring that does not change behavior at all.

ACKs for top commit:
  ryanofsky:
    Code review ACK fab6b9d18f. Had to be rebased but still looks good

Tree-SHA512: dcbf114aeef4f8320d466369769f22ce4dd8f46a846870354df176c3de9ff17c64630fbd777e7121d7470d7a8564ed8d37b77168746e8df7489c6877e55d7b4f

2020-05-23 07:58:13 -04:00

..

test

validation: Make PruneOneBlockFile() a member of ChainstateManager

2020-05-21 09:56:16 -04:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

refactor: Add BerkeleyDatabaseVersion() function

2020-05-11 20:42:55 +03:00

db.h

build: Enable -Wsuggest-override

2020-05-12 18:03:39 +03:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Make InitError bilingual

2020-05-05 04:46:04 +03:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

gui: Do not translate InitWarning messages in debug.log

2020-05-10 18:01:28 +03:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

rpcdump.cpp

Remove CWalletTx merging logic from AddToWallet

2020-05-01 05:59:09 -05:00

rpcwallet.cpp

Merge #18787: wallet: descriptor wallet release notes and cleanups

2020-05-22 14:21:56 +12:00

rpcwallet.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

scriptpubkeyman.cpp

Merge #18787: wallet: descriptor wallet release notes and cleanups

2020-05-22 14:21:56 +12:00

scriptpubkeyman.h

Merge #18787: wallet: descriptor wallet release notes and cleanups

2020-05-22 14:21:56 +12:00

wallet.cpp

Merge #18787: wallet: descriptor wallet release notes and cleanups

2020-05-22 14:21:56 +12:00

wallet.h

[wallet] remove nLastResend logic

2020-05-17 17:52:11 -07:00

walletdb.cpp

Merge #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed

2020-05-22 13:48:26 +12:00

walletdb.h

Merge #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed

2020-05-22 13:48:26 +12:00

wallettool.cpp

wallet: Report full error message in wallettool

2020-05-01 07:39:35 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

wallet: Make sure no WalletDescriptor members are uninitialized after construction

2020-04-27 14:20:26 +00:00