mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-06 21:57:54 +02:00
ff7cdf633e
fa90b21430test: Remove unused feature_segwit.py functions (MarcoFalke)fa6b05c96ftest: Remove unused CUSTOM_._COUNT (MarcoFalke)fa7bac94d8test: Remove unused wait_for_addr, firstAddrnServices, on_addr (MarcoFalke)fa388a3585test: Remove unused self.p2p_conn_index = 1 (MarcoFalke)fa803710e2test: Remove unused AddressType (MarcoFalke)fab5072ce1ci: Remove vulture (MarcoFalke) Pull request description: Currently, `vulture` is run with `--min-confidence=100`, which reduces its checks to dead code after control statements, which is nice, but not really a common nor severe issue. See the discussion in https://github.com/bitcoin/bitcoin/issues/34810#issuecomment-4045927137 and commit5c005363a8, which had to remove dead code manually. Reducing the confidence has shown to be too brittle/tedious in the past, so remove the tool for now from CI. Of course, removing this from CI does not prevent anyone from running it locally and removing dead code. Fixes https://github.com/bitcoin/bitcoin/issues/34810 ACKs for top commit: fanquake: ACKfa90b21430willcl-ark: ACKfa90b21430Tree-SHA512: 6a5998470dae3a17baec29b70b02333f4cd9b81bc4c6a05b56085ff1ba527ed7bdeccd17b09d9ad785ae03c97982ee1f3147e4df3bd537c66b02e9a44d0e5f15