mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 21:52:53 +02:00
27b6b5a458
ddddffda3adoc: Add doc/release-notes-35836.md (MarcoFalke)fa7fe798c6wallet: Remove meaningless bool fallback in FundTransaction (MarcoFalke) Pull request description: This mostly removes a no-op and meaningless bool fallback in the `fundrawtransaction` RPC. This allows to remove a `skip_type_check`. This makes validating the JSON schema from https://github.com/bitcoin/bitcoin/pull/34683 more consistent. Adding the type check here is useful, because: * The fallback was added inaf4fe7fd12(more than a decade ago). Retaining backwards compat with more than 10-year old clients seems purely theoretical. There were other breaking RPC changes on shorter notice in the meantime. If someone really forgot to update this over the last 10 years, I don't see a downside of notifying them. * The compat only works for positional args, which seems another small reason to drop it. * The compat is now fully irrelevant and a no-op, given that watch-only wallet is not a concept anymore after commit1337c72198. * Keeping the compat means that openrpc spec users do not get any type checks at all here. ACKs for top commit: polespinasa: ACKddddffda3asedited: ACKddddffda3aTree-SHA512: aa5113bd74159ae5a3bf189edc48d011761db98beaf701cd144ba94eac9f525bec2b8eeb53e588b2f20dc9965ebabef2c5ce55a732b8cef2874a95f398ecae8f