mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-30 12:36:11 +02:00

History

Merge bitcoin/bitcoin#25306 : logging: add LogPrintfCategory to log unconditionally with category

ecff20db286e2f5d3afe32cfaae72de69d34d23c logging: use LogPrintfCategory rather than a manual category (Jon Atack)
eb8aab759fb15824a5dd3004e689d0eb5b884a32 logging: add LogPrintfCategory to log unconditionally with category (Jon Atack)

Pull request description:

  These are the next two commits from #25203.

  - Add `LogPrintfCategory` to log unconditionally while prefixing the output with the passed category name. Add documentation and a unit test, and update the `lint-logs.py` and `lint-format-strings.py` scripts.

  - Replace the log messages that manually print a category, with `LogPrintfCategory`. In upcoming commits, it will likely be used in many other cases, such as to replace `LogPrintf` where it makes sense.

ACKs for top commit:
  klementtan:
    Code Review ACK ecff20db286e2f5d3afe32cfaae72de69d34d23c
  laanwj:
    Code review ACK ecff20db286e2f5d3afe32cfaae72de69d34d23c
  brunoerg:
    ACK ecff20db286e2f5d3afe32cfaae72de69d34d23c

Tree-SHA512: ad3a82835254f7606efcd14b88f3d9072f1eb9b25db1321ed38ef6a4ec60efd555d78f5e19d93736f2f8500251d06f8beee9d694a153f24bf5cce3590a2a45a5

2022-06-14 11:46:32 +02:00

all-lint.py

test: clean up all-lint.py

2022-06-07 10:24:55 +02:00

check-doc.py

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

commit-script-check.sh

script: redirecting stderr to stdout before pipelining into grep

2022-01-22 12:36:19 +01:00

git-subtree-check.sh

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

lint-assertions.py

lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py

2022-04-26 10:01:54 +02:00

lint-circular-dependencies.py

kernel: Use ComputeUTXOStats in validation

2022-05-23 14:53:35 -04:00

lint-files.py

test: Use permissions from git in lint-files.py

2022-05-23 11:09:07 +02:00

lint-format-strings.py

logging: add LogPrintfCategory to log unconditionally with category

2022-06-08 14:02:54 +02:00

lint-git-commit-check.py

lint: Convert lint-git-commit-check.sh to Python

2022-04-16 15:43:19 +02:00

lint-include-guards.py

Convert lint-include-guards.sh to python

2022-04-20 09:52:58 -04:00

lint-includes.py

http: replace boost::split with SplitString

2022-05-04 07:34:48 +02:00

lint-locale-dependence.py

test: Add strerror to locale-dependence linter

2022-04-28 10:24:06 +02:00

lint-logs.py

logging: add LogPrintfCategory to log unconditionally with category

2022-06-08 14:02:54 +02:00

lint-python-dead-code.py

lint: Convert Python dead code linter to Python

2022-04-06 00:55:22 +02:00

lint-python-mutable-default-parameters.py

Converted lint-python-mutable-default-parameters.sh to python

2022-04-08 11:53:47 -04:00

lint-python-utf8-encoding.py

lint: Convert lint-python-utf8-encoding.sh to Python

2022-04-21 23:26:45 +02:00

lint-python.py

lint: Convert Python linter to Python

2022-04-18 00:55:06 +02:00

lint-shell-locale.py

lint: convert shell locale linter test to Python

2022-04-20 14:37:52 +00:00

lint-shell.py

test: port 'lint-shell.sh' to python

2022-05-05 08:44:08 -05:00

lint-spelling.py

lint: convert spell check lint test to python

2022-04-06 00:16:01 +02:00

lint-submodule.py

lint: convert submodule linter test to Python

2022-04-20 05:21:13 +00:00

lint-tests.py

Converted lint-tests.sh to python

2022-04-15 10:10:03 -04:00

lint-whitespace.py

lint: Convert lint-whitespace.sh to Python

2022-04-16 15:53:15 +02:00

README.md

test: rename lint-all.py to all-lint.py

2022-06-07 10:22:45 +02:00

run-lint-format-strings.py

Move lint script and data file to avoid lint- prefix

2022-04-04 16:58:07 +02:00

spelling.ignore-words.txt

doc: add desig to ignore-words

2022-06-09 09:16:34 -03:00

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

Usage: test/lint/git-subtree-check.sh [-r] DIR [COMMIT]
       test/lint/git-subtree-check.sh -?

DIR is the prefix within the repository to check.
COMMIT is the commit to check, if it is not provided, HEAD will be used.
-r checks that subtree commit is present in repository.

To do a full check with -r, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue-subtree.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/bitcoin-core/crc32c-subtree.git (branch bitcoin-fork)
for src/minisketch: https://github.com/sipa/minisketch.git (branch master)

To do so, add the upstream repository as remote:

git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git

all-lint.py

Calls other scripts with the lint- prefix.