mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-11 22:43:06 +02:00
This commit ensures the `TorControlConnection::m_message` buffer doesn't
grow unbounded and exhaust memory, by limiting the number of lines
handled by `TorControlConnection::ProcessBuffer()` to `MAX_LINE_COUNT =
1000`. Now the most memory that can be occupied by `m_message` is on the
order of `MAX_LINE_LENGTH * MAX_LINE_COUNT= 100MB`
Although this is not compliant with the tor control protocol in general,
where commands like `GETINFO ns/all` will likely return thousands of
lines, it is more than sufficient for handling the replies from the
commands that are used by a node:
`AUTHENTICATE`: 1 line:
The server responds with 250 OK on success or 515 Bad
authentication if the authentication cookie is incorrect. Tor closes
the connection on an authentication failure.
https://spec.torproject.org/control-spec/commands.html#authenticate
`GETINFO net/listener/socks`: 2 lines
A quoted, space-separated list of the locations where Tor is
listening...
https://spec.torproject.org/control-spec/commands.html#getinfo
`AUTHCHALLENGE SAFECOOKIE`: 1 line
If the server accepts the command, the server reply format is:
```
"250 AUTHCHALLENGE" SP "SERVERHASH=" ServerHash SP "SERVERNONCE="
ServerNonce CRLF
```
https://spec.torproject.org/control-spec/commands.html#authenticate
`PROTOCOLINFO`: 4-5 lines
The server reply format is:
```
250-PROTOCOLINFO" SP PIVERSION CRLF \*InfoLine "250 OK" CRLF
InfoLine = AuthLine / VersionLine / OtherLine
```
(https://spec.torproject.org/control-spec/commands.html#protocolinfo)
`ADD_ONION`: 2-3 lines for Bitcoin Core's tor control client.
The server reply format is:
```
"250-ServiceID=" ServiceID CRLF
["250-PrivateKey=" KeyType ":" KeyBlob CRLF]
*("250-ClientAuth=" ClientName ":" ClientBlob CRLF)
"250 OK" CRLF
```
...
The server response will only include a private key if the server
was requested to generate a new keypair
...
If client authorization is enabled using the “BasicAuth” flag (which
is v2 only), the service will not be accessible to clients without
valid authorization data (configured with the “HidServAuth” option).
The list of authorized clients is specified with one or more
“ClientAuth” parameters. If “ClientBlob” is not specified for a
client, a new credential will be randomly generated and returned."
https://spec.torproject.org/control-spec/commands.html#add_onion
We don't set the `BasicAuth` flag, so the response will not include any
`ClientAuthLines`.
269 lines
9.6 KiB
Python
Executable File
269 lines
9.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test torcontrol functionality with a mock Tor control server."""
|
|
from contextlib import contextmanager
|
|
import socket
|
|
import threading
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
ensure_for,
|
|
p2p_port,
|
|
)
|
|
|
|
|
|
class MockTorControlServer:
|
|
def __init__(self, port, manual_mode=False):
|
|
self.port = port
|
|
self.sock = None
|
|
self.conn = None
|
|
self.running = False
|
|
self.thread = None
|
|
self.received_commands = []
|
|
self.manual_mode = manual_mode
|
|
self.conn_ready = threading.Event()
|
|
|
|
def start(self):
|
|
self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
|
|
self.sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
|
|
self.sock.settimeout(1.0)
|
|
self.sock.bind(('127.0.0.1', self.port))
|
|
self.sock.listen(1)
|
|
self.running = True
|
|
self.thread = threading.Thread(target=self._serve)
|
|
self.thread.daemon = True
|
|
self.thread.start()
|
|
|
|
def stop(self):
|
|
self.running = False
|
|
if self.conn:
|
|
self.conn.close()
|
|
if self.sock:
|
|
self.sock.close()
|
|
if self.thread:
|
|
self.thread.join(timeout=5)
|
|
|
|
def _serve(self):
|
|
while self.running:
|
|
try:
|
|
self.conn, _ = self.sock.accept()
|
|
self.conn.settimeout(1.0)
|
|
self.conn_ready.set()
|
|
self._handle_connection(self.conn)
|
|
except socket.timeout:
|
|
continue
|
|
except OSError:
|
|
break
|
|
|
|
def _handle_connection(self, conn):
|
|
try:
|
|
buf = b""
|
|
while self.running:
|
|
try:
|
|
data = conn.recv(1024)
|
|
if not data:
|
|
break
|
|
buf += data
|
|
while b"\r\n" in buf:
|
|
line, buf = buf.split(b"\r\n", 1)
|
|
command = line.decode('utf-8').strip()
|
|
if command:
|
|
self.received_commands.append(command)
|
|
if not self.manual_mode:
|
|
response = self._get_response(command)
|
|
conn.sendall(response.encode('utf-8'))
|
|
except socket.timeout:
|
|
continue
|
|
finally:
|
|
conn.close()
|
|
|
|
def send_raw(self, data):
|
|
if self.conn:
|
|
self.conn.sendall(data.encode('utf-8'))
|
|
|
|
def _get_response(self, command):
|
|
if command == "PROTOCOLINFO 1":
|
|
return (
|
|
"250-PROTOCOLINFO 1\r\n"
|
|
"250-AUTH METHODS=NULL\r\n"
|
|
"250-VERSION Tor=\"0.1.2.3\"\r\n"
|
|
"250 OK\r\n"
|
|
)
|
|
elif command == "AUTHENTICATE":
|
|
return "250 OK\r\n"
|
|
elif command.startswith("ADD_ONION"):
|
|
return (
|
|
"250-ServiceID=testserviceid1234567890123456789012345678901234567890123456\r\n"
|
|
"250 OK\r\n"
|
|
)
|
|
elif command.startswith("GETINFO"):
|
|
return "250-net/listeners/socks=\"127.0.0.1:9050\"\r\n250 OK\r\n"
|
|
else:
|
|
return "510 Unrecognized command\r\n"
|
|
|
|
|
|
class TorControlTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def next_port(self):
|
|
self._port_counter = getattr(self, '_port_counter', 0) + 1
|
|
return p2p_port(self.num_nodes + self._port_counter)
|
|
|
|
def restart_with_mock(self, mock_tor):
|
|
mock_tor.start()
|
|
self.restart_node(0, extra_args=[
|
|
f"-torcontrol=127.0.0.1:{mock_tor.port}",
|
|
"-listenonion=1",
|
|
"-debug=tor",
|
|
])
|
|
|
|
# Wait for connection and PROTOCOLINFO command
|
|
mock_tor.conn_ready.wait(timeout=10)
|
|
self.wait_until(lambda: len(mock_tor.received_commands) >= 1, timeout=10)
|
|
assert_equal(mock_tor.received_commands[0], "PROTOCOLINFO 1")
|
|
|
|
@contextmanager
|
|
def expect_disconnect(self, expect, mock_tor):
|
|
initial_len = len(mock_tor.received_commands)
|
|
yield
|
|
|
|
if expect:
|
|
# Expect to receive a PROTOCOLINFO 1 on reconnect, bumping the received
|
|
# commands length.
|
|
self.wait_until(lambda: len(mock_tor.received_commands) == initial_len + 1)
|
|
assert_equal(mock_tor.received_commands[initial_len], "PROTOCOLINFO 1")
|
|
else:
|
|
# No disconnect, so no reconnect message
|
|
ensure_for(duration=2, f=lambda: len(mock_tor.received_commands) == initial_len)
|
|
|
|
def test_basic(self):
|
|
self.log.info("Test Tor control basic functionality")
|
|
|
|
mock_tor = MockTorControlServer(self.next_port())
|
|
self.restart_with_mock(mock_tor)
|
|
|
|
# Waiting for Tor control commands
|
|
self.wait_until(lambda: len(mock_tor.received_commands) >= 4, timeout=10)
|
|
|
|
# Verify expected protocol sequence
|
|
assert_equal(mock_tor.received_commands[0], "PROTOCOLINFO 1")
|
|
assert_equal(mock_tor.received_commands[1], "AUTHENTICATE")
|
|
assert_equal(mock_tor.received_commands[2], "GETINFO net/listeners/socks")
|
|
assert mock_tor.received_commands[3].startswith("ADD_ONION ")
|
|
assert "PoWDefensesEnabled=1" in mock_tor.received_commands[3]
|
|
|
|
# Clean up
|
|
mock_tor.stop()
|
|
|
|
def test_partial_data(self):
|
|
self.log.info("Test that partial Tor control responses are buffered until complete")
|
|
|
|
mock_tor = MockTorControlServer(self.next_port(), manual_mode=True)
|
|
self.restart_with_mock(mock_tor)
|
|
|
|
# Send partial response (no \r\n on last line)
|
|
mock_tor.send_raw(
|
|
"250-PROTOCOLINFO 1\r\n"
|
|
"250-AUTH METHODS=NULL\r\n"
|
|
"250 OK"
|
|
)
|
|
|
|
# Verify AUTHENTICATE is not sent
|
|
ensure_for(duration=2, f=lambda: len(mock_tor.received_commands) == 1)
|
|
|
|
# Complete the response
|
|
mock_tor.send_raw("\r\n")
|
|
|
|
# Should now process the complete response and send AUTHENTICATE
|
|
self.wait_until(lambda: len(mock_tor.received_commands) >= 2, timeout=5)
|
|
assert_equal(mock_tor.received_commands[1], "AUTHENTICATE")
|
|
|
|
# Clean up
|
|
mock_tor.stop()
|
|
|
|
def test_pow_fallback(self):
|
|
self.log.info("Test that ADD_ONION retries without PoW on 512 error")
|
|
|
|
class NoPowServer(MockTorControlServer):
|
|
def _get_response(self, command):
|
|
if command.startswith("ADD_ONION"):
|
|
if "PoWDefensesEnabled=1" in command:
|
|
return "512 Unrecognized option\r\n"
|
|
else:
|
|
return (
|
|
"250-ServiceID=testserviceid1234567890123456789012345678901234567890123456\r\n"
|
|
"250 OK\r\n"
|
|
)
|
|
return super()._get_response(command)
|
|
|
|
mock_tor = NoPowServer(self.next_port())
|
|
self.restart_with_mock(mock_tor)
|
|
|
|
# Expect: PROTOCOLINFO, AUTHENTICATE, GETINFO, ADD_ONION (with PoW), ADD_ONION (without PoW)
|
|
self.wait_until(lambda: len(mock_tor.received_commands) >= 5, timeout=10)
|
|
|
|
# First ADD_ONION should have PoW enabled
|
|
assert mock_tor.received_commands[3].startswith("ADD_ONION ")
|
|
assert "PoWDefensesEnabled=1" in mock_tor.received_commands[3]
|
|
|
|
# Retry should be ADD_ONION without PoW
|
|
assert mock_tor.received_commands[4].startswith("ADD_ONION ")
|
|
assert "PoWDefensesEnabled=1" not in mock_tor.received_commands[4]
|
|
|
|
# Clean up
|
|
mock_tor.stop()
|
|
|
|
def test_oversized_line(self):
|
|
mock_tor = MockTorControlServer(self.next_port(), manual_mode=True)
|
|
self.restart_with_mock(mock_tor)
|
|
|
|
MAX_LINE_LENGTH = 100000
|
|
|
|
self.log.info("Test that Tor control does not disconnect with a MAX_LINE_LENGTH line.")
|
|
with self.expect_disconnect(False, mock_tor):
|
|
msg = "250-" + ("A" * (MAX_LINE_LENGTH - 5)) + "\r"
|
|
assert_equal(len(msg), MAX_LINE_LENGTH)
|
|
# The \n is not counted in line length.
|
|
mock_tor.send_raw(msg + "\n")
|
|
|
|
self.log.info("Test that Tor control disconnects with a MAX_LINE_LENGTH + 1 line")
|
|
with self.expect_disconnect(True, mock_tor):
|
|
msg = "250-" + ("A" * (MAX_LINE_LENGTH - 4)) + "\r"
|
|
assert_equal(len(msg), MAX_LINE_LENGTH + 1)
|
|
mock_tor.send_raw(msg + "\n")
|
|
|
|
mock_tor.stop()
|
|
|
|
def test_overmany_lines(self):
|
|
mock_tor = MockTorControlServer(self.next_port(), manual_mode=True)
|
|
self.restart_with_mock(mock_tor)
|
|
|
|
MAX_LINE_COUNT = 1000
|
|
|
|
self.log.info("Test that Tor control does not disconnect on receiving MAX_LINE_COUNT lines.")
|
|
with self.expect_disconnect(False, mock_tor):
|
|
for _ in range(MAX_LINE_COUNT - 1):
|
|
mock_tor.send_raw("250-Continuing\r\n")
|
|
mock_tor.send_raw("250 OK\r\n")
|
|
|
|
self.log.info("Test that Tor control disconnects on receiving MAX_LINE_COUNT + 1 lines.")
|
|
with self.expect_disconnect(True, mock_tor):
|
|
for _ in range(MAX_LINE_COUNT + 1):
|
|
mock_tor.send_raw("250-Continuing\r\n")
|
|
|
|
mock_tor.stop()
|
|
|
|
def run_test(self):
|
|
self.test_basic()
|
|
self.test_partial_data()
|
|
self.test_pow_fallback()
|
|
self.test_oversized_line()
|
|
self.test_overmany_lines()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
TorControlTest(__file__).main()
|