Andrew Chow 6cc136bbd3 Merge bitcoin/bitcoin#27556: wallet: fix deadlock in bdb read write operation ...

69d43905b7 test: add coverage for wallet read write db deadlock (furszy)
12daf6fcdc walletdb: scope bdb::EraseRecords under a single db txn (furszy)
043fcb0b05 wallet: bugfix, GetNewCursor() misses to provide batch ptr to BerkeleyCursor (furszy)

Pull request description:

  Decoupled from #26644 so it can closed in favor of #26715.

  Basically, with bdb, we can't make a write operation while we are traversing the db with the same db handler. These two operations are performed in different txn contexts and cause a deadlock.

  Added coverage by using `EraseRecords()` which is the simplest function that executes this process.

  To replicate it, need bdb support and drop the first commit. The test will run forever.

ACKs for top commit:
  achow101:
    ACK 69d43905b7
  hebasto:
    re-ACK 69d43905b7

Tree-SHA512: b3773be78925f674e962f4a5c54b398a9d0cfe697148c01c3ec0d68281cc5c1444b38165960d219ef3cf1a57c8ce6427f44a876275958d49bbc0808486e19d7d

2023-05-18 11:10:05 -04:00

..

rpc

scripted-diff: Use UniValue::find_value method

2023-05-09 18:47:14 +02:00

test

test: add coverage for wallet read write db deadlock

2023-05-15 12:29:38 -03:00

bdb.cpp

wallet: bugfix, GetNewCursor() misses to provide batch ptr to BerkeleyCursor

2023-05-15 12:23:15 -03:00

bdb.h

wallet: bugfix, GetNewCursor() misses to provide batch ptr to BerkeleyCursor

2023-05-15 12:23:15 -03:00

coincontrol.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coincontrol.h

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coinselection.cpp

Merge bitcoin/bitcoin#27419: move-only: Extract common/args from util/system

2023-04-21 11:19:08 +01:00

coinselection.h

Merge bitcoin/bitcoin#26720: wallet: coin selection, don't return results that exceed the max allowed weight

2023-04-20 16:33:39 -04:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

db.h

wallet: Move DummyDatabase to salvage

2023-05-03 10:45:10 -04:00

dump.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

bumpfee: enable send coins back to yourself

2023-04-15 10:44:50 -03:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

load.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

load.h

…

receive.cpp

…

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

wallet: Move DummyDatabase to salvage

2023-05-03 10:45:10 -04:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h

2023-05-08 13:31:28 -04:00

scriptpubkeyman.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

spend.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

spend.h

…

sqlite.cpp

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

sqlite.h

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

transaction.cpp

…

transaction.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

scripted-diff: Use UniValue::find_value method

2023-05-09 18:47:14 +02:00

wallet.h

Merge bitcoin/bitcoin#27405: util: Use steady clock instead of system clock to measure durations

2023-05-06 12:03:50 +01:00

walletdb.cpp

Merge bitcoin/bitcoin#27556: wallet: fix deadlock in bdb read write operation

2023-05-18 11:10:05 -04:00

walletdb.h

walletdb: Remove unused CreateMockWalletDatabase

2023-05-15 16:14:43 -04:00

wallettool.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

…