mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 23:03:45 +01:00

Files

merge-script 54e406a305 Merge bitcoin/bitcoin#32459 : qt: drop unused watch-only functionality

e8661aac75 wallet: drop watch-only things from interface (Sjors Provoost)
e99188e7da qt: drop unused watch-only functionality (Sjors Provoost)

Pull request description:

  The watch-only functionality in the GUI was only used for legacy wallets. Watch-only descriptor wallets do not use this.

  The only visible changes of this PR should be:
  - dropped "Spendable:" label from the overview tab
  - column width cache is reset

  This PR also removes some unused variables from the interface.

ACKs for top commit:
  davidgumberg:
    Review ACK e8661aac75.
  hebasto:
    ACK e8661aac75, I have reviewed the code and it looks OK. The `src/qt/forms/overviewpage.ui` form was reviewed in Qt Designer.

Tree-SHA512: d7edb0f167e0b934075398a76eddca69890bb36848a918c932b1c2cea85ee87285e876cbfdf1f6dec7adf26b9f405fb558c70bec0c84585c0a9df33c2af78393

2025-05-21 10:13:00 +01:00

chain.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

echo.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

handler.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

init.h

multiprocess: Add -ipcbind option to bitcoin-node

2024-09-06 09:08:10 -04:00

ipc.h

multiprocess: Add IPC connectAddress and listenAddress methods

2024-09-06 09:08:10 -04:00

mining.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

node.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

README.md

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

types.h

refactor: rename BlockKey to BlockRef

2024-09-17 09:14:15 +02:00

wallet.h

Merge bitcoin/bitcoin#32459 : qt: drop unused watch-only functionality

2025-05-21 10:13:00 +01:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.