mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00

Files

MacroFake a1fff275e7 Merge bitcoin/bitcoin#25704 : refactor: Remove almost all validation option globals

aaaa7bd0ba iwyu: Add missing includes (MacroFake)
fa9ebec096 Remove g_parallel_script_checks (MacroFake)
fa7c834b9f Move ::fCheckBlockIndex into ChainstateManager (MacroFake)
fa43188d86 Move ::fCheckpointsEnabled into ChainstateManager (MacroFake)
cccca83099 Move ::nMinimumChainWork into ChainstateManager (MacroFake)
fa29d0b57c Move ::hashAssumeValid into ChainstateManager (MacroFake)
faf44876db Move ::nMaxTipAge into ChainstateManager (MacroFake)

Pull request description:

  It seems preferable to assign globals to a class (in this case `ChainstateManager`), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

ACKs for top commit:
  dergoegge:
    Code review ACK aaaa7bd0ba
  ryanofsky:
    Code review ACK aaaa7bd0ba. No changes since last review, other than rebase
  aureleoules:
    reACK aaaa7bd0ba

Tree-SHA512: 83ec3ba0fb4f1dad95810d4bd4e578454e0718dc1bdd3a794cc4e48aa819b6f5dad4ac4edab3719bdfd5f89cbe23c2740a50fd56c1ff81c99e521c5f6d4e898d

2022-10-26 11:41:57 +02:00

blockfilter.cpp

Require CBlockIndex::GetBlockPos() to hold mutex cs_main

2022-01-25 20:43:12 +01:00

blockfilter.h

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

chainstate.h

test: allow on-disk coins and block tree dbs in tests

2022-09-13 13:31:23 -04:00

logging.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

logging.h

util, refactor: Add UNIQUE_NAME helper macro

2022-02-16 14:59:20 +02:00

mining.cpp

Require callers of AcceptBlockHeader() to perform anti-dos checks

2022-08-29 08:10:35 -04:00

mining.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

net.cpp

net: drop cs_sendProcessing

2022-09-15 14:44:42 +10:00

net.h

Merge bitcoin/bitcoin#25421 : net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods

2022-10-12 15:49:02 -04:00

README.md

doc: Add documentation for new test/lib

2019-11-06 11:56:53 -05:00

script.cpp

fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target

2021-03-30 10:42:45 +02:00

script.h

fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target

2021-03-30 10:42:45 +02:00

setup_common.cpp

Merge bitcoin/bitcoin#25704 : refactor: Remove almost all validation option globals

2022-10-26 11:41:57 +02:00

setup_common.h

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

str.cpp

…

str.h

[test] move string helper functions into test library

2019-11-25 01:33:17 +01:00

transaction_utils.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

transaction_utils.h

scripted-diff: TxoutType C++11 scoped enum class

2020-06-21 06:41:55 -04:00

txmempool.cpp

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

txmempool.h

test: Use C++11 member initializers for TestMemPoolEntryHelper

2022-10-18 17:32:44 +02:00

validation.cpp

Add coinstatsindex_unclean_shutdown test

2022-02-25 16:06:27 -05:00

validation.h

scripted-diff: rename CChainState -> Chainstate

2022-09-09 11:47:27 -04:00

wallet.cpp

refactor: Replace BResult with util::Result

2022-08-03 07:33:01 -04:00

wallet.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).