merge-script 5f45583e43 Merge bitcoin/bitcoin#36077: bugfix: give TxDownloadManager its own RNG ...

80eaa6cabf bugfix: give TxDownloadManager its own RNG (Greg Sanders)

Pull request description:

  TxDownloadManagerImpl retains a reference to PeerManagerImpl::m_rng,
  which is non-thread-safe and guarded by g_msgproc_mutex.

  BlockConnected runs on the validation background thread while holding
  only m_tx_download_mutex. Reconsidering an orphan with multiple
  announcers could therefore use m_rng concurrently with message
  processing.

  Regression introduced in #35986

  Added a regression test on second commit, can remove it from the PR if deemed superfluous.

  This is a Project Loupe find.

ACKs for top commit:
  maflcko:
    review ACK 80eaa6cabf 🐓
  hodlinator:
    ACK 80eaa6cabf
  sedited:
    ACK 80eaa6cabf

Tree-SHA512: 2dbc4a9298bfa1375dc364ead4b1ec74c2ebe54fb7c311180fa06fc32240406be2979a2dd6ae0e7a23b099ddcd63f5c76c126d84a1405fc7eacd337eb009dd88

2026-08-26 14:22:28 +02:00

..

util

…

addition_overflow.cpp

…

addrman.cpp

…

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index_tree.cpp

…

block_index.cpp

…

block_policy_estimator.cpp

fees: move fee_estimates.dat into fees directory

2026-08-20 16:16:08 +01:00

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

cluster_linearize.cpp

…

CMakeLists.txt

test: rename policy estimator tests to block policy estimator tests

2026-08-17 14:38:46 +01:00

cmpctblock.cpp

fuzz: Use ImmediateBackgroundTaskRunner in process_messages

2026-08-20 20:00:13 +02:00

coins_view.cpp

test: Tighten Coin equality and add debug output

2026-08-19 09:42:42 +01:00

coinscache_sim.cpp

…

connman.cpp

…

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

dbwrapper.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

difference_formatter.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

fees: add MemPoolFeeRateEstimator class

2026-08-20 15:15:03 +01:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

util: refactor: Remove deprecated SetMockTime(i64) alias

2026-08-24 12:32:02 +02:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

headerssync.cpp

…

hex.cpp

…

http_request.cpp

refactor: Drastically narrow scope of http_bitcoin namespace and rename it to bitcoin_http

2026-08-25 13:23:15 +02:00

i2p.cpp

…

integer.cpp

…

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

…

merkle.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

…

miniscript.cpp

…

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

…

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

…

p2p_handshake.cpp

…

p2p_headers_presync.cpp

…

p2p_private_broadcast.cpp

…

p2p_transport_serialization.cpp

…

package_eval.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

…

pcp.cpp

…

policy_estimator_io.cpp

test: add mempool estimator i/o fuzz test

2026-08-20 16:37:39 +01:00

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

private_broadcast.cpp

…

process_message.cpp

fuzz: refactor: scope fake clocks to target phases

2026-08-19 20:46:30 +08:00

process_messages.cpp

fuzz: Use ImmediateBackgroundTaskRunner in process_messages

2026-08-20 20:00:13 +02:00

protocol.cpp

…

psbt.cpp

psbt: Remove unused IsNull() methods

2026-08-18 20:30:47 +02:00

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

…

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

string.cpp

…

strprintf.cpp

…

system.cpp

…

threadpool.cpp

…

timeoffsets.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

validation: emit block mempool removal signal from ConnectTip

2026-08-20 16:15:56 +01:00

txdownloadman.cpp

bugfix: give TxDownloadManager its own RNG

2026-08-25 10:37:38 -04:00

txgraph.cpp

…

txorphan.cpp

…

txrequest.cpp

…

util.cpp

…

util.h

…

utxo_snapshot.cpp

fuzz: refactor: scope fake clocks to target phases

2026-08-19 20:46:30 +08:00

utxo_total_supply.cpp

…

validation_load_mempool.cpp

…

vecdeque.cpp

…

versionbits.cpp

…