fanquake 1e9d367d0d Merge bitcoin/bitcoin#28423: kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers ...

d506765199 [refactor] Remove compat.h from kernel headers (TheCharlatan)
36193af47c [refactor] Remove netaddress.h from kernel headers (TheCharlatan)
2b08c55f01 [refactor] Add CChainParams member to CConnman (TheCharlatan)
f0d1d8b35c [refactor] Add missing includes for next commit (TheCharlatan)
534b314a74 kernel: Move MessageStartChars to its own file (TheCharlatan)
9be330b654 [refactor] Define MessageStartChars as std::array (TheCharlatan)
37e2b01113 [refactor] Allow std::array<std::byte, N> in serialize.h (MarcoFalke)

Pull request description:

  This removes the non-consensus critical `protocol.h` and `netaddress.h` headers from the kernel headers. With this patch, they are no longer required to include in order to use the libbitcoinkernel library. This also allows for the removal of the `compat.h` header from the kernel headers.

  As an added future benefit it also reduces the number of of kernel headers that include the platform specific `bitcoin-config.h`.

  For those interested, the currently required kernel headers can be inspected visually with the [sourcetrail](https://github.com/CoatiSoftware/Sourcetrail) tool by looking at the required includes of `bitcoin-chainstate.cpp`.

  ---

  This is part of the [libbitcoinkernel project](https://github.com/bitcoin/bitcoin/issues/27587), namely its stage 1 step 3: Decouple most non-consensus headers from libbitcoinkernel.

ACKs for top commit:
  stickies-v:
    re-ACK d506765
  hebasto:
    ACK d506765199.
  ajtowns:
    utACK d506765199
  MarcoFalke:
    lgtm ACK d506765199 🍛

Tree-SHA512: 6f90ea510a302c2927e84d16900e89997c39b8ff3ce9d4effeb8a134bd29cc52bd9e81e51aaa11f7496bad00025b78a58b88c5a9e0bb3f4ebbe9a76309215fb7

2023-09-14 11:11:38 +01:00

..

util

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

addition_overflow.cpp

…

addrman.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

bitdeque.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

block_header.cpp

…

block.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

scripted-diff: Rename CBufferedFile to BufferedFile

2023-09-12 12:55:29 +02:00

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

fuzz: coins_view: remove an incorrect assertion

2023-08-11 18:11:07 +02:00

coinscache_sim.cpp

…

connman.cpp

[refactor] Add CChainParams member to CConnman

2023-09-12 22:51:45 +02:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector

2023-08-17 15:31:56 -04:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

crypto: require key on ChaCha20 initialization

2023-08-17 15:31:27 -04:00

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector

2023-08-17 15:31:56 -04:00

crypto.cpp

refactor: use Span for SipHash::Write

2023-07-17 13:27:46 +02:00

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

[refactor] Add missing includes for next commit

2023-09-12 22:51:42 +02:00

deserialize.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

fuzz: Accept options in FUZZ_TARGET macro

2023-07-13 20:37:05 +02:00

fuzz.h

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

FuzzedDataProvider.h

fuzz: Bump FuzzedDataProvider.h

2023-07-17 09:39:52 +02:00

golomb_rice.cpp

refactor: use Span for SipHash::Write

2023-07-17 13:27:46 +02:00

headerssync.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

integer.cpp

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

key_io.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

key.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

Merge bitcoin/bitcoin#27746: Rework validation logic for assumeutxo

2023-07-31 16:18:20 -04:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

mini_miner.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

miniscript.cpp

miniscript: make GetStackSize independent of P2WSH context

2023-08-25 11:56:09 +02:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

netaddress.cpp

net, refactor: pass reference for peer address in GetReachabilityFrom

2023-06-05 11:02:47 -04:00

netbase_dns_lookup.cpp

p2p, refactor: return std::optional<CNetAddr> in LookupHost

2023-05-26 13:41:07 -03:00

node_eviction.cpp

…

p2p_transport_serialization.cpp

net: do not use send buffer to store/cache garbage

2023-09-10 16:12:27 -04:00

parse_hd_keypath.cpp

Switch hardened derivation marker to h in descriptors

2023-04-04 18:33:08 +02:00

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

refactor: Revert addition of univalue sighash string check

2023-07-27 09:36:05 +02:00

partially_downloaded_block.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

policy_estimator_io.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

policy_estimator.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

poolresource.cpp

Add PoolResource fuzzer

2023-03-23 19:38:38 +01:00

pow.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager

2023-08-18 12:52:30 -04:00

process_messages.cpp

net: move message conversion to wire bytes from PushMessage to SocketSendData

2023-08-23 20:13:49 -04:00

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

rolling_bloom_filter.cpp

…

rpc.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

script_assets_test_minimizer.cpp

fuzz: Accept options in FUZZ_TARGET macro

2023-07-13 20:37:05 +02:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

script_sign.cpp

Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization

2023-09-07 11:34:34 +01:00

script.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

socks5.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

span.cpp

…

spanparsing.cpp

…

string.cpp

Merge bitcoin/bitcoin#27576: kernel: Remove args, settings, chainparams, chainparamsbase from kernel library

2023-06-09 14:58:49 -04:00

strprintf.cpp

…

system.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

timedata.cpp

…

torcontrol.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

transaction.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

txorphan.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

txrequest.cpp

…

util.cpp

Merge bitcoin/bitcoin#28361: fuzz: add ConstructPubKeyBytes util function

2023-09-07 16:22:16 +01:00

util.h

Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization

2023-09-07 11:34:34 +01:00

utxo_snapshot.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

utxo_total_supply.cpp

[fuzz] Only check duplicate coinbase script when block was valid

2023-06-03 15:37:11 +02:00

validation_load_mempool.cpp

refactor: Add and use kernel::ImportMempoolOptions

2023-08-07 11:32:34 +02:00

versionbits.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00