mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-11-18 09:57:43 +01:00
6a167325f0
7ccdd741fetest: fix importmulti/importdescriptors assertion (Jon Atack)19d888ce40rpc: move WALLET_FLAG_CAVEATS to the compilation unit of its caller (Jon Atack)01df011ca2doc: release note for wallet RPCs "warning" field deprecation (Jon Atack)9ea8b3739atest: createwallet "warning" field deprecation test (Jon Atack)645d7f75acrpc: deprecate "warning" field in {create,load,unload,restore}wallet (Jon Atack)2f4a926e95test: add test coverage for "warnings" field in createwallet (Jon Atack)4a1e479ca6rpc: add "warnings" field to RPCs {create,load,unload,restore}wallet (Jon Atack)079d8cdda8rpc: extract wallet "warnings" fields to a util helper (Jon Atack)f73782a903doc: fix/improve warning helps in {create,load,unload,restore}wallet (Jon Atack) Pull request description: Based on discussion and concept ACKed in #27138, add a `warnings` field to RPCs createwallet, loadwallet, unloadwallet, and restorewallet as a JSON array of strings to replace the `warning` string field in these 4 RPCs. The idea is to more gracefully handle multiple warning messages and for consistency with other wallet RPCs. Then, deprecate the latter fields, which represent all the remaining RPC `warning` fields. The first commitf73782a903implements https://github.com/bitcoin/bitcoin/pull/27138#issuecomment-1474789198 as an alternative to #27138. One of those two could potentially be backported to our currently supported releases. ACKs for top commit: achow101: ACK7ccdd741fe1440000bytes: utACK7ccdd741fevasild: ACK7ccdd741fepinheadmz: re-ACK7ccdd741feTree-SHA512: 314e0a4c41fa383d95e2817bfacf359d449e460529d235c3eb902851e2f4eacbabe646d9a5a4beabc4964cdfabf6397ed8301366a58d344a2f787f83b75e9d64