Samuel Dobson ec79b5f86b Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction ...

2a78098098 wallet: Make sure no WalletDescriptor members are uninitialized after construction (practicalswift)
ff046aeeba wallet: Make sure no DescriptorScriptPubKeyMan members are uninitialized after construction (practicalswift)

Pull request description:

  This is a small folllow-up to #16528 ("Native Descriptor Wallets using DescriptorScriptPubKeyMan") which was merged in to `master` a couple of hours ago.

  Make sure no `DescriptorScriptPubKeyMan` or `WalletDescriptor` members are left uninitialized after construction.

  Before this change `bool m_internal` was left uninitialized when using the `DescriptorScriptPubKeyMan(WalletStorage&, WalletDescriptor&)` ctor.

  The same goes for the now initialized integers which were left uninitialized when using the `WalletDescriptor()` ctor.

ACKs for top commit:
  instagibbs:
    utACK  2a78098098
  fjahr:
    Code review ACK 2a78098098
  Sjors:
    utACK 2a78098
  achow101:
    ACK 2a78098098
  brakmic:
    Code review ACK 2a78098098
  meshcollider:
    utACK 2a78098098

Tree-SHA512: c98e035268fdc7f65a423b73ac0cf010b0ef7c5e679b3cf170c1813efac8ab5c657dcbaf43c746770bea59e4772bfefe4caa834f1175260c39c7f35d92946ba5

2020-05-05 15:56:04 +12:00

..

test

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

db.h

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

Merge #15761: Replace -upgradewallet startup option with upgradewallet RPC

2020-04-19 07:06:42 -04:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

load.h

…

rpcdump.cpp

[wallet] Remove locked_chain from CWallet, its RPCs and tests

2020-04-30 14:41:24 -04:00

rpcwallet.cpp

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

rpcwallet.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

scriptpubkeyman.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

scriptpubkeyman.h

Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction

2020-05-05 15:56:04 +12:00

wallet.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

wallet.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

walletdb.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

walletdb.h

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

wallettool.cpp

wallet: Report full error message in wallettool

2020-05-01 07:39:35 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

wallet: Make sure no WalletDescriptor members are uninitialized after construction

2020-04-27 14:20:26 +00:00