mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
a30ef6b91f
fa98d44951ci: Rewrite broken wrap-valgrind.sh to .py (MarcoFalke)faf7e38973ci: refactor: Avoid warning: INSTALL_BCC_TRACING_TOOLS: unbound variable (MarcoFalke) Pull request description: The first commit fixes an error about `INSTALL_BCC_TRACING_TOOLS` being unbound. The second commit rewrites the wrap-valgrind Bash script to Python to fix the shellcheck SC2044 violation. Without this, the script would fail in CI when a path with spaces was used: ``` ... + /ci_container_base/ci/test/wrap-valgrind.sh Wrap /ci_container_base/ci/scratch_ ... mv: cannot stat '/ci_container_base/ci/scratch_': No such file or directory Wrap ₿🧪_/out/bin/bitcoin ... mv: cannot stat '₿🧪_/out/bin/bitcoin': No such file or directory /ci_container_base/ci/test/wrap-valgrind.sh: line 14: ₿🧪_/out/bin/bitcoin: No such file or directory /ci_container_base/ci/test/wrap-valgrind.sh: line 15: ₿🧪_/out/bin/bitcoin: No such file or directory chmod: cannot access '₿🧪_/out/bin/bitcoin': No such file or directory ACKs for top commit: fanquake: ACKfa98d44951- tested both on x86_64 hebasto: ACKfa98d44951, tested on Ubuntu 26.04. I also verified the actual content of the created wrappers. Tree-SHA512: fd9ccdd08a3af3aa9431eef29e17da0d785c7fe57fd0bfc9a6afdd979dc8860f4f9f0153ba3bb4b516cdec7ef0e071b846fddc1f2d28395cbe9356d2e9c55fb7