merge-script de925455c8 Merge bitcoin/bitcoin#35141: fuzz: apply node context reset pattern to p2p_handshake ...

dfe5d6a81d fuzz: apply node context reset pattern to p2p_handshake (frankomosh)

Pull request description:

  Follow-up to #34302. Applies the node context reset pattern from fabf8d1 to `p2p_handshake`.

  Previous code pattern created local `AddrMan` and `node::Warnings` objects, and passed them to `PeerManager::make`. `connman` was left holding a dangling `reference_wrapper<AddrMan>` across iterations, since the local objects destruct at iteration end while `connman` is global.

  Like in fabf8d1 , reset and reinstall `node.addrman` and `node.peerman` on each iteration. This PR also removes `includes` made unused by this or prior refactors.

ACKs for top commit:
  nervana21:
    tACK dfe5d6a81d
  maflcko:
    review ACK dfe5d6a81d 🦏
  sedited:
    ACK dfe5d6a81d

Tree-SHA512: 141ddec03c6d37f76a3b2d94701d18c851e85ea74e57716abb69ecc955d30371e342c6e267d2669ad853fe2d95fb77dd2fb506e4233ae3a88501d59ee1bbae30

2026-05-23 13:11:28 +02:00

..

util

iwyu, doc: Document IWYU pragma: export for <threadsafety.h>

2026-03-20 15:37:51 +00:00

addition_overflow.cpp

…

addrman.cpp

fuzz: Use time helpers in node_eviction

2026-03-25 16:55:18 +01:00

asmap_direct.cpp

refactor: Simplify Interpret asmap function

2026-01-20 23:59:43 +01:00

asmap.cpp

refactor: Use span instead of vector for data in util/asmap

2026-01-20 23:59:41 +01:00

autofile.cpp

…

banman.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

base_encode_decode.cpp

psbt: Remove default constructor

2026-04-29 14:51:47 -07:00

bech32.cpp

string: replace AsciiCaseInsensitiveKeyEqual with CaseInsensitiveEqual

2026-04-08 16:08:54 -04:00

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index_tree.cpp

Change CChain::FindFork() to take ref

2026-04-20 08:55:51 +02:00

block_index.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

block.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

validation: remove BLOCK_FAILED_MASK

2026-02-17 21:40:46 +05:30

checkqueue.cpp

…

cluster_linearize.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

CMakeLists.txt

Merge bitcoin/bitcoin#34887: fuzz: target CDBWrapper

2026-05-21 15:03:49 +01:00

cmpctblock.cpp

Merge bitcoin/bitcoin#34860: mining: always pad scriptSig at low heights, drop include_dummy_extranonce

2026-05-17 13:26:23 -04:00

coins_view.cpp

coins: add explicit CoinsViewEmpty noop backend

2026-04-08 22:36:13 +02:00

coinscache_sim.cpp

test: fix P2SH output in coins cache fuzz

2026-05-06 09:39:07 +02:00

connman.cpp

fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness

2026-05-05 10:53:04 +03:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

dbwrapper.cpp

test: add fuzz harness for CDBWrapper

2026-05-20 11:03:36 -04:00

decode_tx.cpp

…

descriptor_parse.cpp

test: Test that key expression indexes match key count

2026-02-02 15:20:47 -08:00

deserialize.cpp

psbt: Remove default constructor

2026-04-29 14:51:47 -07:00

difference_formatter.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

feeratediagram.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

fees.cpp

wallet, rpc:remove settxfee and paytxfee

2026-02-13 10:52:25 +01:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

test: Replace DEBUG_LOG_OUT with -printtoconsole=1

2026-03-26 14:41:57 +01:00

fuzz.h

…

FuzzedDataProvider.h

fuzz: pull latest FuzzedDataProvider.h from upstream

2026-01-31 08:45:10 +03:00

golomb_rice.cpp

…

headerssync.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

qa: Remove all instances of remove_all except test cleanup

2026-03-24 16:03:02 -07:00

integer.cpp

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

locale.cpp

…

merkle.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

fuzz: Remove unused g_setup pointers

2026-03-25 13:51:01 +01:00

miniscript.cpp

miniscript: Using Func and Expr when parsing keys, hashes, and locktimes

2026-02-02 15:20:51 -08:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

refactor: Use NodeClock::time_point for m_connected

2026-04-13 09:49:13 +02:00

overflow.cpp

…

p2p_handshake.cpp

fuzz: apply node context reset pattern to p2p_handshake

2026-04-21 11:02:43 +03:00

p2p_headers_presync.cpp

fuzz: mine blocks and send headers for them in cmpctblock harness

2026-04-27 11:36:19 -04:00

p2p_transport_serialization.cpp

refactor: Use NodeClock::time_point for CNetMessage::m_time

2026-03-31 09:48:06 +02:00

package_eval.cpp

mining: drop unused include_dummy_extranonce option

2026-05-13 18:27:48 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

pcp.cpp

IWYU fixes

2026-05-16 03:36:51 +10:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

mining: drop unused include_dummy_extranonce option

2026-05-13 18:27:48 +02:00

process_messages.cpp

mining: drop unused include_dummy_extranonce option

2026-05-13 18:27:48 +02:00

protocol.cpp

…

psbt.cpp

fuzz: Enforce additional version invariants in PSBT fuzzer

2026-04-29 15:04:22 -07:00

random.cpp

…

rbf.cpp

Merge bitcoin/bitcoin#34669: feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-04-30 11:35:53 -07:00

rolling_bloom_filter.cpp

…

rpc.cpp

psbt: Remove default constructor

2026-04-29 14:51:47 -07:00

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

fuzz: remove redundant CScript method calls from script harness

2026-04-20 21:18:03 -03:00

script_parsing.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

script_sigcache.cpp

…

script_sign.cpp

refactor: use SignOptions for MutableTransactionSignatureCreator

2026-04-28 17:43:03 +02:00

script.cpp

fuzz: remove redundant CScript method calls from script harness

2026-04-20 21:18:03 -03:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

span.cpp

…

string.cpp

ArgsManager: support command-specific options

2026-04-22 16:45:31 +10:00

strprintf.cpp

…

system.cpp

tests: Add some fuzz test coverage for command-specific args

2026-04-22 17:58:25 +10:00

threadpool.cpp

threadpool: make Submit return Expected instead of throwing

2026-02-17 15:02:40 -05:00

timeoffsets.cpp

…

torcontrol.cpp

fuzz: Improve torcontrol fuzz test

2026-04-03 22:00:29 +02:00

transaction.cpp

coins: add explicit CoinsViewEmpty noop backend

2026-04-08 22:36:13 +02:00

tx_in.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_out.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_pool.cpp

mining: drop unused include_dummy_extranonce option

2026-05-13 18:27:48 +02:00

txdownloadman.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

txgraph.cpp

clusterlin: adopt STL ranges algorithms (refactor)

2026-02-27 08:38:01 -05:00

txorphan.cpp

fuzz: Fix txorphan timeout by limiting block weight

2026-05-14 12:32:04 +01:00

txrequest.cpp

…

util.cpp

fuzz: Use time helpers in node_eviction

2026-03-25 16:55:18 +01:00

util.h

Merge bitcoin/bitcoin#21283: Implement BIP 370 PSBTv2

2026-05-05 14:43:28 +02:00

utxo_snapshot.cpp

Merge bitcoin/bitcoin#31449: coins,refactor: Reduce getblockstats RPC UTXO overhead estimation

2026-04-20 15:52:45 -07:00

utxo_total_supply.cpp

mining: drop unused include_dummy_extranonce option

2026-05-13 18:27:48 +02:00

validation_load_mempool.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

vecdeque.cpp

…

versionbits.cpp

refactor: Enable -Wswitch in exhaustive switch

2026-03-13 09:02:09 +01:00