highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-18 22:35:39 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
a42923ce21870e7285252b32c4e4cb300fae1e1e
bitcoin/src
History
Samuel Dobson a42923ce21 Merge bitcoin/bitcoin#23348: rpc, wallet: Do not return "keypoololdest" for blank descriptor wallets 
ee03c782ba wallet: Make GetOldestKeyPoolTime return nullopt for blank wallets (Hennadii Stepanov)
3e4f069d23 wallet, refactor: Make GetOldestKeyPoolTime return type std::optional (Hennadii Stepanov)

Pull request description:

  The "keypoololdest" field in the `getwalletinfo` RPC response should be used for legacy wallets only.

  Th current implementation (04437ee721) assumes that `CWallet::GetOldestKeyPoolTime()` always return `0` for descriptor wallets. This assumption is wrong for _blank_ descriptor wallets, when `m_spk_managers` is empty. As a result:
  ```
  $ src/bitcoin-cli -signet -rpcwallet=211024-d-DPK getwalletinfo
  {
    "walletname": "211024-d-DPK",
    "walletversion": 169900,
    "format": "sqlite",
    "balance": 0.00000000,
    "unconfirmed_balance": 0.00000000,
    "immature_balance": 0.00000000,
    "txcount": 0,
    "keypoololdest": 9223372036854775807,
    "keypoolsize": 0,
    "keypoolsize_hd_internal": 0,
    "paytxfee": 0.00000000,
    "private_keys_enabled": false,
    "avoid_reuse": false,
    "scanning": false,
    "descriptors": true
  }
  ```

  This PR fixes this issue with direct checking of the `WALLET_FLAG_DESCRIPTORS` flag.

ACKs for top commit:
  lsilva01:
    re-ACK ee03c78
  stratospher:
    ACK ee03c78.
  meshcollider:
    Code review ACK ee03c782ba

Tree-SHA512: 9852f9f8ed5c08c07507274d7714f039bbfda66da6df65cf98f67bf11a600167d0f7f872680c95775399477f4df9ba9fce80ec0cbe0adb7f2bb33c3bd65b15df
2021-11-22 17:08:26 +13:00
..
bench
doc: Fix incorrect C++ named args
2021-11-17 09:25:14 +01:00
common
scripted-diff: Move bloom to src/common
2021-10-05 11:10:37 +02:00
compat
compat: remove glibc_compat.cpp
2021-09-10 11:18:58 +08:00
config
…
consensus
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
crc32c
Update crc32c subtree
2021-09-29 14:10:29 +02:00
crypto
Fix K1/K2 use in the comments in ChaCha20-Poly1305 AEAD
2021-10-20 11:54:03 +05:30
index
Fix outdated comments referring to ::ChainActive()
2021-10-12 14:36:51 +13:00
init
Merge bitcoin/bitcoin#23006: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations
2021-10-26 15:54:52 +01:00
interfaces
Merge bitcoin/bitcoin#23499: multiprocess: Add interfaces::Node::broadCastTransaction method
2021-11-16 08:42:21 +01:00
ipc
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
leveldb
…
logging
log, timer: add LOG_TIME_MILLIS_WITH_CATEGORY_MSG_ONCE macro
2021-10-05 17:28:02 +02:00
minisketch
Merge commit 'b6487dc4ef47ec9ea894eceac25f37d0b806f8aa' as 'src/minisketch'
2021-10-21 09:36:07 +08:00
node
Merge bitcoin/bitcoin#23491: scripted-diff: Move minisketchwrapper to src/node
2021-11-16 16:09:25 +08:00
policy
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
primitives
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
qt
Merge bitcoin-core/gui#319: Paste button in Open URI dialog
2021-11-21 23:46:21 +02:00
rpc
doc: Fix incorrect C++ named args
2021-11-17 09:25:14 +01:00
script
doc: Pick better named args for MutableTransactionSignatureCreator
2021-11-16 13:38:12 +01:00
secp256k1
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
support
refactor: remove references to deprecated values under std::allocator
2021-10-20 18:36:40 -04:00
test
doc: Fix incorrect C++ named args
2021-11-17 09:25:14 +01:00
univalue
Update univalue subtree to latest upstream
2021-10-11 20:45:56 +08:00
util
util: Add missing fstatfs to syscall sandbox
2021-11-19 17:18:59 +01:00
wallet
Merge bitcoin/bitcoin#23348: rpc, wallet: Do not return "keypoololdest" for blank descriptor wallets
2021-11-22 17:08:26 +13:00
zmq
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
.clang-format
Use c++17 in clang-format
2021-11-12 11:46:34 +01:00
.clang-tidy
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
addrdb.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
addrdb.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
addrman_impl.h
Merge bitcoin/bitcoin#22872: log: improve checkaddrman logging with duration in milliseconds
2021-11-10 17:38:45 +01:00
addrman.cpp
Merge bitcoin/bitcoin#22872: log: improve checkaddrman logging with duration in milliseconds
2021-11-10 17:38:45 +01:00
addrman.h
[addrman] Remove AddrMan friends
2021-11-09 17:09:50 +00:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.cpp
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
banman.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
base58.cpp
refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)
2021-01-31 17:35:16 +01:00
base58.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
Add references for the generator/constant used in Bech32(m)
2021-08-20 15:49:50 -04:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-cli.cpp
cli: hoist networks class data members to a constant
2021-11-11 13:14:01 +01:00
bitcoin-tx-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-tx.cpp
bitcoin-tx: Reject non-integral and out of range multisig numbers
2021-10-12 12:45:55 +02:00
bitcoin-util-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-util.cpp
refactor: Pass grind args vector as const reference
2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-wallet.cpp
Merge bitcoin/bitcoin#22766: refactor: Clarify and disable unused ArgsManager flags
2021-11-01 11:25:42 +08:00
bitcoind-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoind.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
blockencodings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockencodings.h
…
blockfilter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockfilter.h
…
chain.cpp
…
chain.h
Merge bitcoin/bitcoin#13875: [doc] nChainTx needs to become a 64-bit earlier due to SegWit
2021-10-20 15:52:08 +02:00
chainparams.cpp
Use absolute FQDN for DNS seed domains
2021-10-14 17:49:52 +05:30
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
scripted-diff: disable unimplemented ArgsManager BOOL/INT/STRING flags
2021-10-25 10:44:17 -04:00
chainparamsbase.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsseeds.h
contrib, p2p: update I2P hardcoded seeds
2021-07-30 11:03:44 +02:00
checkqueue.h
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
clientversion.cpp
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
clientversion.h
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
refactor: Use CPubKey vector constructor where possible
2021-05-04 06:53:32 +02:00
compressor.h
…
core_io.h
rpc: Add level 3 verbosity to getblock RPC call.
2021-10-05 10:42:34 +02:00
core_memusage.h
…
core_read.cpp
bitcoin-tx: Avoid treating overflow as OP_0
2021-10-11 09:17:28 +02:00
core_write.cpp
core_write: Rename calculate_fee to have_undo for clarity
2021-10-05 10:42:34 +02:00
cuckoocache.h
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
dbwrapper.cpp
Improve fs::PathToString documentation
2021-11-15 12:08:49 -05:00
dbwrapper.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
Remove -rescan startup parameter
2021-09-30 12:06:27 +13:00
external_signer.cpp
external_signer: improve fingerprint matching logic (stop on first match)
2021-08-24 11:30:09 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
flatfile.h
…
fs.cpp
refactor: include a missing <limits> header in fs.cpp
2021-10-22 04:03:45 +03:00
fs.h
Improve fs::PathToString documentation
2021-11-15 12:08:49 -05:00
hash.cpp
refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization
2021-10-05 23:53:33 +02:00
hash.h
Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8
2021-04-23 11:35:15 -07:00
httprpc.cpp
Replace use of boost::trim use with locale-independent TrimString
2021-09-02 13:17:46 +08:00
httprpc.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
httpserver.cpp
Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
2021-10-04 22:45:43 +02:00
httpserver.h
…
i2p.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
i2p.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#23005: multiprocess: Delay wallet client construction
2021-11-15 18:08:49 +01:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
Better error messages for invalid addresses
2021-01-24 02:44:53 +01:00
key.cpp
Make signing follow BIP340 exactly w.r.t. aux randomness
2021-11-12 12:04:20 -05:00
key.h
Make signing follow BIP340 exactly w.r.t. aux randomness
2021-11-12 12:04:20 -05:00
logging.cpp
blockstorage: use debug log category
2021-10-11 21:45:49 +10:00
logging.h
blockstorage: use debug log category
2021-10-11 21:45:49 +10:00
Makefile.am
Merge bitcoin/bitcoin#23491: scripted-diff: Move minisketchwrapper to src/node
2021-11-16 16:09:25 +08:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
Makefile.leveldb.include
build: remove build stubs for external leveldb
2021-10-15 01:02:45 +00:00
Makefile.minisketch.include
build: add minisketch build file and include it
2021-10-21 09:37:30 +08:00
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
build: Fix make apk if ccache enabled
2021-11-08 07:19:10 +02:00
Makefile.qttest.include
multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations
2021-09-16 13:17:01 -05:00
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
move-only: unittest: add test/util/chainstate.h
2021-09-15 15:46:48 -04:00
Makefile.test.include
fuzz: Add minisketch fuzz test
2021-11-16 19:18:05 +01:00
Makefile.univalue.include
Integrate univalue into our buildsystem
2021-10-11 20:46:25 +08:00
mapport.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
mapport.h
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
style: Sort
2021-10-05 11:11:18 +02:00
miner.cpp
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
doc: Fix incorrect C++ named args
2021-11-17 09:25:14 +01:00
net_processing.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
net_types.cpp
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net_types.h
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net.cpp
doc: Fix incorrect C++ named args
2021-11-17 09:25:14 +01:00
net.h
Merge bitcoin/bitcoin#22735: [net] Don't return an optional from TransportDeserializer::GetMessage()
2021-11-02 13:40:09 +01:00
netaddress.cpp
net: take the first 4 random bits from CJDNS addresses in GetGroup()
2021-11-03 14:58:54 +01:00
netaddress.h
Merge bitcoin/bitcoin#22881: doc: provide context for CNetAddr::UnserializeV1Array() and span.h with lifetimebound
2021-11-17 17:06:55 +01:00
netbase.cpp
net: don't skip CJDNS from GetNetworkNames()
2021-11-03 14:58:53 +01:00
netbase.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
netmessagemaker.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
outputtype.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
outputtype.h
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
protocol.h
doc: Remove incorrect INIT_PROTO_VERSION from nTime comment
2021-08-23 18:53:34 +02:00
psbt.cpp
doc: Pick better named args for MutableTransactionSignatureCreator
2021-11-16 13:38:12 +01:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization
2021-10-05 23:53:33 +02:00
pubkey.h
fix XOnlyPubKey::IsFullyValid comment reference
2021-11-09 12:39:01 +01:00
random.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
random.h
…
randomenv.cpp
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
randomenv.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
rest.cpp
Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified)
2021-10-19 15:47:53 +02:00
reverse_iterator.h
…
scheduler.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
scheduler.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
shutdown.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
signet.cpp
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
Merge bitcoin/bitcoin#22881: doc: provide context for CNetAddr::UnserializeV1Array() and span.h with lifetimebound
2021-11-17 17:06:55 +01:00
streams.h
streams: Accept URef obj for VectorReader unserialize
2021-05-05 20:19:03 +02:00
sync.cpp
log: Avoid broken DEBUG_LOCKORDER log
2021-09-29 18:46:30 +02:00
sync.h
sync: inline lock contention logging macro to fix time duration
2021-09-06 23:43:51 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
threadsafety.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
timedata.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
torcontrol.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
txdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
txdb.h
Remove txindex migration code
2021-08-20 16:59:41 +02:00
txmempool.cpp
Merge bitcoin/bitcoin#23211: refactor: move update_* structs from txmempool.h to .cpp file
2021-11-03 08:59:03 +01:00
txmempool.h
Merge bitcoin/bitcoin#23211: refactor: move update_* structs from txmempool.h to .cpp file
2021-11-03 08:59:03 +01:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
[net processing] Add Orphanage empty consistency check
2021-07-20 13:12:42 +01:00
txrequest.cpp
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#23173: Add ChainstateManager::ProcessTransaction
2021-11-10 14:35:22 +01:00
validation.h
Merge bitcoin/bitcoin#23173: Add ChainstateManager::ProcessTransaction
2021-11-10 14:35:22 +01:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00