William Casarin a50d9e6c0b rpcwallet: default include_watchonly to true for watchonly wallets ...

The logic before would only include watchonly addresses if it was
explicitly set in the rpc argument.

This changes the logic like so:

If the include_watchonly argument is missing, check the
WALLET_FLAG_DISABLE_PRIVATE_KEYS flag to determine if we're working
with a watchonly wallet. If so, default include_watchonly to true.

If the include_watchonly argument is explicit set to false, we still
disable them from the listing. Although this would always return
nothing, it might be still useful in situations where you want to
explicitly filter out watchonly addresses regardless of what wallet
you are dealing with.

Signed-off-by: William Casarin <jb55@jb55.com>

2019-07-18 13:38:28 -07:00

..

test

Merge #16227: Refactor CWallet's inheritance chain

2019-07-11 22:42:39 +02:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

crypter.cpp

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

crypter.h

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

db.cpp

Make reasoning about dependencies easier by not including unused dependencies

2019-06-02 17:15:23 +02:00

db.h

…

feebumper.cpp

Replace CReserveKey with ReserveDestinatoin

2019-07-09 16:43:10 -04:00

feebumper.h

…

fees.cpp

[wallet] abort when attempting to fund a transaction above maxtxfee

2019-06-28 22:44:38 -04:00

fees.h

…

init.cpp

[build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)

2019-07-05 18:32:05 +02:00

ismine.cpp

Move various SigningProviders to signingprovider.{cpp,h}

2019-07-09 16:20:18 -04:00

ismine.h

Change ismine to take a CWallet instead of CKeyStore

2019-06-19 18:06:30 -04:00

load.cpp

…

load.h

…

psbtwallet.cpp

Merge #15427: Add support for descriptors to utxoupdatepsbt

2019-07-02 16:53:22 +02:00

psbtwallet.h

…

rpcdump.cpp

rpc: switch to using RPCHelpMan.Check()

2019-07-08 09:53:52 +09:00

rpcwallet.cpp

rpcwallet: default include_watchonly to true for watchonly wallets

2019-07-18 13:38:28 -07:00

rpcwallet.h

…

wallet.cpp

Merge #16227: Refactor CWallet's inheritance chain

2019-07-11 22:42:39 +02:00

wallet.h

Merge #16227: Refactor CWallet's inheritance chain

2019-07-11 22:42:39 +02:00

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

scripted-diff: Replace fprintf with tfm::format

2019-06-13 10:32:52 -04:00

wallettool.h

Move ismine to wallet module

2019-06-19 18:06:30 -04:00

walletutil.cpp

…

walletutil.h

…