MarcoFalke ffd5e7a856 Merge #20519: Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). ...

ce9dd45422 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a398e2 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd454
  theStack:
    ACK ce9dd45422 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874

2020-12-01 08:28:34 +01:00

..

asmap.cpp

…

asmap.h

…

bip32.cpp

…

bip32.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

bytevectorhash.cpp

…

bytevectorhash.h

…

check.h

…

error.cpp

…

error.h

…

fees.cpp

wallet: provide valid values if invalid estimate mode passed

2020-11-12 11:43:17 +01:00

fees.h

wallet: provide valid values if invalid estimate mode passed

2020-11-12 11:43:17 +01:00

golombrice.h

…

macros.h

…

memory.h

Use std::make_unique

2020-11-18 15:15:37 +01:00

message.cpp

…

message.h

…

moneystr.cpp

…

moneystr.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

rbf.cpp

…

rbf.h

…

ref.h

…

settings.cpp

…

settings.h

…

spanparsing.cpp

…

spanparsing.h

…

strencodings.cpp

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

strencodings.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

string.cpp

…

string.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

system.cpp

Merge #20080: Strip any trailing / in -datadir and -blocksdir paths

2020-11-02 11:41:38 +13:00

system.h

Merge #20519: Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

2020-12-01 08:28:34 +01:00

threadnames.cpp

…

threadnames.h

…

time.cpp

…

time.h

…

translation.h

…

ui_change_type.h

…

url.cpp

…

url.h

…

vector.h

…