Ava Chow cd1af852fa Merge bitcoin/bitcoin#34358: wallet: fix removeprunedfunds bug with conflicting transactions ...

1f60ca360e wallet: fix removeprunedfunds bug with conflicting transactions (Martin Zumsande)

Pull request description:

  `removeprunedfunds` removes all entries from `mapTxSpends` for the inputs of the pruned tx. However, this is incorrect, because there could be multiple entries from conflicting transactions (that shouldn't be removed as well). This could lead to the wallet creating invalid transactions, trying to double spend utxos.
  The bug persists when the conflicting tx was mined, because the wallet trusts its internal accounting instead of calling `AddToSpends` again.

  The added test should fail on master.

ACKs for top commit:
  achow101:
    ACK 1f60ca360e
  fjahr:
    tACK 1f60ca360e
  furszy:
    utACK 1f60ca360e
  vasild:
    ACK 1f60ca360e

Tree-SHA512: 3cc9ed547530fd53e25721177b76ab2e1eae16ce2c0e63fc01b20fdbf8bd02655dae51167ad56f9dec748d34c61ce65d38f993370820601f8257c73b876a3347

2026-01-28 11:25:28 -08:00

..

rpc

doc: fix invalid arg name hints for bugprone validation

2026-01-24 00:44:22 +01:00

test

doc: fix invalid arg name hints for bugprone validation

2026-01-24 00:44:22 +01:00

CMakeLists.txt

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

Merge bitcoin/bitcoin#33622: docs: add doc comment for SRD selection algorithm

2026-01-28 14:38:16 +01:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

load.cpp

…

load.h

…

migrate.cpp

…

migrate.h

…

receive.cpp

…

receive.h

…

scriptpubkeyman.cpp

…

scriptpubkeyman.h

…

spend.cpp

doc: fix invalid arg name hints for bugprone validation

2026-01-24 00:44:22 +01:00

spend.h

…

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

Merge bitcoin/bitcoin#34358: wallet: fix removeprunedfunds bug with conflicting transactions

2026-01-28 11:25:28 -08:00

wallet.h

Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet

2026-01-21 22:56:59 +01:00

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…