Ava Chow 3c88eac28e Merge bitcoin/bitcoin#29736: test: Extends wait_for_getheaders so a specific block hash can be checked ...

c4f857cc30 test: Extends wait_for_getheaders so a specific block hash can be checked (Sergi Delgado Segura)

Pull request description:

  Fixes https://github.com/bitcoin/bitcoin/issues/18614

  Previously, `wait_for_getheaders` would check whether a node had received **any** getheaders message. This implied that, if a test needed to check for a specific block hash within a headers message, it had to make sure that it was checking the desired message. This normally involved having to manually clear `last_message`. This method, apart from being too verbose, was error-prone, given an undesired `getheaders` would make tests pass.

  This adds the ability to check for a specific block_hash within the last `getheaders` message.

ACKs for top commit:
  achow101:
    ACK c4f857cc30
  BrandonOdiwuor:
    crACK c4f857cc30
  cbergqvist:
    ACK c4f857cc30
  stratospher:
    tested ACK c4f857c. went through all getheaders messages sent in the tests and checked that it's the one we want.

Tree-SHA512: afc9a31673344dfaaefcf692ec2ab65958c3d4c005f5f3af525e9960f0622d8246d5311e59aba06cfd5c9e0ef9eb90a7fc8e210f030bfbe67b897c061efdeed1

2024-04-25 13:26:21 -04:00

..

crypto

test: speedup bip324_cipher.py unit test

2024-02-06 01:35:03 +01:00

__init__.py

Rename rpc-tests directory to functional

2017-03-20 10:40:31 -04:00

address.py

refactor: move address_to_scriptpubkey to address.py

2023-03-28 16:54:28 +01:00

authproxy.py

test: Rename EncodeDecimal to serialization_fallback

2023-06-29 19:51:43 +02:00

bdb.py

scripted-diff: Bump copyright headers

2021-11-10 11:10:24 +01:00

bip340_test_vectors.csv

tests: add BIP340 Schnorr signature support to test framework

2020-10-12 17:18:47 -07:00

blockfilter.py

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

blocktools.py

refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey

2023-03-28 16:58:16 +01:00

coverage.py

test: fix PEP484 no implicit optional argument types errors

2023-06-29 16:14:07 -06:00

descriptors.py

Output a descriptor in createmultisig and addmultisigaddress

2020-01-30 23:55:36 -05:00

key.py

Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests

2023-11-07 16:48:57 -05:00

messages.py

test: p2p: check disconnect due to lack of desirable service flags

2024-03-11 15:23:09 +01:00

netutil.py

test: cover UNIX sockets in feature_proxy.py

2024-03-01 14:47:29 -05:00

p2p.py

test: Extends wait_for_getheaders so a specific block hash can be checked

2024-04-04 13:36:45 +02:00

psbt.py

test: PSBT: eliminate magic numbers for global unsigned tx key (0)

2023-03-04 12:43:38 +01:00

script_util.py

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

script.py

test: Fix SegwitV0SignatureMsg nLockTime signedness

2024-02-07 12:07:44 +01:00

segwit_addr.py

Use Bech32m encoding for v1+ segwit addresses

2021-03-16 10:48:36 -07:00

socks5.py

test: add keep_alive option to socks5 proxy in test_framework

2023-07-10 10:07:45 -04:00

test_framework.py

Merge bitcoin/bitcoin#29498: test: Update --tmpdir doc string to say directory must not exist

2024-04-09 09:43:28 +02:00

test_node.py

Merge bitcoin/bitcoin#29279: test: p2p: check disconnect due to lack of desirable service flags

2024-03-19 17:22:04 +00:00

test_shell.py

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

util.py

fixup: get all utxos up front in fill_mempool, discourage wallet mixing

2024-04-15 18:22:32 +02:00

v2_p2p.py

[test] make v2transport arg in addconnection mandatory and few cleanups

2024-01-31 22:37:54 +05:30

wallet_util.py

Fix typos in description.md and wallet_util.py

2024-04-25 16:14:10 +08:00

wallet.py

test framework: Add and use option for tx-version in MiniWallet methods

2024-02-08 21:50:55 +00:00