highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-10 07:35:40 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
a90f3922ff7dfeeeca027df62a130bc9b7d8fe23
bitcoin/src
History
Ava Chow a90f3922ff Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 
d31158d364 psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows (rkrux)

Pull request description:

  The unserialization flows of the PSBT types work based on few underlying assumptions of functions from `serialize.h` & `stream.h` that takes some to understand when read the first time.

  Add few comments that highlight these assumptions hopefully making it easier to grasp. Also, mention key/value format types as per BIP 174.

ACKs for top commit:
  achow101:
    ACK d31158d364
  theStack:
    ACK d31158d364

Tree-SHA512: 45111ef7f0258ebbc41d058b3ef2a72472774ab2878caf2d71d7b57b27549c46a51ccbeda5fe164bcf4f7ec10627bbae6e7763aa80b1e66912703a2088682817
2025-11-17 14:08:20 -08:00
..
bench
Merge bitcoin/bitcoin#32380: Modernize use of UTF-8 in Windows code
2025-10-28 22:41:07 +00:00
common
Merge bitcoin/bitcoin#32380: Modernize use of UTF-8 in Windows code
2025-10-28 22:41:07 +00:00
compat
net: remove unnecessary casts in socket operations
2025-09-16 06:26:01 -04:00
consensus
refactor: remove dead code in CountWitnessSigOps
2025-11-04 22:51:25 +01:00
crc32c
…
crypto
scripted-diff: remove whitespace in sha256_sse4.cpp
2025-11-11 11:12:50 +00:00
index
Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize
2025-11-12 09:48:10 -05:00
init
init: add exe name to bitcoind, bitcoin-node -version output to be able to distinguish these in tests
2025-09-17 04:57:09 -04:00
interfaces
Merge bitcoin/bitcoin#33745: mining: check witness commitment in submitBlock
2025-11-12 10:03:48 -05:00
ipc
Merge bitcoin/bitcoin#33676: interfaces: enable cancelling running waitNext calls
2025-11-10 09:56:27 +00:00
kernel
kernel: Allow null arguments for serialized data
2025-11-11 12:35:15 +01:00
leveldb
Update leveldb subtree to latest master
2025-10-16 13:49:49 +01:00
logging
…
minisketch
Update minisketch subtree to latest upstream
2025-10-13 12:33:23 +01:00
node
Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls
2025-11-12 10:16:29 -05:00
policy
Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize
2025-11-12 09:48:10 -05:00
primitives
…
qt
cmake: Specify Windows plugin path in test_bitcoin-qt property
2025-11-12 19:02:29 +00:00
rpc
Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize
2025-11-12 09:48:10 -05:00
script
Merge bitcoin/bitcoin#33786: script: remove dead code in CountWitnessSigOps
2025-11-07 12:46:46 +00:00
secp256k1
Update secp256k1 subtree to latest master
2025-10-15 09:49:11 +01:00
support
…
test
Merge bitcoin/bitcoin#33886: test: Remove tests violating hardened std::span
2025-11-17 14:00:05 +00:00
univalue
scripted-diff: change whitespace to spaces in univalue
2025-11-11 11:12:50 +00:00
util
Merge bitcoin/bitcoin#32482: build: add -W*-whitespace
2025-11-12 10:53:42 +00:00
wallet
scripted-diff: fix leftover references to policy/fees.h
2025-11-12 17:40:47 +00:00
zmq
ci: Update Clang in "tidy" job
2025-10-28 15:33:57 +00:00
.clang-format
…
.clang-tidy
…
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
refactor(headerssync): Extract test constants ahead of breakup into functions
2025-09-12 22:28:41 +02:00
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add pure kernel bitcoin-chainstate
2025-11-04 08:32:13 +01:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Remove no longer necessary WinCmdLineArgs class
2025-10-06 19:41:35 +01:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Remove no longer necessary WinCmdLineArgs class
2025-10-06 19:41:35 +01:00
bitcoin.cpp
Merge bitcoin/bitcoin#32380: Modernize use of UTF-8 in Windows code
2025-10-28 22:41:07 +00:00
bitcoind-res.rc
…
bitcoind.cpp
Remove no longer necessary WinCmdLineArgs class
2025-10-06 19:41:35 +01:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
blockfilter.h
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
chain.cpp
move-only: Move CBlockFileInfo to kernel namespace
2025-10-28 16:08:44 +01:00
chain.h
move-only: Move CBlockFileInfo to kernel namespace
2025-10-28 16:08:44 +01:00
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
contrib: update fixed seeds
2025-09-03 11:23:30 +01:00
checkqueue.h
…
clientversion.cpp
refactor: Avoid -W*-whitespace in git archive
2025-11-13 09:33:36 +01:00
clientversion.h
…
cluster_linearize.h
depgraph: add memory usage control (feature)
2025-10-11 17:25:09 -04:00
CMakeLists.txt
build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings
2025-11-12 19:50:11 -05:00
coins.cpp
refactor: Use uint64_t over size_t for serialized-size values
2025-10-30 17:51:40 +01:00
coins.h
refactor: remove redundant usage tracking from CoinsViewCacheCursor
2025-10-11 21:48:04 -04:00
compressor.cpp
…
compressor.h
…
core_io.h
rpc: add "ischange: true" in wallet gettransaction decoded tx output
2025-10-29 12:09:19 -04:00
core_memusage.h
…
core_read.cpp
…
core_write.cpp
Merge bitcoin/bitcoin#32517: rpc: add "ischange: true" to decoded tx outputs in wallet gettransaction response
2025-11-10 08:58:34 -08:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
refactor: Use fixed size ints over (un)signed ints for serialized values
2025-10-30 17:51:38 +01:00
hash.cpp
…
hash.h
…
headerssync.cpp
headerssync: Make HeadersSyncState more flexible and move constants
2025-09-12 22:28:41 +02:00
headerssync.h
headerssync: Make HeadersSyncState more flexible and move constants
2025-09-12 22:28:41 +02:00
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
net: remove unnecessary casts in socket operations
2025-09-16 06:26:01 -04:00
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls
2025-11-12 10:16:29 -05:00
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
Merge bitcoin/bitcoin#29675: wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys
2025-10-14 16:25:52 -04:00
key.h
sign: Add CreateMuSig2PartialSig
2025-09-30 11:06:43 -07:00
logging.cpp
kernel: Add logging to kernel library C header
2025-11-04 08:31:56 +01:00
logging.h
kernel: Add logging to kernel library C header
2025-11-04 08:31:56 +01:00
mapport.cpp
net: Add interrupt to pcp retry loop
2025-09-08 11:18:51 +02:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
musig.cpp
sign: Add CreateMuSig2AggregateSig
2025-09-30 11:06:43 -07:00
musig.h
Merge bitcoin/bitcoin#29675: wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys
2025-10-14 16:25:52 -04:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#32180: p2p: Advance pindexLastCommonBlock early after connecting blocks
2025-11-10 08:48:49 -08:00
net_processing.h
rpc/net: report per-peer last_inv_sequence
2025-09-22 10:46:26 +10:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#32983: rpc: refactor: use string_view in Arg/MaybeArg
2025-10-24 10:33:51 -07:00
net.h
Merge bitcoin/bitcoin#32983: rpc: refactor: use string_view in Arg/MaybeArg
2025-10-24 10:33:51 -07:00
netaddress.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
netaddress.h
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
netbase.cpp
net: remove unnecessary casts in socket operations
2025-09-16 06:26:01 -04:00
netbase.h
…
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
outputtype.h
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
psbt: MuSig2 data in Fill/FromSignatureData
2025-09-30 11:06:43 -07:00
psbt.h
Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows
2025-11-17 14:08:20 -08:00
pubkey.cpp
pubkey: Return tweaks from BIP32 derivation
2025-09-30 11:06:09 -07:00
pubkey.h
pubkey: Return tweaks from BIP32 derivation
2025-09-30 11:06:09 -07:00
random.cpp
…
random.h
…
randomenv.cpp
clang-tidy: Remove no longer needed NOLINT
2025-11-04 17:38:45 +00:00
randomenv.h
…
rest.cpp
refactor: Use STR_INTERNAL_BUG macro where possible
2025-11-06 14:19:25 +01:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
semaphore_grant.h
…
serialize.h
refactor: Return uint64_t from GetSerializeSize
2025-10-30 17:51:53 +01:00
signet.cpp
…
signet.h
…
span.h
…
streams.cpp
…
streams.h
…
sync.cpp
…
sync.h
…
threadsafety.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
Merge bitcoin/bitcoin#33042: refactor: inline constant return values from dbwrapper write methods
2025-11-10 09:15:24 -08:00
txdb.h
…
txgraph.cpp
refactor: remove dead branches in SingletonClusterImpl
2025-11-03 12:19:05 +01:00
txgraph.h
txgraph: expose memory usage estimate function (feature)
2025-10-11 17:25:09 -04:00
txmempool.cpp
…
txmempool.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#33042: refactor: inline constant return values from dbwrapper write methods
2025-11-10 09:15:24 -08:00
validation.h
doc: clarify UpdateUncommittedBlockStructures
2025-10-31 11:47:28 +01:00
validationinterface.cpp
…
validationinterface.h
…
versionbits_impl.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…